rockchip: pinctrl: use per-SoC option names for Kconfig
PATCH 1/2 rockchip: pinctrl: use per-SoC option names for Kconfig
The config options for pinctrl on the RK3188, RK3288, RK3328 and RK3399 previously showed up in menuconfig with the generic string descriptor "Rockchip pin control driver" requiring one to look through the help/full description to identify which chip each menu entry was for.
This change renames each option with the chip-name in the description string to make it easy to identify the configuration options in menuconfig.
---
drivers/pinctrl/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/pinctrl/Kconfig +4 -4
@@ -133,7 +133,7 @@ config ROCKCHIP_RK3036_PINCTRL function. config ROCKCHIP_RK3188_PINCTRL - bool "Rockchip pin control driver" + bool "Rockchip rk3188 pin control driver" depends on DM help Support pin multiplexing control on Rockchip rk3188 SoCs. The driver
@@ -142,7 +142,7 @@ config ROCKCHIP_RK3188_PINCTRL function. config ROCKCHIP_RK3288_PINCTRL - bool "Rockchip pin control driver" + bool "Rockchip rk3288 pin control driver" depends on DM help Support pin multiplexing control on Rockchip rk3288 SoCs. The driver
@@ -158,7 +158,7 @@ config PINCTRL_AT91PIO4 controller which is available on SAMA5D2 SoC. config ROCKCHIP_RK3328_PINCTRL - bool "Rockchip pin control driver" + bool "Rockchip rk3328 pin control driver" depends on DM help Support pin multiplexing control on Rockchip rk3328 SoCs. The driver
@@ -167,7 +167,7 @@ config ROCKCHIP_RK3328_PINCTRL function. config ROCKCHIP_RK3399_PINCTRL - bool "Rockchip pin control driver" + bool "Rockchip rk3399 pin control driver" depends on DM help Support pin multiplexing control on Rockchip rk3399 SoCs. The driver
Signature · 1 line
1.9.1
PATCH 2/2 pinctrl: Kconfig: reorder to keep Rockchip options together
---
drivers/pinctrl/Kconfig | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/pinctrl/Kconfig +7 -7
@@ -150,13 +150,6 @@ config ROCKCHIP_RK3288_PINCTRL definitions and pin control functions for each available multiplex function. -config PINCTRL_AT91PIO4 - bool "AT91 PIO4 pinctrl driver" - depends on DM - help - This option is to enable the AT91 pinctrl driver for AT91 PIO4 - controller which is available on SAMA5D2 SoC. - config ROCKCHIP_RK3328_PINCTRL bool "Rockchip rk3328 pin control driver" depends on DM
@@ -175,6 +168,13 @@ config ROCKCHIP_RK3399_PINCTRL definitions and pin control functions for each available multiplex function. +config PINCTRL_AT91PIO4 + bool "AT91 PIO4 pinctrl driver" + depends on DM + help + This option is to enable the AT91 pinctrl driver for AT91 PIO4 + controller which is available on SAMA5D2 SoC. + config PINCTRL_SANDBOX bool "Sandbox pinctrl driver" depends on SANDBOX
Signature · 1 line
1.9.1
PATCH 2/2 pinctrl: Kconfig: reorder to keep Rockchip options together
Am Freitag, 17. März 2017, 20:41:04 CET schrieb Philipp Tomsich:
Quoted 29 lines
Signed-off-by Philipp Tomsich <[email protected]>---
drivers/pinctrl/Kconfig | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)drivers/pinctrl/Kconfig +0
-7@@ -150,13 +150,6 @@ config ROCKCHIP_RK3288_PINCTRL definitions and pin control functions for each available multiplex function. -config PINCTRL_AT91PIO4 - bool "AT91 PIO4 pinctrl driver" - depends on DM - help - This option is to enable the AT91 pinctrl driver for AT91 PIO4 - controller which is available on SAMA5D2 SoC. - config ROCKCHIP_RK3328_PINCTRL bool "Rockchip rk3328 pin control driver" depends on DM@@ -175,6 +168,13 @@ config ROCKCHIP_RK3399_PINCTRL definitions and pin control functions for each available multiplex function.
drivers/pinctrl/Kconfig config ROCKCHIP_RK3399_PINCTRL · line 180
Quoted 10 lines
drivers/pinctrl/Kconfig +7
-0+config PINCTRL_AT91PIO4 + bool "AT91 PIO4 pinctrl driver" + depends on DM + help + This option is to enable the AT91 pinctrl driver for AT91 PIO4 + controller which is available on SAMA5D2 SoC. + config PINCTRL_SANDBOX bool "Sandbox pinctrl driver" depends on SANDBOX
wouldn't it be nicer to try to get an alphabetical ordering going? That would also prevent future clutter.
Heiko
PATCH 1/2 rockchip: pinctrl: use per-SoC option names for Kconfig
In reply to Philipp TomsichAm Freitag, 17. März 2017, 20:41:03 CET schrieb Philipp Tomsich:
Quoted 11 lines
The config options for pinctrl on the RK3188, RK3288, RK3328 and RK3399 previously showed up in menuconfig with the generic string descriptor "Rockchip pin control driver" requiring one to look through the help/full description to identify which chip each menu entry was for.
This change renames each option with the chip-name in the description string to make it easy to identify the configuration options in menuconfig.
Signed-off-by Philipp Tomsich <[email protected]>
the joys of copy'n'paste and premade defconfigs :-)
Quoted 45 lines
---
drivers/pinctrl/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/pinctrl/Kconfig +4
-4@@ -133,7 +133,7 @@ config ROCKCHIP_RK3036_PINCTRL function. config ROCKCHIP_RK3188_PINCTRL - bool "Rockchip pin control driver" + bool "Rockchip rk3188 pin control driver" depends on DM help Support pin multiplexing control on Rockchip rk3188 SoCs. The driver@@ -142,7 +142,7 @@ config ROCKCHIP_RK3188_PINCTRL function. config ROCKCHIP_RK3288_PINCTRL - bool "Rockchip pin control driver" + bool "Rockchip rk3288 pin control driver" depends on DM help Support pin multiplexing control on Rockchip rk3288 SoCs. The driver@@ -158,7 +158,7 @@ config PINCTRL_AT91PIO4 controller which is available on SAMA5D2 SoC. config ROCKCHIP_RK3328_PINCTRL - bool "Rockchip pin control driver" + bool "Rockchip rk3328 pin control driver" depends on DM help Support pin multiplexing control on Rockchip rk3328 SoCs. The driver@@ -167,7 +167,7 @@ config ROCKCHIP_RK3328_PINCTRL function. config ROCKCHIP_RK3399_PINCTRL - bool "Rockchip pin control driver" + bool "Rockchip rk3399 pin control driver" depends on DM help Support pin multiplexing control on Rockchip rk3399 SoCs. The driver
PATCH 1/2 rockchip: pinctrl: use per-SoC option names for Kconfig
In reply to Philipp TomsichQuoted 10 lines · Philipp Tomsich
The config options for pinctrl on the RK3188, RK3288, RK3328 and RK3399 previously showed up in menuconfig with the generic string descriptor "Rockchip pin control driver" requiring one to look through the help/full description to identify which chip each menu entry was for.
This change renames each option with the chip-name in the description string to make it easy to identify the configuration options in menuconfig.
Quoted 5 lines
Signed-off-by Philipp Tomsich <[email protected]>---
drivers/pinctrl/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
PATCH 1/2 rockchip: pinctrl: use per-SoC option names for Kconfig
Quoted 12 lines · Simon Glass
Quoted 10 lines · Philipp Tomsich
The config options for pinctrl on the RK3188, RK3288, RK3328 and RK3399 previously showed up in menuconfig with the generic string descriptor "Rockchip pin control driver" requiring one to look through the help/full description to identify which chip each menu entry was for.
This change renames each option with the chip-name in the description string to make it easy to identify the configuration options in menuconfig.
Quoted 7 lines
Quoted 5 lines
Signed-off-by Philipp Tomsich <[email protected]>---
drivers/pinctrl/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)Reviewed-by Simon Glass <[email protected]>
Applied to u-boot-rockchip, thanks!