Skip to contentSkip to conversation

arm: dts: rk3288: Add missing #sound-dai-cells

PATCH New Rob Herring 2 participants 2 messages Mar 1, 2018 – Mar 12, 2018

Subsystems (2)
Device tree bindings Arm Rockchip
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 arm: dts: rk3288: Add missing #sound-dai-cells

dtc now gives the following warning:

arch/arm/boot/dts/rk3288-tinker.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /hdmi at ff980000 or bad phandle (referred from sound-dai[0])

Add the missing #sound-dai-cells property.

Cc Heiko Stuebner <[email protected]>
Cc linux-rockchip at lists.infradead.org
Signed-off-by Rob Herring <[email protected]>
---
 arch/arm/boot/dts/rk3288.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/rk3288.dtsi +2 -0
index 6102e4e7f35c..354aff45c1af 100644
@@ -927,6 +927,7 @@
 	i2s: i2s at ff890000 {
 		compatible = "rockchip,rk3288-i2s", "rockchip,rk3066-i2s";
 		reg = <0x0 0xff890000 0x0 0x10000>;
+		#sound-dai-cells = <0>;
 		interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
 		#address-cells = <1>;
 		#size-cells = <0>;

@@ -1176,6 +1177,7 @@
 		compatible = "rockchip,rk3288-dw-hdmi";
 		reg = <0x0 0xff980000 0x0 0x20000>;
 		reg-io-width = <4>;
+		#sound-dai-cells = <0>;
 		rockchip,grf = <&grf>;
 		interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
 		clocks = <&cru  PCLK_HDMI_CTRL>, <&cru SCLK_HDMI_HDCP>, <&cru SCLK_HDMI_CEC>;
Signature · 1 line
2.14.1
maintainer Applied
#1 lore raw

PATCH 1/1 arm: dts: rk3288: Add missing #sound-dai-cells

Am Donnerstag, 1. M?rz 2018, 21:25:35 CET schrieb Rob Herring:

Quoted 11 lines

dtc now gives the following warning:

arch/arm/boot/dts/rk3288-tinker.dtb: Warning (sound_dai_property):
/sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /hdmi at ff980000 or bad phandle (referred from sound-dai[0])

Add the missing #sound-dai-cells property.

Cc Heiko Stuebner <[email protected]>
Cc linux-rockchip at lists.infradead.org
Signed-off-by Rob Herring <[email protected]>

applied as fix for 4.16 (on 2018-03-05 already)

Thanks for the catch
Heiko