Skip to contentSkip to conversation

validateascii in idmapd.c access beyond end of array.

PATCH New Neil Brown 1 participant 1 message Feb 18, 2008

Subsystems (2)
lore
Share & tools
lore

Neil Brown

author
#0 lore raw

PATCH 1/1 validateascii in idmapd.c access beyond end of array.

If validateascii is passed a string containing only non-zero 7bit values, then the loop with exit with i == len, and the following test will access beyond the end of the array.

So add an extra test to fix this.

Found by Marcus Meissner <[email protected]>.

utils/idmapd/idmapd.c +1 -1
index 355c6e1..6b5971c 100644
@@ -848,7 +848,7 @@ validateascii(char *string, u_int32_t len)
 			return (-1);
 	}
 
-	if (string[i] != '\0')
+	if ((i >= len) || string[i] != '\0')
 		return (-1);
 
 	return (i + 1);