Checking for incorrect MODULE_PARM

DISCUSSION Keith Owens 2 participants 3 messages Dec 10, 2000 – Dec 11, 2000 Networking

Share & tools

Keith Owens

author

2000-12-10 12:37 UTC #0 lore raw

modutils 2.3.22 does more rigorous checking of MODULE_PARM entries and has already found several cases where MODULE_PARM(x) is used but the corresponding variable 'x' is not defined. These are module coding bugs that were previously hidden. Run this script to do a quick check of all your modules against modutils 2.3.22. Run as any user, does not have not be root.

for i in $(/sbin/modprobe -l)
do

	(echo -e "\n" $i ; /sbin/modinfo -p $i) > /var/tmp/modinfo
	grep warning /var/tmp/modinfo > /dev/null && cat /var/tmp/modinfo

done

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

Horst von Brand

2000-12-10 23:59 UTC #1 lore raw

Quoted 7 lines · Keith Owens

modutils 2.3.22 does more rigorous checking of MODULE_PARM entries and has already found several cases where MODULE_PARM(x) is used but the corresponding variable 'x' is not defined. These are module coding bugs that were previously hidden. Run this script to do a quick check of all your modules against modutils 2.3.22. Run as any user, does not have not be root.

Quoted 5 lines

for i in $(/sbin/modprobe -l)
do

	(echo -e "\n" $i ; /sbin/modinfo -p $i) > /var/tmp/modinfo
	grep warning /var/tmp/modinfo > /dev/null && cat /var/tmp/modinfo

done

With 2.2.18pre27 on i686 I get:

/lib/modules/2.2.18/ipv4/ip_masq_user.o
warning: symbol for parameter ports not found
ports int array (min = 1, max = 12)
debug int

Hope this helps a bit.

Signature · 6 lines

Horst von Brand                             [email protected]
Casilla 9G, Vin~a del Mar, Chile                               +56 32 672616
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

Keith Owens

author

2000-12-11 00:30 UTC #2 lore raw

Quoted 6 lines · Horst von Brand

With 2.2.18pre27 on i686 I get:
/lib/modules/2.2.18/ipv4/ip_masq_user.o
warning: symbol for parameter ports not found
ports int array (min = 1, max = 12)
debug int

ports is not used in ip_masq_user, dead code. Trivial patch.

Index: 18-pre27.1/net/ipv4/ip_masq_user.c

net/ipv4/ip_masq_user.c Mon, 11 Dec 2000 10:55:38 +1100 kaos (linux-2.2/e/11_ip_masq_us 1.2.3.1.1.2 644) renamed from net/ipv4/ip_masq_user.c Sun, 01 Oct 2000 19:35:12 +1100 kaos (linux-2.2/e/11_ip_masq_us 1.2.3.1.1.2 644) +0 -1

@@ -35,7 +35,6 @@
  */
 static int debug=0;
 
-MODULE_PARM(ports, "1-" __MODULE_STRING(MAX_MASQ_APP_PORTS) "i");
 MODULE_PARM(debug, "i");
 
 /*

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/