Skip to contentSkip to conversation

examples/vm_power_manager: fix string overflow

PATCH Applied Reshma Pattan 3 participants 3 messages Apr 10, 2019 – Apr 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 examples/vm_power_manager: fix string overflow

Use strlcpy instead of strcpy to fix string overflow.

Coverity issue: 337671

Fixes a63504a90f ("examples/power: add JSON string handling")
---
 examples/vm_power_manager/channel_monitor.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
examples/vm_power_manager/channel_monitor.c +2 -1
index 74df0fe20..0b44a74b5 100644
@@ -159,7 +159,8 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt)
 			if (ret)
 				return ret;
 		} else if (!strcmp(key, "name")) {
-			strcpy(pkt->vm_name, json_string_value(value));
+			strlcpy(pkt->vm_name, json_string_value(value),
+					sizeof(pkt->vm_name));
 		} else if (!strcmp(key, "command")) {
 			char command[32];
 			strlcpy(command, json_string_value(value), 32);
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 17 lines · Reshma Pattan

Use strlcpy instead of strcpy to fix string overflow.

Coverity issue: 337671

Fixes a63504a90f ("examples/power: add JSON string handling")
---
  examples/vm_power_manager/channel_monitor.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
examples/vm_power_manager/channel_monitor.c +0 -0
index 74df0fe20..0b44a74b5 100644

examples/vm_power_manager/channel_monitor.c parse_json_to_pkt(json_t *element, struct channel_packet *pkt) · line 166

Quoted 9 lines
examples/vm_power_manager/channel_monitor.c +2 -1
@@ -159,7 +159,8 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt)
  			if (ret)
  				return ret;
  		} else if (!strcmp(key, "name")) {
-			strcpy(pkt->vm_name, json_string_value(value));
+			strlcpy(pkt->vm_name, json_string_value(value),
+					sizeof(pkt->vm_name));
  		} else if (!strcmp(key, "command")) {
  			char command[32];
  			strlcpy(command, json_string_value(value), 32);