ipmi: ipmb: Remove I2C_CLASS_HWMON from drivers w/o detect and address_list
Subsystems (2)
PATCH 1/1 ipmi: ipmb: Remove I2C_CLASS_HWMON from drivers w/o detect and address_list
Class-based I2C probing requires detect() and address_list to be set in the I2C client driver, see checks in i2c_detect(). It's misleading to declare I2C_CLASS_HWMON support if this precondition isn't met.
--- drivers/char/ipmi/ipmi_ipmb.c | 1 - 1 file changed, 1 deletion(-)
drivers/char/ipmi/ipmi_ipmb.c +0 -1
@@ -567,7 +567,6 @@ static const struct i2c_device_id ipmi_ipmb_id[] = {MODULE_DEVICE_TABLE (i2c, ipmi_ipmb_id);static struct i2c_driver ipmi_ipmb_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name =DEVICE_NAME , .of_match_table = of_ipmi_ipmb_match,
Signature · 1 line
2.43.0
Quoted 6 lines · Heiner Kallweit
Class-based I2C probing requires
detect()andaddress_listto be set in the I2C client driver, see checks ini2c_detect(). It's misleading to declareI2C_CLASS_HWMONsupport if this precondition isn't met.Signed-off-by Heiner Kallweit <[email protected]>
Quoted 5 lines · Heiner Kallweit
Class-based I2C probing requires
detect()andaddress_listto be set in the I2C client driver, see checks ini2c_detect(). It's misleading to declareI2C_CLASS_HWMONsupport if this precondition isn't met.
Any feedback here? Should this better go through the I2C tree?
Quoted 17 lines
Signed-off-by Heiner Kallweit <[email protected]>--- drivers/char/ipmi/ipmi_ipmb.c | 1 - 1 file changed, 1 deletion(-)drivers/char/ipmi/ipmi_ipmb.c +0
-1@@ -567,7 +567,6 @@ static const struct i2c_device_id ipmi_ipmb_id[] = {MODULE_DEVICE_TABLE (i2c, ipmi_ipmb_id);static struct i2c_driver ipmi_ipmb_driver = { - .class =I2C_CLASS_HWMON , .driver = { .name =DEVICE_NAME , .of_match_table = of_ipmi_ipmb_match,