Skip to contentSkip to conversation

ACPI / APEI: Get rid of NULL_UUID_LE constant

PATCH Applied Andy Shevchenko 3 participants 3 messages Jul 17, 2019 – Aug 26, 2019

Subsystems (2)
ACPI ACPI APEI
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 ACPI / APEI: Get rid of NULL_UUID_LE constant

This is a missed part of the commit 5b53696a30d5 ("ACPI / APEI: Switch to use new generic UUID API"), i.e. replacing old definition with a global constant variable.

Cc Borislav Petkov <[email protected]>
Cc Christoph Hellwig <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/acpi/apei/ghes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/apei/ghes.c +1 -1
index a66e00fe31fe..451269a2f47c 100644
@@ -483,7 +483,7 @@ static void ghes_do_proc(struct ghes *ghes,
 	int sev, sec_sev;
 	struct acpi_hest_generic_data *gdata;
 	guid_t *sec_type;
-	guid_t *fru_id = &NULL_UUID_LE;
+	const guid_t *fru_id = &guid_null;
 	char *fru_text = "";
 
 	sev = ghes_severity(estatus->error_severity);
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 3 lines · Andy Shevchenko

This is a missed part of the commit 5b53696a30d5 ("ACPI / APEI: Switch to use new generic UUID API"), i.e. replacing old definition with a global constant variable.

Reviewed-by James Morse <[email protected]>

Thanks,

James

Applied
#2 lore raw
In reply to Andy Shevchenko
Quoted 17 lines · CEST Andy Shevchenko

This is a missed part of the commit 5b53696a30d5 ("ACPI / APEI: Switch to use new generic UUID API"), i.e. replacing old definition with a global constant variable.

Cc Borislav Petkov <[email protected]>
Cc Christoph Hellwig <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/acpi/apei/ghes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/apei/ghes.c +0 -0
index a66e00fe31fe..451269a2f47c 100644

drivers/acpi/apei/ghes.c static void ghes_do_proc(struct ghes *ghes, · line 489

Quoted 8 lines
drivers/acpi/apei/ghes.c +1 -1
@@ -483,7 +483,7 @@ static void ghes_do_proc(struct ghes *ghes,
 	int sev, sec_sev;
 	struct acpi_hest_generic_data *gdata;
 	guid_t *sec_type;
-	guid_t *fru_id = &NULL_UUID_LE;
+	const guid_t *fru_id = &guid_null;
 	char *fru_text = "";
 
 	sev = ghes_severity(estatus->error_severity);

Applied, thanks!