Skip to contentSkip to conversation

Add LBA3368 board

PATCH Applied Alex Bee 3 participants 8 messages Jun 23, 2024 – Jun 26, 2024

Subsystems (2)
lore
Share & tools
lore

Alex Bee

author
#0 lore raw

v2 cover Add LBA3368 board

This series aims to add support for RK3368 based LBA3368 industrial board form Neardi. The device tree currently only contains entries for which both bindings and linux driver exists and is expected to be exended in future.

NB: checkpatch throws me a warning that no venddor-prefix for "usb5e3" exists - which is true - but "usb5e3,610" has a valid binding.

Changes in v2:
- board DT property re-ordering / fixes

Link to v1:
https://lore.kernel.org/all/[email protected]/

Alex Bee (4):
dt-bindings: vendor-prefixes: Add Neardi Technology
dt-bindings: arm: rockchip: Add Neardi LBA3368
arm64: dts: rockchip: Add sound-dai-cells for RK3368
arm64: dts: rockchip: Add Neardi LBA3368 board

 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3368-lba3368.dts      | 661 ++++++++++++++++++
 arch/arm64/boot/dts/rockchip/rk3368.dtsi      |   3 +
 5 files changed, 672 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts
Signature · 1 line
2.45.2
author
#1 lore raw

PATCH v2 1/4 dt-bindings: vendor-prefixes: Add Neardi Technology

Add vendor prefix for Shanghai Neardi Technology Co., Ltd.
(http://neardi.com/)

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index fbf47f0bacf1..6e879abec71d 100644
@@ -995,6 +995,8 @@ patternProperties:
     description: MYIR Tech Limited
   "^national,.*":
     description: National Semiconductor
+  "^neardi,.*":
+    description: Shanghai Neardi Technology Co., Ltd.
   "^nec,.*":
     description: NEC LCD Technologies, Ltd.
   "^neonode,.*":
Signature · 1 line
2.45.2
author
#2 lore raw

PATCH v2 2/4 dt-bindings: arm: rockchip: Add Neardi LBA3368

In reply to Alex Bee

Add Neardi LBA3368, a RK3368 based industrial board.

---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
index eca0a42eb384..d2e887415d5d 100644
@@ -634,6 +634,11 @@ properties:
           - const: mqmaker,miqi
           - const: rockchip,rk3288
 
+      - description: Neardi LBA3368
+        items:
+          - const: neardi,lba3368
+          - const: rockchip,rk3368
+
       - description: Netxeon R89 board
         items:
           - const: netxeon,r89
Signature · 1 line
2.45.2
author
#3 lore raw

PATCH v2 3/4 arm64: dts: rockchip: Add sound-dai-cells for RK3368

In reply to Alex Bee

Add the missing #sound-dai-cells for RK3368's I2S and S/PDIF controllers.

Fixes f7d89dfe1e31 ("arm64: dts: rockchip: add i2s nodes support for RK3368 SoCs")
Fixes 0328d68ea76d ("arm64: dts: rockchip: add rk3368 spdif node")
---
 arch/arm64/boot/dts/rockchip/rk3368.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/rockchip/rk3368.dtsi +3 -0
index 734f87db4d11..73618df7a889 100644
@@ -793,6 +793,7 @@ spdif: spdif@ff880000 {
 		dma-names = "tx";
 		pinctrl-names = "default";
 		pinctrl-0 = <&spdif_tx>;
+		#sound-dai-cells = <0>;
 		status = "disabled";
 	};
 
@@ -804,6 +805,7 @@ i2s_2ch: i2s-2ch@ff890000 {
 		clocks = <&cru SCLK_I2S_2CH>, <&cru HCLK_I2S_2CH>;
 		dmas = <&dmac_bus 6>, <&dmac_bus 7>;
 		dma-names = "tx", "rx";
+		#sound-dai-cells = <0>;
 		status = "disabled";
 	};
 
@@ -817,6 +819,7 @@ i2s_8ch: i2s-8ch@ff898000 {
 		dma-names = "tx", "rx";
 		pinctrl-names = "default";
 		pinctrl-0 = <&i2s_8ch_bus>;
+		#sound-dai-cells = <0>;
 		status = "disabled";
 	};
 
Signature · 1 line
2.45.2
author
#4 lore raw

PATCH v2 4/4 arm64: dts: rockchip: Add Neardi LBA3368 board

In reply to Alex Bee

LBA3368 is a RK3368 based industrial board from Neardi.

Specs:
- 1 GB DDR3 DRAM
- 8/16 GB eMMC
- µSD slot
- 100 mbit ethernet (optional 12V PoE)
- Ampak AP6255 Wifi/BT combo
- ADC button
- 4 x USB 2.0 via onboard GL852G HUB connected to SoC's ehci host
- 2 exposed as USB-A
- 2 via 2-mm-4-pin connectors
- micro USB OTG connector
- 2 x UART TTL (2-mm-4-pin connectors)
- CSI connector
- DSI connector
- eDP connector
- HDMI 2.0a output (type A)
- touchpad connector (I2C, 3.3V)
- ALC5640 audio codec
- combined headphone/microphone jack
- speaker connector pads

---
changes since v1:
- added missing pinctl-names for gpio-leds
- drop min-/max voltage for rk808's regulator swtiches
- fix bluetooth max-speed: 1500000 => 15000000
- replace deprecated "host-wakeup-gpios" with "host-wake" interrupt for bluetooth
- alignment of property-order for nodes of the same type

 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3368-lba3368.dts      | 661 ++++++++++++++++++
 2 files changed, 662 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 85d949f2c909..90f5172f37e6 100644
@@ -28,6 +28,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-roc-cc.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-roc-pc.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-evb-act8846.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-geekbox.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-lba3368.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-lion-haikou.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-orion-r68-meta.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-px5-evb.dtb
arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts new file +661 -0

661 lines not on this page · raw message

Signature · 1 line
2.45.2
maintainer Applied
#5 lore raw
In reply to Alex Bee
Quoted 8 lines · Alex Bee

This series aims to add support for RK3368 based LBA3368 industrial board form Neardi. The device tree currently only contains entries for which both bindings and linux driver exists and is expected to be exended in future.

NB: checkpatch throws me a warning that no venddor-prefix for "usb5e3" exists - which is true - but "usb5e3,610" has a valid binding.

[...]

Applied, thanks!

[1/4] dt-bindings: vendor-prefixes: Add Neardi Technology

      commit: 79cba74263d96ab1848eb04862f72f8988eb0486
[2/4] dt-bindings: arm: rockchip: Add Neardi LBA3368
      commit: a30a6386ecc1f6ff71d4f7606bed25b7075476ab
[3/4] arm64: dts: rockchip: Add sound-dai-cells for RK3368
      commit: 8d7ec44aa5d1eb94a30319074762a1740440cdc8
[4/4] arm64: dts: rockchip: Add Neardi LBA3368 board
      commit: 7b4a8097e58b608638d416bd57469f8a9ab70e7b

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>
#6 lore raw
In reply to Alex Bee
Quoted 27 lines · Alex Bee

This series aims to add support for RK3368 based LBA3368 industrial board form Neardi. The device tree currently only contains entries for which both bindings and linux driver exists and is expected to be exended in future.

NB: checkpatch throws me a warning that no venddor-prefix for "usb5e3" exists - which is true - but "usb5e3,610" has a valid binding.

Changes in v2:
- board DT property re-ordering / fixes

Link to v1:
https://lore.kernel.org/all/[email protected]/

Alex Bee (4):
dt-bindings: vendor-prefixes: Add Neardi Technology
dt-bindings: arm: rockchip: Add Neardi LBA3368
arm64: dts: rockchip: Add sound-dai-cells for RK3368
arm64: dts: rockchip: Add Neardi LBA3368 board

 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3368-lba3368.dts      | 661 ++++++++++++++++++
 arch/arm64/boot/dts/rockchip/rk3368.dtsi      |   3 +
 5 files changed, 672 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts
Quoted 5 lines

--
2.45.2

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y rockchip/rk3368-lba3368.dtb' for [email protected]:

arch/arm64/boot/dts/rockchip/rk3368-lba3368.dtb: /i2c@ff660000/codec@1c: failed to match any schema with compatible: ['realtek,rt5640'] arch/arm64/boot/dts/rockchip/rk3368-lba3368.dtb: /mbox@ff6b0000: failed to match any schema with compatible: ['rockchip,rk3368-mailbox']

maintainer
#7 lore raw

Am Mittwoch, 26. Juni 2024, 15:25:12 CEST schrieb Rob Herring (Arm):

Quoted 47 lines · Alex Bee
Quoted 27 lines

This series aims to add support for RK3368 based LBA3368 industrial board form Neardi. The device tree currently only contains entries for which both bindings and linux driver exists and is expected to be exended in future.

NB: checkpatch throws me a warning that no venddor-prefix for "usb5e3" exists - which is true - but "usb5e3,610" has a valid binding.

Changes in v2:
- board DT property re-ordering / fixes

Link to v1:
https://lore.kernel.org/all/[email protected]/

Alex Bee (4):
dt-bindings: vendor-prefixes: Add Neardi Technology
dt-bindings: arm: rockchip: Add Neardi LBA3368
arm64: dts: rockchip: Add sound-dai-cells for RK3368
arm64: dts: rockchip: Add Neardi LBA3368 board

 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3368-lba3368.dts      | 661 ++++++++++++++++++
 arch/arm64/boot/dts/rockchip/rk3368.dtsi      |   3 +
 5 files changed, 672 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts
Quoted 5 lines

--
2.45.2

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

Quoted 7 lines
  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y rockchip/rk3368-lba3368.dtb' for [email protected]:

arch/arm64/boot/dts/rockchip/rk3368-lba3368.dtb: /i2c@ff660000/codec@1c: failed to match any schema with compatible: ['realtek,rt5640'] arch/arm64/boot/dts/rockchip/rk3368-lba3368.dtb: /mbox@ff6b0000: failed to match any schema with compatible: ['rockchip,rk3368-mailbox']

both of those are still in their .txt format, so not yet converted to yaml.