cpufreq: schedutil: Simplify sugov_fast_switch()
Subsystems (2)
PATCH 1/1 cpufreq: schedutil: Simplify sugov_fast_switch()
From: Rafael J. Wysocki <[email protected]>
Drop a redundant local variable definition from sugov_fast_switch() and rearrange the code in there to avoid the redundant logical negation.
---
The code reads a bit easier after this change IMV.
linux-next material.
--- kernel/sched/cpufreq_schedutil.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
kernel/sched/cpufreq_schedutil.c +2 -6
@@ -114,12 +114,8 @@ static bool sugov_update_next_freq(strucstatic void sugov_fast_switch (struct sugov_policy *sg_policy,u64 time,unsigned int next_freq) { -struct cpufreq_policy *policy = sg_policy->policy; - -if (!sugov_update_next_freq (sg_policy, time, next_freq)) -return ; - -cpufreq_driver_fast_switch (policy, next_freq); +if (sugov_update_next_freq (sg_policy, time, next_freq)) +cpufreq_driver_fast_switch (sg_policy->policy, next_freq); } static void sugov_deferred_update(struct sugov_policy *sg_policy, u64 time,
Quoted 26 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
Drop a redundant local variable definition from
sugov_fast_switch()and rearrange the code in there to avoid the redundant logical negation.Signed-off-by Rafael J. Wysocki <[email protected]>---
The code reads a bit easier after this change IMV.
linux-next material.
--- kernel/sched/cpufreq_schedutil.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)Index:
linux-pm/kernel/sched/cpufreq_schedutil.c
===================================================================kernel/sched/cpufreq_schedutil.c +0
-1@@ -114,12 +114,8 @@ static bool sugov_update_next_freq(strucstatic void sugov_fast_switch (struct sugov_policy *sg_policy,u64 time,unsigned int next_freq) { -struct cpufreq_policy *policy = sg_policy->policy;
kernel/sched/cpufreq_schedutil.c static bool sugov_update_next_freq(struc · line 121
Quoted 10 lines
kernel/sched/cpufreq_schedutil.c +2
-5- -if (!sugov_update_next_freq (sg_policy, time, next_freq)) -return ; - -cpufreq_driver_fast_switch (policy, next_freq); +if (sugov_update_next_freq (sg_policy, time, next_freq)) +cpufreq_driver_fast_switch (sg_policy->policy, next_freq); } static void sugov_deferred_update(struct sugov_policy *sg_policy, u64 time,
Signature · 1 line
viresh