Skip to contentSkip to conversation

Merge usb-wacom.c into usb-hid.c

PATCH In review François Revol 4 participants 10 messages Apr 28, 2009 – Apr 29, 2009 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Merge usb-wacom.c into usb-hid.c

$subj;
Cleaned up a bit from last RFC, still works fine here with
http://dev.haiku-os.org/browser/haiku/trunk/3rdparty/mmu_man/onlinedemo/haiku.php

François.

---
 Makefile       |    2 +-
 hw/usb-hid.c   |  322 +++++++++++++++++++++++++++++++++++---------
 hw/usb-wacom.c |  412 --------------------------------------------------------
 3 files changed, 260 insertions(+), 476 deletions(-)
Makefile +1 -1
index 0f40cda..c03d587 100644
@@ -92,7 +92,7 @@ OBJS+=ssd0303.o ssd0323.o ads7846.o stellaris_input.o twl92230.o
 OBJS+=tmp105.o lm832x.o eeprom93xx.o tsc2005.o
 OBJS+=scsi-disk.o cdrom.o
 OBJS+=scsi-generic.o
-OBJS+=usb.o usb-hub.o usb-$(HOST_USB).o usb-hid.o usb-msd.o usb-wacom.o
+OBJS+=usb.o usb-hub.o usb-$(HOST_USB).o usb-hid.o usb-msd.o
 OBJS+=usb-serial.o usb-net.o
 OBJS+=sd.o ssi-sd.o
 OBJS+=bt.o bt-host.o bt-vhci.o bt-l2cap.o bt-sdp.o bt-hci.o bt-hid.o usb-bt.o
hw/usb-hid.c +259 -63

485 lines not on this page · raw message

hw/usb-wacom.c deleted +0 -412

412 lines not on this page · raw message

Signature · 1 line
1.4.4.4
#2 lore raw

Re: *** GMX Spamverdacht *** [Qemu-devel] [PATCH] Merge usb-wacom.c into usb-hid.c

Quoted 10 lines

Hi,

Quoted 4 lines · François Revol

$subj;
Cleaned up a bit from last RFC, still works fine here with
http://dev.haiku-os.org/browser/haiku/trunk/3rdparty/mmu_man/onlinedemo/haiku.php

Quoted 1 line

What bug does this solve? And what is the advantage of making one file

Actually I forgot to tell it includes the fixes I submited many times about coord scaling on wacom.

Quoted 2 lines

very large, when before, we had two files with relatively separate code?

http://thread.gmane.org/gmane.comp.emulators.qemu/40232/focus=40233

François.

#3 lore raw

Re: *** GMX Spamverdacht *** [Qemu-devel] [PATCH] Merge usb-wacom.c into usb-hid.c

Hi,

Quoted 7 lines · François Revol
Quoted 5 lines · François Revol

What bug does this solve? And what is the advantage of making one file very large, when before, we had two files with relatively separate code?

http://thread.gmane.org/gmane.comp.emulators.qemu/40232/focus=40233

Reading something like this in a Git log, sitting 30k feet above ground, makes me want to do something very foolish.

Besides, the explanation given in that email is somewhat slim. Experience shows that the number of bugs lurking in some random file is the square of the number of lines in that file, so...

But my advice has been ignored on this list before, so I'll start wasting my time elsewhere.

Hth,
Dscho

#4 lore raw

Re: *** GMX Spamverdacht *** [Qemu-devel] [PATCH] Merge usb-wacom.c into usb-hid.c

Hi,

Quoted 10 lines
Quoted 6 lines
Quoted 4 lines

What bug does this solve? And what is the advantage of making one
file very large, when before, we had two files with relatively separate code?

http://thread.gmane.org/gmane.comp.emulators.qemu/40232/focus=40233

Reading something like this in a Git log, sitting 30k feet above ground,
makes me want to do something very foolish.

Sorry but I've argued it like 4 times already, I've been having this diff sitting here for months, I've done it because I was told that instead of fixing usb-wacom it should be merged, I've read so many git manpages I have a headache, I spent last night trying to dig the overly cryptic zlib code to see why it would crash the Haiku m68k floppy loader, the time I spend on qemu stuff isn't spent on the projects for which qemu is supposed to be a dev tool, I'm overdue for work, so I'm just getting tired of it.

cf. the many results on
http://search.gmane.org/?query=usb-wacom&group=gmane.comp.emulators.qemu

Quoted 5 lines

Besides, the explanation given in that email is somewhat slim. Experience
shows that the number of bugs lurking in some random file is the square of
the number of lines in that file, so...

Given that those lines are mostly the same that were removed from the other file, minus the many that were identical and so factored out, plus just a few that actually fix a scaling bug resp to the hardware, making less as total, and so squared a lesser number of bugs, and that I've explained it already too much I'd rather keep it slim instead of adding english bugs, besides I'm french.

Quoted 3 lines

But my advice has been ignored on this list before, so I'll start wasting
my time elsewhere.

And my patch has been ignored several times too, still I'm here.

François.

#5 lore raw

Re: *** GMX Spamverdacht *** [Qemu-devel] [PATCH] Merge usb-wacom.c into usb-hid.c

Hi,

Quoted 4 lines · François Revol
Quoted 4 lines
Quoted 1 line

http://thread.gmane.org/gmane.comp.emulators.qemu/40232/focus=40233

Reading something like this in a Git log, sitting 30k feet above ground, makes me want to do something very foolish.

To illustrate what commit messages in typical Git repositories look like:

http://repo.or.cz/w/git.git?a=commitdiff;h=8d2dfc49b199c7da6faefd7993630f24bd37fee0

(answering a link with a link is okay, I think.)

The point is that nobody needs to sift through long and dispersed discussions with a lot of points that are moot in the end. If more than one person reads the summary of the discussions in the commit message, the overall saved time (integrated over all involved people) is substantial.

Will shut up now,
Dscho

#6 lore raw

Re: *** GMX Spamverdacht *** [Qemu-devel] [PATCH] Merge usb-wacom.c into usb-hid.c

Quoted 11 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

http://thread.gmane.org/gmane.comp.emulators.qemu/40232/focus=40233

Quoted 1 line
Quoted 1 line
Quoted 1 line

Reading something like this in a Git log, sitting 30k feet above ground, makes me want to do something very foolish.

To illustrate what commit messages in typical Git repositories look like:

http://repo.or.cz/w/git.git?a=commitdiff;h=8d2dfc49b199c7da6faefd7993630f24bd37fee0

Quoted 1 line

(answering a link with a link is okay, I think.)

Typical commit line counts in QEMU tends to be quite lower :

# count lines
$ git log | awk '/^    ..*$/{cnt++;/*print*/};NR>1&&/^commit/{print
cnt; cnt="0"}' | sort -g | uniq -c | sort -g -k 1 -r
   4904 2
    798 3
    354 4
    255 5
    239 6
    172 7
    103 8
     85 9
     59 10
     36 12
     33 11
     28 13
     21 14
     15 18
     14 15
      9 16
      9 1
      6 21
      6 20
      5 17
      4 25
      4 23
      3 24
      2 37
      2 31
      2 26
      2 19
      1 68
      1 62
      1 59
      1 41
      1 38
      1 36
      1 35
      1 34
      1 33
      1 32

Which isn't a problem in itself...

Quoted 7 lines

The point is that nobody needs to sift through long and dispersed discussions with a lot of points that are moot in the end. If more than
one person reads the summary of the discussions in the commit message, the
overall saved time (integrated over all involved people) is substantial.

The problem is everytime I've spent time explaining the patch, like 2 ppl read it and gave thoughtfull comments. Which should be enough but I just got fed up spending hours ingurGITating man pages.

Besides, you still didn't even comment on the patch itself yet, which quites asserts this.

François.

#7 lore raw

Re: *** GMX Spamverdacht *** [Qemu-devel] [PATCH] Merge usb-wacom.c into usb-hid.c

"François Revol" <[email protected]> writes:

[...]

Quoted 1 line

just got fed up spending hours ingurGITating man pages.

[...]

For what it's worth, the day or two I spent last year to really learn Git was the one of the best investments I've made in a long time. And by "learn" I mean *understanding* the concepts, not just voodoo the command line. It changed the way I think about SCMs, and my workflow along with it. Major productivity boost.

As always, YMMV.

http://www.kernel.org/pub/software/scm/git/docs/user-manual.html

#8 lore raw

Re: *** GMX Spamverdacht *** [Qemu-devel] [PATCH] Merge usb-wacom.c into usb-hid.c

Quoted 6 lines

For what it's worth, the day or two I spent last year to really learn Git was the one of the best investments I've made in a long time. And
by "learn" I mean *understanding* the concepts, not just voodoo the command line. It changed the way I think about SCMs, and my workflow along with it. Major productivity boost.

Surely, I just need to plan this.
Please understand some people want to stay productive first.

Plus one problem with git is, as I said, it supposes UNIX-specific behaviour, which doesn't always fit on other platforms, so despite already having a preliminary Haiku port, seems to me it will want to use UNIX mail stuff which Haiku has no reason to have.
Of course git has been done for Linux by Linus, but hey, you're not alone in the universe, if it's supposed to be used by everyone it should fit everyone's platform, not impose its own.
Maybe I can just have the Haiku port set the mime type xattr to text/x- vnd.be-maildraft and add other required xattrs as well, still, a clean design would have the content & OS specific part separated.

Quoted 1 line

http://www.kernel.org/pub/software/scm/git/docs/user-manual.html

This url ought to have been put in the very first mail indicating the switch to git...
Yeah I know we all know about google, still.

Back to work now...

François.

#9 lore raw

Am 29.04.2009 um 12:23 schrieb François Revol:

Quoted 4 lines

one problem with git is, as I said, it supposes UNIX-specific behaviour, which doesn't always fit on other platforms, so despite already having a preliminary Haiku port, seems to me it will want to use UNIX mail stuff which Haiku has no reason to have.

I admit I didn't test that when I ported Git to Haiku, since I don't like the concept either. It was not a preliminary port, it "should" work out of the box now, with appropriate make parameters (cf. HaikuPorts). Git it said to work on Windows btw, which is not UNIX. ;)

In case for whatever reason git format-patch misbehaves, you can still use plain git diff.

Andreas

Quoted 6 lines

Of course git has been done for Linux by Linus, but hey, you're not alone in the universe, if it's supposed to be used by everyone it should fit everyone's platform, not impose its own.
Maybe I can just have the Haiku port set the mime type xattr to text/x- vnd.be-maildraft and add other required xattrs as well, still, a clean design would have the content & OS specific part separated.