ceph: remove redundant test of head->safe and silence static analysis warnings
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 ceph: remove redundant test of head->safe and silence static analysis warnings
ceph: remove redundant test of head->safe and silence static analysis warnings
Signed-off-by Brad Hubbard <[email protected]>
--- fs/ceph/mds_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ceph/mds_client.c +1 -1
@@ -2411,7 +2411,7 @@ static void handle_reply(struct ceph_mds_session *session, struct ceph_msg *msg)mutex_unlock (&mdsc->mutex); goto out; } -if (req->r_got_safe && !head->safe) { +if (req->r_got_safe) {pr_warn ("got unsafe after safe on %llu from mds%d\n" , tid, mds);mutex_unlock (&mdsc->mutex);
Quoted 16 lines · Brad Hubbard
ceph: remove redundant test of
head->safeand silence static analysis warningsSigned-off-by Brad Hubbard <[email protected]>---
fs/ceph/mds_client.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)fs/ceph/mds_client.c +0
-0
fs/ceph/mds_client.c static void handle_reply(struct ceph_mds_session *session, struct ceph_msg *msg) · line 2417
Quoted 8 lines
fs/ceph/mds_client.c +1
-1@@ -2411,7 +2411,7 @@ static void handle_reply(struct ceph_mds_session *session, struct ceph_msg *msg)mutex_unlock (&mdsc->mutex); goto out; } -if (req->r_got_safe && !head->safe) { +if (req->r_got_safe) {pr_warn ("got unsafe after safe on %llu from mds%d\n" , tid, mds);mutex_unlock (&mdsc->mutex);
added to our testing branch,
Thanks
Yan, Zheng