Skip to contentSkip to conversation

selinux: rate-limit unrecognized netlink message warnings in selinux_nlmsg_perm()

PATCH Superseded Vladis Dronov 1 participant 1 message Nov 4, 2015 1 message not in the archive SELinux security module

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 selinux: rate-limit unrecognized netlink message warnings in selinux_nlmsg_perm()

Any process is able to send netlink messages with invalid types. Make the warning rate-limited to prevent too much log spam.

The warning is supposed to hel

---
 security/selinux/hooks.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
security/selinux/hooks.c +3 -4
index e4369d8..bf5010b 100644
@@ -4787,10 +4787,9 @@ static int selinux_nlmsg_perm(struct sock *sk, struct sk_buff *skb)
 	err = selinux_nlmsg_lookup(sksec->sclass, nlh->nlmsg_type, &perm);
 	if (err) {
 		if (err == -EINVAL) {
-			printk(KERN_WARNING
-			       "SELinux: unrecognized netlink message:"
-			       " protocol=%hu nlmsg_type=%hu sclass=%s\n",
-			       sk->sk_protocol, nlh->nlmsg_type,
+			pr_warn_ratelimited("SELinux: unrecognized netlink"
+			       " message: protocol=%hu nlmsg_type=%hu"
+			       " sclass=%s\n", sk->sk_protocol, nlh->nlmsg_type,
 			       secclass_map[sksec->sclass - 1].name);
 			if (!selinux_enforcing || security_get_allow_unknown())
 				err = 0;

--