Skip to contentSkip to conversation

fs: gfs2: Adding new return type vm_fault_t

PATCH In review Souptick Joarder 3 participants 4 messages Apr 14, 2018 – Apr 17, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: gfs2: Adding new return type vm_fault_t

Use new return type vm_fault_t for page_mkwrite
handler.

---
 fs/gfs2/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/gfs2/file.c +1 -1
index 4f88e20..2c471d6 100644
@@ -387,7 +387,7 @@ static int gfs2_allocate_page_backing(struct page *page)
  * blocks allocated on disk to back that page.
  */
 
-static int gfs2_page_mkwrite(struct vm_fault *vmf)
+static vm_fault_t gfs2_page_mkwrite(struct vm_fault *vmf)
 {
 	struct page *page = vmf->page;
 	struct inode *inode = file_inode(vmf->vma->vm_file);
Signature · 1 line
1.9.1
#1 lore raw

----- Original Message -----

Quoted 23 lines

Use new return type vm_fault_t for page_mkwrite
handler.

---
 fs/gfs2/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/gfs2/file.c +1 -2
index 4f88e20..2c471d6 100644
@@ -387,7 +387,7 @@ static int gfs2_allocate_page_backing(struct page *page)
  * blocks allocated on disk to back that page.
  */
 
-static int gfs2_page_mkwrite(struct vm_fault *vmf)
+static vm_fault_t gfs2_page_mkwrite(struct vm_fault *vmf)
 {
 	struct page *page = vmf->page;
 	struct inode *inode = file_inode(vmf->vma->vm_file);
--
Quoted 1 line

1.9.1

Hi,

This patch is straightforward enough, but there are a lot of other file systems that need similar patches. Shouldn't you do one big patch set that fixes several file systems at once and run it through Viro's kernel or Linus's kernel or something?
Adding Viro and linux-fsdevel for more opinions.

Regards,

Bob Peterson

#2 lore raw
Quoted 7 lines

Hi,

This patch is straightforward enough, but there are a lot of other file systems that need similar patches. Shouldn't you do one big patch set that fixes several file systems at once and run it through Viro's kernel or Linus's kernel or something?
Adding Viro and linux-fsdevel for more opinions.

The plan for these patches is to introduce the typedef, initially just as documentation ("These functions should return a VM_FAULT_ status"). We'll trickle the patches to individual drivers/filesystems in through the maintainers, as far as possible. Then we'll change the typedef to an unsigned int and break the compilation of any unconverted drivers/filesystems.

We have already started sending out drivers/filesystems changes to different maintainers.

Reference commit id - 1c8f422059ae5da07db7406ab916203f9417e396

#3 lore raw
Quoted 15 lines · Souptick Joarder
Quoted 7 lines

Hi,

This patch is straightforward enough, but there are a lot of other file systems that need similar patches. Shouldn't you do one big patch set that fixes several file systems at once and run it through Viro's kernel or Linus's kernel or something?
Adding Viro and linux-fsdevel for more opinions.

The plan for these patches is to introduce the typedef, initially just as documentation ("These functions should return a VM_FAULT_ status"). We'll trickle the patches to individual drivers/filesystems in through the maintainers, as far as possible. Then we'll change the typedef to an unsigned int and break the compilation of any unconverted drivers/filesystems.

Quoted 2 lines

We have already started sending out drivers/filesystems changes to different maintainers.

Yes, we can see that. The response you are getting is "this is not how we do cross-subsystem API changes. Why are you doing it this way?"

i.e. the problem being pointed out is that your process has not followed the correct/normal process for proposing, reviewing and mering cross-subsystem API changes. Bob has raised the same questions as both Christoph and Darrick have asked in response to the XFS patch. I only implied these questions by asking about introducing useless typedefs with no context for reviewers...

I'd really like to have Darrick's questions answered(*) in a constructive, non-abusive manner - I'll quote it here to get it all in one thread on -fsdevel:

| ...hm, the original mm patch wasn't cc'd to fsdevel either, so that's
| probably why I never heard of any of this until now.
|
| So, uh, why wasn't this whole series (all the mm changes and all the
| required fs changes) sent out for review prior to the merge window?

We're not asking for a description of what you are doing - we are asking why the normal processes for proposing and merging such a change is not being followed, and how you plan to rectify that.

Cheers,

Dave.

https://marc.info/?l=linux-xfs&m=152389824107375&w=2

Signature · 2 lines
Dave Chinner
david at fromorbit.com