Erase error does not mark smth in BBT
Hello, all.
I am studying the code in nand_base.c
I thought that when erase command ends with an error, the corresponding block will be marked as bad or in OOB or in BBT or in both. I think I walked through the code carefully, but did not find this BBT/OOB treatment.
Please, help me - where is my error?
BR
Signature · 1 line
Leon
Quoted 9 lines · Leon Pollak
Hello, all.
I am studying the code in
nand_base.c
I thought that when erase command ends with an error, the corresponding block will be marked as bad or in OOB or in BBT or in both. I think I walked through the code carefully, but did not find this BBT/OOB treatment.Please, help me - where is my error?
You're looking at the wrong layer. :-)
Look at the users of mtd_block_markbad().
Signature · 2 lines
Thanks, //richard
Quoted 9 lines · On Sunday 08 December 2013 15:43:33 Richard Weinberger wrote:
Quoted 8 lines · Leon Pollak
Hello, all.
I am studying the code innand_base.c
I thought that when erase command ends with an error, the corresponding block will be marked as bad or in OOB or in BBT or in both.
I think I walked through the code carefully, but did not find this BBT/OOB treatment.
Quoted 4 lines
Quoted 1 line
Please, help me - where is my error?
You're looking at the wrong layer. :-)
Look at the users ofmtd_block_markbad().
Thank you very much, Richard.
Yes, I understood my problem - I expected to see the BBT update on erasure failure in the kernel driver.
But, as I understood after your hint and code study, the BBT update is totally on the "user's" responsibility.
---
So, I went to the mtd-utils package.
And there I have the similar problem - when looking into the flash_erase.c file I see the following:
if (mtd_erase(mtd_desc, &mtd, fd, eb) != 0) {
sys_errmsg("%s: MTD Erase failure", mtd_device); continue;
}
and I was not able to find any usage of mtd_mark_bad.
Contrary, analyzing the nandwrite.c file, I found that the logic is as following (lines 537-555):
1. Try to write block data.
2. If failed, try to erase this block.
3. If erased failed (EIO) mark the block as bad and restart from (1).
---
So, here the question comes:
If the block erasure already failed once (in flash_erase.c) - doesn't this require the BBT update at this point?
Why do one need to retry to erase/program it?
AFAIK, most of NAND vendors state that the block once not erased is bad and even if you succeeded to erase it afterwords, it is dangerous to continue to use it.
Thank you very much for your help.
Signature · 1 line
Leon
Quoted 14 lines · Leon Pollak
Quoted 8 lines · On Sunday 08 December 2013 15:43:33 Richard Weinberger wrote:
Quoted 7 lines · Leon Pollak
I am studying the code in
nand_base.c
I thought that when erase command ends with an error, the corresponding block will be marked as bad or in OOB or in BBT or in both.
I think I walked through the code carefully, but did not find this BBT/OOB treatment.Quoted 4 lines
Quoted 1 line
Please, help me - where is my error?
You're looking at the wrong layer. :-)
Look at the users ofmtd_block_markbad().
Quoted 7 lines
Yes, I understood my problem - I expected to see the BBT update on erasure failure in the kernel driver.
But, as I understood after your hint and code study, the BBT update is totally on the "user's" responsibility.---
So, I went to the mtd-utils package.
The mtd_block_markbad() API is actually still a kernel-internal API, so Richard was probably pointing you to the few in-kernel users, like UBI (drivers/mtd/ubi/io.c) and other filesystems (e.g., JFFS2) or translation layers (NFTL?).
The mtd-utils package may be a worse example, and they aren't actually used for "regular wear" -- they are mostly for initial flashing and for debugging. As you notice, flash_erase.c has some flaws (no bad block marking). But the kernel UBI layer, the JFFS2 filesystem, the nandwrite utility, and the user-space UBI utilities should be good examples.
Quoted 8 lines
And there I have the similar problem - when looking into the
flash_erase.cfile I see the following:if (mtd_erase(mtd_desc, &mtd, fd, eb) != 0) { sys_errmsg("%s: MTD Erase failure", mtd_device); continue; }and I was not able to find any usage of
mtd_mark_bad.
Correct, flash_erase.c does not automatically mark blocks bad. Perhaps that would be a good flag to add, similar to nandwrite --markbad.
Quoted 5 lines
Contrary, analyzing the
nandwrite.cfile, I found that the logic is as following (lines 537-555):
1. Try to write block data.
2. If failed, try to erase this block.
3. If erased failed (EIO) mark the block as bad and restart from (1).
Your step 3 is wrong. If you're using the --markbad option, then this step is just:
3. If step (1) failed, mark the block as bad and continue from (1).
(Notice how we only error out if the erase in (2) fails for something *besides* EIO.)
Quoted 5 lines
---
So, here the question comes:
If the block erasure already failed once (inflash_erase.c) - doesn't this require the BBT update at this point?
Yes, flash_erase.c probably should have the option to automatically mark failed blocks as bad.
Quoted 1 line
Why do one need to retry to erase/program it?
nandwrite.c is a separate utility from flash_erase.c. nandwrite.c only tries to erase a partially-failed write. But then it will still unconditionally mark the block as bad. It is not retrying the erase/program.
Quoted 3 lines
AFAIK, most of NAND vendors state that the block once not erased is bad and even if you succeeded to erase it afterwords, it is dangerous to continue to use it.
Yes, very true. AFAICT, flash_erase.c is the only tool that is missing this aspect, as it does not have a --markbad option.
Brian
Quoted 20 lines · Brian Norris
Quoted 19 lines · Leon Pollak
Quoted 8 lines · On Sunday 08 December 2013 15:43:33 Richard Weinberger wrote:
Quoted 7 lines · Leon Pollak
I am studying the code in
nand_base.c
I thought that when erase command ends with an error, the corresponding block will be marked as bad or in OOB or in BBT or in both.
I think I walked through the code carefully, but did not find this BBT/OOB treatment.Quoted 4 lines
Quoted 1 line
Please, help me - where is my error?
You're looking at the wrong layer. :-)
Look at the users ofmtd_block_markbad().Yes, I understood my problem - I expected to see the BBT update on erasure failure in the kernel driver.
But, as I understood after your hint and code study, the BBT update is totally on the "user's" responsibility.
Quoted 7 lines
Quoted 2 lines
---
So, I went to the mtd-utils package.The
mtd_block_markbad()API is actually still a kernel-internal API, so Richard was probably pointing you to the few in-kernel users, like UBI (drivers/mtd/ubi/io.c) and other filesystems (e.g., JFFS2) or translation layers (NFTL?).
Correct. :)
Signature · 2 lines
Thanks, //richard