Skip to contentSkip to conversation

Error in compiling -unstable

PATCH New Jun Koi 2 participants 6 messages Feb 26, 2009 – Mar 16, 2009

lore
Share & tools
lore

Jun Koi

author
#0 lore raw

Hi,

I got some errors when compiling -unstable. Anybody sees the same thing?

It complains about not finding libvdeplug.h, but I can confirm that I have /usr/include/libvdeplug.h. It is so weird!
I am using Ubuntu Hardy, gcc 4.2.4

# hg tip
changeset:   19238:f8187a343ad2
tag:         tip
user:        Keir Fraser <[email protected]>
date:        Fri Feb 20 17:02:36 2009 +0000
summary:     xenconsole: Fix pty handling

.......
gcc -I. -I.. -I/home/xen/xen-unstable.hg/stubdom/ioemu/target-i386 -I/home/xen/xen-unstable.hg/stubdom/ioemu -MMD -MT vl.o -MP -DNEED_CPU_H -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -I/home/xen/xen-unstable.hg/stubdom/ioemu/tcg -I/home/xen/xen-unstable.hg/stubdom/ioemu/tcg/i386 -I/home/xen/xen-unstable.hg/stubdom/ioemu/fpu -I/home/xen/xen-unstable.hg//tools/libxc -I/home/xen/xen-unstable.hg//tools/xenstore -I/home/xen-unstable.hg//tools/include -isystem /home/xen/xen-unstable.hg/stubdom/../extras/mini-os/include -D__MINIOS__ -DHAVE_LIBC -isystem /home/xen/xen-unstable.hg/stubdom/../extras/mini-os/include/posix -isystem /home/xen/xen-unstable.hg/stubdom/../tools/xenstore -isystem /home/xen/xen-unstable.hg/stubdom/../extras/mini-os/include/x86 -isystem /home/xen/xen-unstable.hg/stubdom/../extras/mini-os/include/x86/x86_32 -U __linux__ -U __FreeBSD__ -U __sun__ -nostdinc -isystem /home/xen/xen-unstable.hg/stubdom/../extras/mini-os/include/posix -isystem /home/xen/xen-unstable.hg/stubdom/cross-root-i686/i686-xen-elf/include -isystem /usr/lib/gcc/i486-linux-gnu/4.2.4/include -isystem /home/xen/xen-unstable.hg/stubdom/lwip-x86_32/src/include -isystem /home/xen/xen-unstable.hg/stubdom/lwip-x86_32/src/include/ipv4 -I/home/xen/xen-unstable.hg/stubdom/include -DNEED_CPU_H -I../i386-dm -I../hw -I../fpu -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m32 -march=i686 -m32 -march=i686 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wno-unused-value -Wdeclaration-after-statement -fno-stack-protector
-O2 -g -fno-strict-aliasing -Wall -Wundef -Wendif-labels
-Wwrite-strings -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m32 -march=i686 -m32 -march=i686 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .vl.o.d -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -mno-tls-direct-seg-refs -Wno-unused -Wno-declaration-after-statement -Wno-pointer-sign -DCONFIG_PASSTHROUGH -I../hw -m32 -march=i686 -DUSE_SSE2=1 -msse2 -Wno-unused -Wno-declaration-after-statement -Wno-pointer-sign -DCONFIG_PASSTHROUGH -c -o vl.o /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:125:24: warning:
libvdeplug.h: No such file or directory /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c: In function ‘udp_chr_write’:
/home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:3379: warning: passing argument 2 of ‘sendto’ discards qualifiers from pointer target type /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c: At top level:
/home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4796: error: expected specifier-qualifier-list before ‘VDECONN’ /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c: In function ‘vde_to_qemu’:
/home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4805: warning: implicit declaration of function ‘vde_recv’ /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4805: error: ‘VDEState’ has no member named ‘vde’ /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c: In function ‘vde_from_qemu’:
/home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4816: warning: implicit declaration of function ‘vde_send’ /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4816: error: ‘VDEState’ has no member named ‘vde’ /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c: In function ‘net_vde_init’:
/home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4831: error: variable ‘args’ has initializer but incomplete type /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4832: error: unknown field ‘port’ specified in initializer /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4832: warning: excess elements in struct initializer /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4832: warning: (near initialization for ‘args’) /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4833: error: unknown field ‘group’ specified in initializer /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4833: warning: excess elements in struct initializer /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4833: warning: (near initialization for ‘args’) /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4834: error: unknown field ‘mode’ specified in initializer /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4834: warning: excess elements in struct initializer /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4834: warning: (near initialization for ‘args’) /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4831: error: storage size of ‘args’ isn’t known /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4840: error: ‘VDEState’ has no member named ‘vde’ /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4840: warning: implicit declaration of function ‘vde_open’ /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4841: error: ‘VDEState’ has no member named ‘vde’ /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4846: warning: implicit declaration of function ‘vde_datafd’ /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4846: error: ‘VDEState’ has no member named ‘vde’ /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4848: error: ‘VDEState’ has no member named ‘vde’ /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c: In function ‘net_socket_receive_dgram’:
/home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:4884: warning: passing argument 2 of ‘sendto’ discards qualifiers from pointer target type /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c: In function ‘main’:
/home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:10204: warning: implicit declaration of function ‘vde_close’ /home/xen/xen-unstable.hg/stubdom/ioemu/vl.c:10204: error: ‘VDEState’ has no member named ‘vde’
make[3]: *** [vl.o] Error 1
make[3]: Leaving directory `/home/xen/xen-unstable.hg/stubdom/ioemu/i386-stubdom'
make[2]: *** [subdir-i386-stubdom] Error 2
make[2]: Leaving directory `/home/xen/xen-unstable.hg/stubdom/ioemu' make[1]: *** [ioemu] Error 2
make[1]: Leaving directory `/home/xen/xen-unstable.hg/stubdom'
make: *** [install-stubdom] Error 2

#1 lore raw

Jun Koi writes ("[Xen-devel] Error in compiling -unstable"):

Quoted 4 lines

I got some errors when compiling -unstable. Anybody sees the same thing?

It complains about not finding libvdeplug.h, but I can confirm that I have /usr/include/libvdeplug.h. It is so weird!

The problem seems to be that the way that qemu is configured for stubdom compilation doesn't take account of the fact that stubdom doesn't use any of the build host libraries or headers.

So the configure script detects libvdeplug.h and sets CONFIG_VDE even though actually that's not available in minios. (The stubdom makefiles pass -nostdinc, correctly.) I think it's a mistake that the stubdom qemu runs configure in that way, but the whole stubdom build system is rather odd and I don't want to try to disentangle it piecemeal.

Passing --disable-vde should fix the problem, and can be done from the existing Makefile setup. So can you try this patch to xen-unstable.hg ? I think this should solve the problem for you (although you may need to start again with a fresh tree to get it to take effect).

Thanks,
Ian.

stubdom/Makefile +1 -1
diff -r 7fe15a0ee3d8 stubdom/Makefile
@@ -7,7 +7,7 @@ export debug=y
 export debug=y
 include $(XEN_ROOT)/Config.mk
 
-IOEMU_OPTIONS=--disable-sdl --disable-opengl --disable-vnc-tls --disable-brlapi --disable-kqemu
+IOEMU_OPTIONS=--disable-sdl --disable-opengl --disable-vnc-tls --disable-brlapi --disable-kqemu --disable-vde
 
 #ZLIB_URL?=http://www.zlib.net
 ZLIB_URL=$(XEN_EXTFILES_URL)
author
#2 lore raw
Quoted 36 lines · Ian Jackson

Jun Koi writes ("[Xen-devel] Error in compiling -unstable"):

Quoted 4 lines

I got some errors when compiling -unstable. Anybody sees the same thing?

It complains about not finding libvdeplug.h, but I can confirm that I have /usr/include/libvdeplug.h. It is so weird!

The problem seems to be that the way that qemu is configured for stubdom compilation doesn't take account of the fact that stubdom doesn't use any of the build host libraries or headers.

So the configure script detects libvdeplug.h and sets CONFIG_VDE even though actually that's not available in minios.  (The stubdom makefiles pass -nostdinc, correctly.)  I think it's a mistake that the stubdom qemu runs configure in that way, but the whole stubdom build system is rather odd and I don't want to try to disentangle it piecemeal.

Passing --disable-vde should fix the problem, and can be done from the existing Makefile setup.  So can you try this patch to xen-unstable.hg ?  I think this should solve the problem for you (although you may need to start again with a fresh tree to get it to take effect).

Thanks,
Ian.

diff -r 7fe15a0ee3d8 stubdom/Makefile

stubdom/Makefile  Thu Feb 26 18:48:54 2009 +0000 renamed from stubdom/Makefile  Tue Feb 17 11:20:18 2009 +0000 +0 -0
@@ -7,7 +7,7 @@ export debug=y

 export debug=y
 include $(XEN_ROOT)/Config.mk

stubdom/Makefile  Thu Feb 26 18:48:54 2009 +0000 renamed from stubdom/Makefile  Tue Feb 17 11:20:18 2009 +0000 +1 -1
-IOEMU_OPTIONS=--disable-sdl --disable-opengl --disable-vnc-tls --disable-brlapi --disable-kqemu
+IOEMU_OPTIONS=--disable-sdl --disable-opengl --disable-vnc-tls --disable-brlapi --disable-kqemu --disable-vde
Quoted 3 lines

 #ZLIB_URL?=http://www.zlib.net
 ZLIB_URL=$(XEN_EXTFILES_URL)

This patch doesnt solve the problem: I still got the same error.

Thanks,
Jun

#3 lore raw

Jun Koi writes ("Re: [Xen-devel] Error in compiling -unstable"):

Quoted 4 lines · Ian Jackson
Quoted 1 line

+IOEMU_OPTIONS=--disable-sdl --disable-opengl --disable-vnc-tls --disable-brlapi --disable-kqemu --disable-vde

This patch doesnt solve the problem: I still got the same error.

Hrm.

Did you try it from a completely freshly cloned tree ? The stubdom build system is very dirty and its clean targets aren't reliable, so I wouldn't be at all surprised if the broken configuration from your earlier attempt was contaminating things.

Can you send me (privately, not to the list) the whole log output from such a build from a completely fresh tree ?

Thanks,
Ian.

author
#4 lore raw
Quoted 4 lines · Ian Jackson

Jun Koi writes ("Re: [Xen-devel] Error in compiling -unstable"):

Quoted 3 lines · Ian Jackson
Quoted 1 line

+IOEMU_OPTIONS=--disable-sdl --disable-opengl --disable-vnc-tls --disable-brlapi --disable-kqemu --disable-vde

Quoted 8 lines
Quoted 1 line

This patch doesnt solve the problem: I still got the same error.

Hrm.

Did you try it from a completely freshly cloned tree ?  The stubdom build system is very dirty and its clean targets aren't reliable, so I wouldn't be at all surprised if the broken configuration from your earlier attempt was contaminating things.

You are right! I recompiled from fresh, and the problem is gone. So your patch really helps.

Thanks,
Jun

#5 lore raw

PATCH 1/1 Make stubdom compile on systems with libvde installed

In reply to Ian Jackson

We need to disable libvde in the stubdom qemu-xen configuration. Thanks to Jun Koi for the report and testing.

stubdom/Makefile +1 -1
diff -r 7fe15a0ee3d8 stubdom/Makefile
@@ -7,7 +7,7 @@ export debug=y
 export debug=y
 include $(XEN_ROOT)/Config.mk
 
-IOEMU_OPTIONS=--disable-sdl --disable-opengl --disable-vnc-tls --disable-brlapi --disable-kqemu
+IOEMU_OPTIONS=--disable-sdl --disable-opengl --disable-vnc-tls --disable-brlapi --disable-kqemu --disable-vde
 
 #ZLIB_URL?=http://www.zlib.net
 ZLIB_URL=$(XEN_EXTFILES_URL)

Ian.