Skip to contentSkip to conversation

exfat: redefine DIR_DELETED as the bad cluster number

PATCH Applied Sungjong Seo 2 participants 2 messages Dec 30, 2022 – Jan 8, 2023 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CGME20221229115257epcas1p27195844dc54cf09608dad9967808530a@epcas1p2.samsung.com

Sungjong Seo

author maintainer
#1 lore raw

PATCH 1/1 exfat: redefine DIR_DELETED as the bad cluster number

When a file or a directory is deleted, the hint for the cluster of its parent directory in its in-memory inode is set as DIR_DELETED. Therefore, DIR_DELETED must be one of invalid cluster numbers. According to the exFAT specification, a volume can have at most 2^32-11 clusters. However, DIR_DELETED is wrongly defined as 0xFFFF0321, which could be a valid cluster number. To fix it, let's redefine DIR_DELETED as 0xFFFFFFF7, the bad cluster number.

Fixes 1acf1a564b60 ("exfat: add in-memory and on-disk structures and headers")
---
 fs/exfat/exfat_fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/exfat/exfat_fs.h +1 -1
index bc6d21d7c5ad..25a5df0fdfe0 100644
@@ -50,7 +50,7 @@ enum {
 #define ES_IDX_LAST_FILENAME(name_len)	\
 	(ES_IDX_FIRST_FILENAME + EXFAT_FILENAME_ENTRY_NUM(name_len) - 1)
 
-#define DIR_DELETED		0xFFFF0321
+#define DIR_DELETED		0xFFFFFFF7
 
 /* type values */
 #define TYPE_UNUSED		0x0000
Signature · 1 line
2.25.1
maintainer Applied
#2 lore raw

2022-12-29 20:52 GMT+09:00, Sungjong Seo <[email protected]>:

Quoted 8 lines

When a file or a directory is deleted, the hint for the cluster of its parent directory in its in-memory inode is set as DIR_DELETED. Therefore, DIR_DELETED must be one of invalid cluster numbers. According to the exFAT specification, a volume can have at most 2^32-11 clusters. However, DIR_DELETED is wrongly defined as 0xFFFF0321, which could be a valid cluster number. To fix it, let's redefine DIR_DELETED as 0xFFFFFFF7, the bad cluster number.

Quoted 5 lines
Fixes 1acf1a564b60 ("exfat: add in-memory and on-disk structures and

headers")

Applied, Thanks!