arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR
Subsystems (2)
PATCH 1/2 arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR
enable "pwm-leds-multicolor" driver.
--- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
@@ -1171,6 +1171,7 @@ CONFIG_LEDS_PCA9532=m CONFIG_LEDS_GPIO=y CONFIG_LEDS_PWM=y CONFIG_LEDS_SYSCON=y +CONFIG_LEDS_PWM_MULTICOLOR=m CONFIG_LEDS_QCOM_LPG=m CONFIG_LEDS_TRIGGER_TIMER=y CONFIG_LEDS_TRIGGER_DISK=y
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH 2/2 arm64: dts: rockchip: make "multi-led" controllable under sysfs for Radxa E25
Radxa E25 carrier board has 16x RGB PWM LEDs. This patch make it controllable under sysfs.
$ ls /sys/class/leds/rgb\:status brightness max_brightness multi_intensity subsystem uevent device multi_index power trigger
--- arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts +1 -0
@@ -16,6 +16,7 @@ pwm-leds { multi-led { color = <LED_COLOR_ID_RGB>; + function = LED_FUNCTION_STATUS; max-brightness = <255>; led-red {
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 2/2] arm64: dts: rockchip: make "multi-led" controllable under sysfs for Radxa E25
Hi,
sorry, commit message was not correct. I'll fix it in v2.
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 17 lines · FUKAUMI Naoki
Radxa E25 carrier board has 16x RGB PWM LEDs. This patch make it controllable under sysfs.
$ ls /sys/class/leds/rgb\:status brightness max_brightness multi_intensity subsystem uevent device multi_index power triggerSigned-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts +0
-0
arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts pwm-leds { · line 22
Quoted 7 lines
arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts +1
-0@@ -16,6 +16,7 @@ pwm-leds { multi-led { color = <LED_COLOR_ID_RGB>; + function = LED_FUNCTION_STATUS; max-brightness = <255>; led-red {
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Quoted 1 line · FUKAUMI Naoki
enable "pwm-leds-multicolor" driver.
Why?
Best regards,
Krzysztof
Hi,
thank you very much for your review.
but, I decided not to use "pwm-leds-multicolor" for Radxa E25. please ignore this patch series.
really sorry.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 9 lines · Krzysztof Kozlowski
Quoted 1 line · FUKAUMI Naoki
enable "pwm-leds-multicolor" driver.
Why?
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Heiko Stübner
maintainerHi,
Am Freitag, 16. August 2024, 13:06:37 CEST schrieb FUKAUMI Naoki:
Quoted 4 lines
thank you very much for your review.
but, I decided not to use "pwm-leds-multicolor" for Radxa E25. please ignore this patch series.
What Krzysztof meant was probably more in line of that a commit message should not explain what the commit does, because that can be seen in the code.
Instead the commit message should explain why that change is needed.
Quoted 20 lines
really sorry.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.Quoted 9 lines · Krzysztof Kozlowski
Quoted 1 line · FUKAUMI Naoki
enable "pwm-leds-multicolor" driver.
Why?
Best regards,
Krzysztof
Hi,
Quoted 5 lines · Heiko Stübner
Hi,
Am Freitag, 16. August 2024, 13:06:37 CEST schrieb FUKAUMI Naoki:
Quoted 2 lines
thank you very much for your review.
Quoted 8 lines
Quoted 2 lines
but, I decided not to use "pwm-leds-multicolor" for Radxa E25. please ignore this patch series.
What Krzysztof meant was probably more in line of that a commit message should not explain what the commit does, because that can be seen in the code.
Instead the commit message should explain why that change is needed.
I see, but there is no reason to use "pwm-leds-multicolor" anymore, please ignore this patch series.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 12 lines
Quoted 12 lines
really sorry.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.Quoted 3 lines · Krzysztof Kozlowski
Quoted 1 line · FUKAUMI Naoki
enable "pwm-leds-multicolor" driver.
Quoted 13 lines
Quoted 8 lines
Quoted 6 lines
Why?
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip