Skip to contentSkip to conversation

drm/amd/amdgpu: Add ENGINE_CNTL register to vcn10 headers

PATCH In review StDenis, Tom 4 participants 4 messages Mar 4, 2019 – Mar 5, 2019 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/amdgpu: Add ENGINE_CNTL register to vcn10 headers

---
 drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h  | 2 ++
 drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h | 5 +++++
 2 files changed, 7 insertions(+)
drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h +2 -0
index 442ca7c471a5..6109f5ad25ad 100644
@@ -141,6 +141,8 @@
 #define mmUVD_GPCOM_VCPU_DATA0_BASE_IDX                                                                1
 #define mmUVD_GPCOM_VCPU_DATA1                                                                         0x03c5
 #define mmUVD_GPCOM_VCPU_DATA1_BASE_IDX                                                                1
+#define mmUVD_ENGINE_CNTL                                                                              0x03c6
+#define mmUVD_ENGINE_CNTL_BASE_IDX                                                                     1
 #define mmUVD_UDEC_DBW_UV_ADDR_CONFIG                                                                  0x03d2
 #define mmUVD_UDEC_DBW_UV_ADDR_CONFIG_BASE_IDX                                                         1
 #define mmUVD_UDEC_ADDR_CONFIG                                                                         0x03d3
drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h +5 -0
index 63457f9df4c5..f84bed6eecb9 100644
@@ -312,6 +312,11 @@
 //UVD_GPCOM_VCPU_DATA1
 #define UVD_GPCOM_VCPU_DATA1__DATA1__SHIFT                                                                    0x0
 #define UVD_GPCOM_VCPU_DATA1__DATA1_MASK                                                                      0xFFFFFFFFL
+//UVD_ENGINE_CNTL
+#define UVD_ENGINE_CNTL__ENGINE_START_MASK 0x1
+#define UVD_ENGINE_CNTL__ENGINE_START__SHIFT 0x0
+#define UVD_ENGINE_CNTL__ENGINE_START_MODE_MASK 0x2
+#define UVD_ENGINE_CNTL__ENGINE_START_MODE__SHIFT 0x1
 //UVD_UDEC_DBW_UV_ADDR_CONFIG
 #define UVD_UDEC_DBW_UV_ADDR_CONFIG__NUM_PIPES__SHIFT                                                         0x0
 #define UVD_UDEC_DBW_UV_ADDR_CONFIG__PIPE_INTERLEAVE_SIZE__SHIFT                                              0x3
Signature · 6 lines
2.17.2

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Am 04.03.19 um 16:59 schrieb StDenis, Tom:

Quoted 1 line
Quoted 24 lines
---
  drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h  | 2 ++
  drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h | 5 +++++
  2 files changed, 7 insertions(+)
drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h +2 -0
index 442ca7c471a5..6109f5ad25ad 100644
@@ -141,6 +141,8 @@
  #define mmUVD_GPCOM_VCPU_DATA0_BASE_IDX                                                                1
  #define mmUVD_GPCOM_VCPU_DATA1                                                                         0x03c5
  #define mmUVD_GPCOM_VCPU_DATA1_BASE_IDX                                                                1
+#define mmUVD_ENGINE_CNTL                                                                              0x03c6
+#define mmUVD_ENGINE_CNTL_BASE_IDX                                                                     1
  #define mmUVD_UDEC_DBW_UV_ADDR_CONFIG                                                                  0x03d2
  #define mmUVD_UDEC_DBW_UV_ADDR_CONFIG_BASE_IDX                                                         1
  #define mmUVD_UDEC_ADDR_CONFIG                                                                         0x03d3
drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h +0 -0
index 63457f9df4c5..f84bed6eecb9 100644
@@ -312,6 +312,11 @@
  //UVD_GPCOM_VCPU_DATA1

drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h line 322

Quoted 10 lines
drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h +5 -0
  #define UVD_GPCOM_VCPU_DATA1__DATA1__SHIFT                                                                    0x0
  #define UVD_GPCOM_VCPU_DATA1__DATA1_MASK                                                                      0xFFFFFFFFL
+//UVD_ENGINE_CNTL
+#define UVD_ENGINE_CNTL__ENGINE_START_MASK 0x1
+#define UVD_ENGINE_CNTL__ENGINE_START__SHIFT 0x0
+#define UVD_ENGINE_CNTL__ENGINE_START_MODE_MASK 0x2
+#define UVD_ENGINE_CNTL__ENGINE_START_MODE__SHIFT 0x1
  //UVD_UDEC_DBW_UV_ADDR_CONFIG
  #define UVD_UDEC_DBW_UV_ADDR_CONFIG__NUM_PIPES__SHIFT                                                         0x0
  #define UVD_UDEC_DBW_UV_ADDR_CONFIG__PIPE_INTERLEAVE_SIZE__SHIFT                                              0x3

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#3 lore raw
In reply to a message not in the archive

Hi,

Alex can I get an RB on this :-)

Thanks,
Tom

Quoted 49 lines · Tom
---
 drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h  | 2 ++
 drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h | 5 +++++
 2 files changed, 7 insertions(+)
drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h +2 -0
index 442ca7c471a5..6109f5ad25ad 100644
@@ -141,6 +141,8 @@
 #define mmUVD_GPCOM_VCPU_DATA0_BASE_IDX
                              1
 #define mmUVD_GPCOM_VCPU_DATA1
                             0x03c5
 #define mmUVD_GPCOM_VCPU_DATA1_BASE_IDX
                              1
+#define mmUVD_ENGINE_CNTL
                              0x03c6
+#define mmUVD_ENGINE_CNTL_BASE_IDX
                             1
 #define mmUVD_UDEC_DBW_UV_ADDR_CONFIG
                              0x03d2
 #define mmUVD_UDEC_DBW_UV_ADDR_CONFIG_BASE_IDX
                             1
 #define mmUVD_UDEC_ADDR_CONFIG
                             0x03d3
drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h +5 -0
index 63457f9df4c5..f84bed6eecb9 100644
@@ -312,6 +312,11 @@
 //UVD_GPCOM_VCPU_DATA1
 #define UVD_GPCOM_VCPU_DATA1__DATA1__SHIFT
                                    0x0
 #define UVD_GPCOM_VCPU_DATA1__DATA1_MASK
                                    0xFFFFFFFFL
+//UVD_ENGINE_CNTL
+#define UVD_ENGINE_CNTL__ENGINE_START_MASK 0x1
+#define UVD_ENGINE_CNTL__ENGINE_START__SHIFT 0x0
+#define UVD_ENGINE_CNTL__ENGINE_START_MODE_MASK 0x2
+#define UVD_ENGINE_CNTL__ENGINE_START_MODE__SHIFT 0x1
 //UVD_UDEC_DBW_UV_ADDR_CONFIG
 #define UVD_UDEC_DBW_UV_ADDR_CONFIG__NUM_PIPES__SHIFT
                                     0x0
 #define UVD_UDEC_DBW_UV_ADDR_CONFIG__PIPE_INTERLEAVE_SIZE__SHIFT
                                    0x3
Quoted 7 lines

--
2.17.2

_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): CAAzXoRLtZG_A4GgscVRo5aGL11i1PqUTrdTtOGyYvNjSgYCpLQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

Reviewed-by
#5 lore raw

________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Tom St Denis <[email protected]>
Sent: Tuesday, March 5, 2019 10:17 AM
To: amd-gfx mailing list
Subject: Re: [PATCH] drm/amd/amdgpu: Add ENGINE_CNTL register to vcn10 headers

Hi,

Alex can I get an RB on this :-)

Thanks,
Tom

On Mon, Mar 4, 2019 at 10:59 AM StDenis, Tom <[email protected]<mailto:[email protected]>> wrote:

---
 drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h  | 2 ++
 drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h | 5 +++++
 2 files changed, 7 insertions(+)
drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h +2 -0
index 442ca7c471a5..6109f5ad25ad 100644
@@ -141,6 +141,8 @@
 #define mmUVD_GPCOM_VCPU_DATA0_BASE_IDX                                                                1
 #define mmUVD_GPCOM_VCPU_DATA1                                                                         0x03c5
 #define mmUVD_GPCOM_VCPU_DATA1_BASE_IDX                                                                1
+#define mmUVD_ENGINE_CNTL                                                                              0x03c6
+#define mmUVD_ENGINE_CNTL_BASE_IDX                                                                     1
 #define mmUVD_UDEC_DBW_UV_ADDR_CONFIG                                                                  0x03d2
 #define mmUVD_UDEC_DBW_UV_ADDR_CONFIG_BASE_IDX                                                         1
 #define mmUVD_UDEC_ADDR_CONFIG                                                                         0x03d3
drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h +5 -0
index 63457f9df4c5..f84bed6eecb9 100644
@@ -312,6 +312,11 @@
 //UVD_GPCOM_VCPU_DATA1
 #define UVD_GPCOM_VCPU_DATA1__DATA1__SHIFT                                                                    0x0
 #define UVD_GPCOM_VCPU_DATA1__DATA1_MASK                                                                      0xFFFFFFFFL
+//UVD_ENGINE_CNTL
+#define UVD_ENGINE_CNTL__ENGINE_START_MASK 0x1
+#define UVD_ENGINE_CNTL__ENGINE_START__SHIFT 0x0
+#define UVD_ENGINE_CNTL__ENGINE_START_MODE_MASK 0x2
+#define UVD_ENGINE_CNTL__ENGINE_START_MODE__SHIFT 0x1
 //UVD_UDEC_DBW_UV_ADDR_CONFIG
 #define UVD_UDEC_DBW_UV_ADDR_CONFIG__NUM_PIPES__SHIFT                                                         0x0
 #define UVD_UDEC_DBW_UV_ADDR_CONFIG__PIPE_INTERLEAVE_SIZE__SHIFT                                              0x3

--
2.17.2

_______________________________________________
amd-gfx mailing list [email protected]<mailto:[email protected]>
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx