mm/oom0[3|4]: added 'OOM for CPUSET' and updated 'OOM with MEMCG & numa'

PATCH Jan Stancek 2 participants 3 messages Mar 15, 2013 1 message not in the archive

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jan Stancek

author

2013-03-15 09:12 UTC #1 lore raw

----- Original Message -----

Quoted 11 lines

From: "Zhouping Liu" <[email protected]>
To: "Jan Stancek" <[email protected]>
Cc: [email protected], "LTP List" <[email protected]>
Sent: Friday, 15 March, 2013 3:52:26 AM
Subject: Re: [LTP] [PATCH 3/5] mm/oom0[3|4]: added 'OOM for CPUSET' and updated 'OOM with MEMCG & numa'
Quoted 4 lines
We could add a simple function to numa_helper, but I'm not sure what
it would return as default, some tests care about nodes with memory.

Quoted 6 lines

yes, what you care about is right, but now we only need a function, which
can tell us the system have more than one node, we don't care about the
nodes have
CPUs or memory.

What I was wondering is why that comment said "rough estimate", it looks quite accurate. Anyway, thanks for clarifying.

Regards,
Jan

Quoted 6 lines

so I will created is_numa() in numa_helper to implement it.
Thanks
Zhouping

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Zhouping Liu

2013-03-15 15:41 UTC #2 lore raw

----- Original Message -----

Quoted 21 lines

From: "Jan Stancek" <[email protected]>
To: "Zhouping Liu" <[email protected]>
Cc: "LTP List" <[email protected]>
Sent: Friday, March 15, 2013 5:11:57 PM
Subject: Re: [LTP] [PATCH 3/5] mm/oom0[3|4]: added 'OOM for CPUSET' and updated 'OOM with MEMCG & numa'
----- Original Message -----
Quoted 12 lines
From: "Zhouping Liu" <[email protected]>
To: "Jan Stancek" <[email protected]>
Cc: [email protected], "LTP List" <[email protected]>
Sent: Friday, 15 March, 2013 3:52:26 AM
Subject: Re: [LTP] [PATCH 3/5] mm/oom0[3|4]: added 'OOM for CPUSET' and updated 'OOM with MEMCG & numa'
Quoted 4 lines
We could add a simple function to numa_helper, but I'm not sure what
it would return as default, some tests care about nodes with memory.

Quoted 8 lines

Quoted 6 lines
yes, what you care about is right, but now we only need a function, which
can tell us the system have more than one node, we don't care about the
nodes have
CPUs or memory.
What I was wondering is why that comment said "rough estimate",

because in the old version, I just used the max node id to judge a NUMA system, which maybe is not strict.

Quoted 1 line

it looks quite accurate. Anyway, thanks for clarifying.

in the V2 version, I removed the ISNUMA variable, and added a new function is_numa(), inside the function, the system, which has 1 more than numa node, and each node at least contains memory, is regarded as a numa system. I think it's more reasoned, because NUMA is mainly about memory, more case will fail if the node has no memory. do you agree?

Signature · 12 lines

Thanks,
Zhouping

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Jan Stancek

author

2013-03-15 16:06 UTC #3 lore raw

----- Original Message -----

Quoted 49 lines

From: "Zhouping Liu" <[email protected]>
To: "Jan Stancek" <[email protected]>
Cc: "LTP List" <[email protected]>
Sent: Friday, 15 March, 2013 4:41:29 PM
Subject: Re: [LTP] [PATCH 3/5] mm/oom0[3|4]: added 'OOM for CPUSET' and updated 'OOM with MEMCG & numa'
----- Original Message -----
Quoted 32 lines
From: "Jan Stancek" <[email protected]>
To: "Zhouping Liu" <[email protected]>
Cc: "LTP List" <[email protected]>
Sent: Friday, March 15, 2013 5:11:57 PM
Subject: Re: [LTP] [PATCH 3/5] mm/oom0[3|4]: added 'OOM for CPUSET' and updated 'OOM with MEMCG & numa'
----- Original Message -----
Quoted 13 lines
From: "Zhouping Liu" <[email protected]>
To: "Jan Stancek" <[email protected]>
Cc: [email protected], "LTP List" <[email protected]>
Sent: Friday, 15 March, 2013 3:52:26 AM
Subject: Re: [LTP] [PATCH 3/5] mm/oom0[3|4]: added 'OOM for CPUSET'
and updated 'OOM with MEMCG & numa'
Quoted 4 lines
We could add a simple function to numa_helper, but I'm not sure what
it would return as default, some tests care about nodes with memory.
Quoted 8 lines
yes, what you care about is right, but now we only need a function,
which
can tell us the system have more than one node, we don't care about
the
nodes have
CPUs or memory.
Quoted 1 line
What I was wondering is why that comment said "rough estimate",
because in the old version, I just used the max node id to judge a NUMA system,
which maybe is not strict.
Quoted 1 line
it looks quite accurate. Anyway, thanks for clarifying.

Quoted 9 lines

in the V2 version, I removed the ISNUMA variable, and added a new function is_numa(),
inside the function, the system, which has 1 more than numa node, and each node at
least contains memory, is regarded as a numa system. I think it's more reasoned,
because NUMA is mainly about memory, more case will fail if the node has no memory.
do you agree?

I agree. Some failures on unbalanced NUMA systems led to introducing that check. I was looking at our system pool and number of such systems is very low, so I don't think we are loosing very much by requiring 2+ nodes with memory.

Quoted 5 lines

--
Thanks,
Zhouping