Skip to contentSkip to conversation

Add XYUV format support

PATCH Superseded Stanislav Lisovskiy 7 participants 21 messages Sep 7, 2018 – Sep 17, 2018

Subsystems (3)

v10 of 12 Superseded Latest is v12 →

lore
Share & tools
lore
#0 lore raw

v10 cover Add XYUV format support

Introduced new XYUV scan-in format for framebuffer and added support for it to i915(SkyLake+).

Stanislav Lisovskiy (2):
drm: Introduce new DRM_FORMAT_XYUV
drm/i915: Adding YUV444 packed format support for skl+

 drivers/gpu/drm/drm_fourcc.c         |  1 +
 drivers/gpu/drm/i915/i915_reg.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
 drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
 include/uapi/drm/drm_fourcc.h        |  1 +
 5 files changed, 20 insertions(+), 1 deletion(-)
Signature · 6 lines
2.17.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

PATCH v10 1/2 drm: Introduce new DRM_FORMAT_XYUV

v5: This is YUV444 packed format same as AYUV, but without alpha,
as supported by i915.

v6: Removed unneeded initializer for new XYUV format.

v7: Added is_yuv field initialization according to latest
drm_fourcc format structure initialization changes.

v8: Edited commit message to be more clear about skl+, renamed
PLANE_CTL_FORMAT_AYUV to PLANE_CTL_FORMAT_XYUV as this format doesn't support per-pixel alpha. Fixed minor code issues.

v9: Moved DRM format check to proper place in intel_framebuffer_init.

---
 drivers/gpu/drm/drm_fourcc.c  | 1 +
 include/uapi/drm/drm_fourcc.h | 1 +
 2 files changed, 2 insertions(+)
drivers/gpu/drm/drm_fourcc.c +1 -0
index 35c1e2742c27..2ad09c7ecebc 100644
@@ -173,6 +173,7 @@ const struct drm_format_info *__drm_format_info(u32 format)
 		{ .format = DRM_FORMAT_UYVY,		.depth = 0,  .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1, .is_yuv = true },
 		{ .format = DRM_FORMAT_VYUY,		.depth = 0,  .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1, .is_yuv = true },
 		{ .format = DRM_FORMAT_AYUV,		.depth = 0,  .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true, .is_yuv = true },
+		{ .format = DRM_FORMAT_XYUV,		.depth = 0,  .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .is_yuv = true },
 	};
 
 	unsigned int i;
include/uapi/drm/drm_fourcc.h +1 -0
index 2ed46e9ae16a..5ba5b1473342 100644
@@ -148,6 +148,7 @@ extern "C" {
 #define DRM_FORMAT_VYUY		fourcc_code('V', 'Y', 'U', 'Y') /* [31:0] Y1:Cb0:Y0:Cr0 8:8:8:8 little endian */
 
 #define DRM_FORMAT_AYUV		fourcc_code('A', 'Y', 'U', 'V') /* [31:0] A:Y:Cb:Cr 8:8:8:8 little endian */
+#define DRM_FORMAT_XYUV		fourcc_code('X', 'Y', 'U', 'V') /* [31:0] X:Y:Cb:Cr 8:8:8:8 little endian */
 
 /*
  * 2 plane RGB + A
Signature · 6 lines
2.17.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

PATCH v10 2/2 drm/i915: Adding YUV444 packed format support for skl+

In reply to Stanislav Lisovskiy

PLANE_CTL_FORMAT_AYUV is already supported, according to hardware specification.

v2: Edited commit message, removed redundant whitespaces.

v3: Fixed fallthrough logic for the format switch cases.

v4: Yet again fixed fallthrough logic, to reuse code from other case
labels.

v5: Started to use XYUV instead of AYUV, as we don't use alpha.

v6: Removed unneeded initializer for new XYUV format.

v7: Added scaling support for DRM_FORMAT_XYUV

v8: Edited commit message to be more clear about skl+, renamed
PLANE_CTL_FORMAT_AYUV to PLANE_CTL_FORMAT_XYUV as this format doesn't support per-pixel alpha. Fixed minor code issues.

v9: Moved DRM format check to proper place in intel_framebuffer_init.

v10: Added missing XYUV format to sprite planes for skl+.

---
 drivers/gpu/drm/i915/i915_reg.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
 drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
 3 files changed, 18 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_reg.h +1 -1
index 8534f88a60f6..e0c8480aaa02 100644
@@ -6499,7 +6499,7 @@ enum {
 #define   PLANE_CTL_FORMAT_XRGB_2101010		(2 << 24)
 #define   PLANE_CTL_FORMAT_XRGB_8888		(4 << 24)
 #define   PLANE_CTL_FORMAT_XRGB_16161616F	(6 << 24)
-#define   PLANE_CTL_FORMAT_AYUV			(8 << 24)
+#define   PLANE_CTL_FORMAT_XYUV			(8 << 24)
 #define   PLANE_CTL_FORMAT_INDEXED		(12 << 24)
 #define   PLANE_CTL_FORMAT_RGB_565		(14 << 24)
 #define   ICL_PLANE_CTL_FORMAT_MASK		(0x1f << 23)
drivers/gpu/drm/i915/intel_display.c +15 -0
index 30fdfd1a3037..9323708db71f 100644
@@ -86,6 +86,7 @@ static const uint32_t skl_primary_formats[] = {
 	DRM_FORMAT_YVYU,
 	DRM_FORMAT_UYVY,
 	DRM_FORMAT_VYUY,
+	DRM_FORMAT_XYUV,
 };
 
 static const uint32_t skl_pri_planar_formats[] = {
@@ -101,6 +102,7 @@ static const uint32_t skl_pri_planar_formats[] = {
 	DRM_FORMAT_YVYU,
 	DRM_FORMAT_UYVY,
 	DRM_FORMAT_VYUY,
+	DRM_FORMAT_XYUV,
 	DRM_FORMAT_NV12,
 };
 
@@ -2672,6 +2674,8 @@ int skl_format_to_fourcc(int format, bool rgb_order, bool alpha)
 		return DRM_FORMAT_RGB565;
 	case PLANE_CTL_FORMAT_NV12:
 		return DRM_FORMAT_NV12;
+	case PLANE_CTL_FORMAT_XYUV:
+		return DRM_FORMAT_XYUV;
 	default:
 	case PLANE_CTL_FORMAT_XRGB_8888:
 		if (rgb_order) {
@@ -3501,6 +3505,8 @@ static u32 skl_plane_ctl_format(uint32_t pixel_format)
 		return PLANE_CTL_FORMAT_XRGB_2101010;
 	case DRM_FORMAT_XBGR2101010:
 		return PLANE_CTL_ORDER_RGBX | PLANE_CTL_FORMAT_XRGB_2101010;
+	case DRM_FORMAT_XYUV:
+		return PLANE_CTL_FORMAT_XYUV;
 	case DRM_FORMAT_YUYV:
 		return PLANE_CTL_FORMAT_YUV422 | PLANE_CTL_YUV422_YUYV;
 	case DRM_FORMAT_YVYU:
@@ -4959,6 +4965,7 @@ static int skl_update_scaler_plane(struct intel_crtc_state *crtc_state,
 	case DRM_FORMAT_UYVY:
 	case DRM_FORMAT_VYUY:
 	case DRM_FORMAT_NV12:
+	case DRM_FORMAT_XYUV:
 		break;
 	default:
 		DRM_DEBUG_KMS("[PLANE:%d:%s] FB:%d unsupported scaling format 0x%x\n",
@@ -13414,6 +13421,7 @@ static bool skl_plane_format_mod_supported(struct drm_plane *_plane,
 	case DRM_FORMAT_UYVY:
 	case DRM_FORMAT_VYUY:
 	case DRM_FORMAT_NV12:
+	case DRM_FORMAT_XYUV:
 		if (modifier == I915_FORMAT_MOD_Yf_TILED)
 			return true;
 		/* fall through */
@@ -14540,6 +14548,13 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
 			goto err;
 		}
 		break;
+	case DRM_FORMAT_XYUV:
+		if (INTEL_GEN(dev_priv) < 9) {
+			DRM_DEBUG_KMS("unsupported pixel format: %s\n",
+				      drm_get_format_name(mode_cmd->pixel_format, &format_name));
+			goto err;
+		}
+		break;
 	case DRM_FORMAT_YUYV:
 	case DRM_FORMAT_UYVY:
 	case DRM_FORMAT_YVYU:
drivers/gpu/drm/i915/intel_sprite.c +2 -0
index c286dda625e4..5c3931d2c557 100644
@@ -1266,6 +1266,7 @@ static uint32_t skl_plane_formats[] = {
 	DRM_FORMAT_YVYU,
 	DRM_FORMAT_UYVY,
 	DRM_FORMAT_VYUY,
+	DRM_FORMAT_XYUV,
 };
 
 static uint32_t skl_planar_formats[] = {
@@ -1420,6 +1421,7 @@ static bool skl_plane_format_mod_supported(struct drm_plane *_plane,
 	case DRM_FORMAT_UYVY:
 	case DRM_FORMAT_VYUY:
 	case DRM_FORMAT_NV12:
+	case DRM_FORMAT_XYUV:
 		if (modifier == I915_FORMAT_MOD_Yf_TILED)
 			return true;
 		/* fall through */
Signature · 6 lines
2.17.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#3 lore raw

✗ Fi.CI.CHECKPATCH: warning for Add XYUV format support (rev6)

In reply to Stanislav Lisovskiy
== Series Details ==

== Series Details ==

Series: Add XYUV format support (rev6)
URL : https://patchwork.freedesktop.org/series/48007/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
28881f8a7368 drm: Introduce new DRM_FORMAT_XYUV
-:30: WARNING:LONG_LINE: line over 100 characters
#30: FILE: drivers/gpu/drm/drm_fourcc.c:193:
+		{ .format = DRM_FORMAT_XYUV,		.depth = 0,  .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .is_yuv = true },

-:42: WARNING:LONG_LINE_COMMENT: line over 100 characters #42: FILE: include/uapi/drm/drm_fourcc.h:154:
+#define DRM_FORMAT_XYUV fourcc_code('X', 'Y', 'U', 'V') /* [31:0] X:Y:Cb:Cr 8:8:8:8 little endian */

total: 0 errors, 2 warnings, 0 checks, 14 lines checked 43038ad4912e drm/i915: Adding YUV444 packed format support for skl+

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

✓ Fi.CI.BAT: success for Add XYUV format support (rev6)

In reply to Stanislav Lisovskiy
== Series Details ==

== Series Details ==

Series: Add XYUV format support (rev6)
URL : https://patchwork.freedesktop.org/series/48007/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4786 -> Patchwork_10123 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/48007/revisions/6/mbox/

== Known issues ==

Here are the changes found in Patchwork_10123 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@kms_chamelium@dp-edid-read:
      fi-kbl-7500u:       PASS -> FAIL (fdo#103841)

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     PASS -> FAIL (fdo#103167)

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
      fi-byt-clapper:     PASS -> FAIL (fdo#107362, fdo#103191)

    igt@pm_rpm@basic-pci-d3-state:
      fi-glk-dsi:         PASS -> INCOMPLETE (fdo#103359, k.org#198133)

    
    ==== Possible fixes ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-byt-clapper:     FAIL (fdo#107362, fdo#103191) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    igt@kms_psr@primary_page_flip:
      fi-kbl-r:           FAIL (fdo#107336) -> PASS

fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133

== Participating hosts (54 -> 49) ==

Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4786 -> Patchwork_10123

CI_DRM_4786: d28dcb05a3c33df6fcb0828d81fa0bb6591a97be @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4634: 7d89cc39dde3b4881d85ace45d504cc098fa3684 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10123: 43038ad4912e589e9c487d88f4901c064ea66af4 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

43038ad4912e drm/i915: Adding YUV444 packed format support for skl+ 28881f8a7368 drm: Introduce new DRM_FORMAT_XYUV

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10123/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

✗ Fi.CI.IGT: failure for Add XYUV format support (rev6)

In reply to Stanislav Lisovskiy
== Series Details ==

== Series Details ==

Series: Add XYUV format support (rev6)
URL : https://patchwork.freedesktop.org/series/48007/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4786_full -> Patchwork_10123_full =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_10123_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10123_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10123_full:

=== IGT changes ===

    ==== Possible regressions ====

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-apl:          PASS -> FAIL

    
    ==== Warnings ====

    igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
      shard-hsw:          SKIP -> PASS

    igt@kms_vblank@pipe-b-wait-forked:
      shard-snb:          PASS -> SKIP

    igt@perf_pmu@rc6:
      shard-kbl:          PASS -> SKIP

== Known issues ==

Here are the changes found in Patchwork_10123_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-glk:          PASS -> FAIL (fdo#106886)

    igt@gem_exec_big:
      shard-hsw:          PASS -> INCOMPLETE (fdo#103540)

    
    ==== Possible fixes ====

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt:
      shard-glk:          FAIL (fdo#103167) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
      shard-apl:          FAIL (fdo#103167) -> PASS

fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4786 -> Patchwork_10123

CI_DRM_4786: d28dcb05a3c33df6fcb0828d81fa0bb6591a97be @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4634: 7d89cc39dde3b4881d85ace45d504cc098fa3684 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10123: 43038ad4912e589e9c487d88f4901c064ea66af4 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10123/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

Re: ✗ Fi.CI.IGT: failure for Add XYUV format support (rev6)

Quoted 23 lines · Patchwork

== Series Details ==

Series: Add XYUV format support (rev6)
URL : https://patchwork.freedesktop.org/series/48007/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4786_full -> Patchwork_10123_full =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_10123_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10123_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Quoted 9 lines

Here are the unknown changes that may have been introduced in Patchwork_10123_full:

=== IGT changes ===

    ==== Possible regressions ====

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-apl:          PASS -> FAIL

This is known issue: https://bugs.freedesktop.org/show_bug.cgi?id=106701

That means your patch is a SUCCESS from a CI perspective. Sorry for the noise!

Quoted 56 lines
    
    ==== Warnings ====

    igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
      shard-hsw:          SKIP -> PASS

    igt@kms_vblank@pipe-b-wait-forked:
      shard-snb:          PASS -> SKIP

    igt@perf_pmu@rc6:
      shard-kbl:          PASS -> SKIP

== Known issues ==

Here are the changes found in Patchwork_10123_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-glk:          PASS -> FAIL (fdo#106886)

    igt@gem_exec_big:
      shard-hsw:          PASS -> INCOMPLETE (fdo#103540)

    
    ==== Possible fixes ====

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt:
      shard-glk:          FAIL (fdo#103167) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
      shard-apl:          FAIL (fdo#103167) -> PASS

fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4786 -> Patchwork_10123

CI_DRM_4786: d28dcb05a3c33df6fcb0828d81fa0bb6591a97be @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4634: 7d89cc39dde3b4881d85ace45d504cc098fa3684 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10123: 43038ad4912e589e9c487d88f4901c064ea66af4 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

Quoted 8 lines

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10123/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

Re: ✗ Fi.CI.IGT: failure for Add XYUV format support (rev6)

Quoted 10 lines · Martin Peres

This is known issue: https://bugs.freedesktop.org/show_bug.cgi?id=106
701

That means your patch is a SUCCESS from a CI perspective. Sorry for the
noise!

Sounds just great! :)

Quoted 72 lines
Quoted 72 lines
    
    ==== Warnings ====

    igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
      shard-hsw:          SKIP -> PASS

    igt@kms_vblank@pipe-b-wait-forked:
      shard-snb:          PASS -> SKIP

    igt@perf_pmu@rc6:
      shard-kbl:          PASS -> SKIP

== Known issues ==

Here are the changes found in Patchwork_10123_full that come from
known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-glk:          PASS -> FAIL (fdo#106886)

    igt@gem_exec_big:
      shard-hsw:          PASS -> INCOMPLETE (fdo#103540)

    
    ==== Possible fixes ====

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mma
p-gtt:
      shard-glk:          FAIL (fdo#103167) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mma
p-wc:
      shard-apl:          FAIL (fdo#103167) -> PASS

fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4786 -> Patchwork_10123

CI_DRM_4786: d28dcb05a3c33df6fcb0828d81fa0bb6591a97be @
git://anongit.freedesktop.org/gfx-ci/linux
IGT_4634: 7d89cc39dde3b4881d85ace45d504cc098fa3684 @
git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10123: 43038ad4912e589e9c487d88f4901c064ea66af4 @
git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patc
hwork_10123/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 7 lines
Best Regards,

Lisovskiy Stanislav
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw

✓ Fi.CI.BAT: success for Add XYUV format support (rev6)

In reply to Stanislav Lisovskiy
== Series Details ==

== Series Details ==

Series: Add XYUV format support (rev6)
URL : https://patchwork.freedesktop.org/series/48007/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4810 -> Patchwork_10154 =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_10154 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10154, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/48007/revisions/6/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10154:

=== IGT changes ===

    ==== Warnings ====

    igt@pm_rpm@module-reload:
      fi-hsw-4770r:       SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_10154 that come from known issues:

=== IGT changes ===

    ==== Possible fixes ====

    igt@drv_hangman@error-state-basic:
      fi-kbl-7560u:       INCOMPLETE -> PASS

    igt@drv_module_reload@basic-reload-inject:
      fi-hsw-4770r:       DMESG-WARN (fdo#107425) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     FAIL (fdo#103167) -> PASS

fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425

== Participating hosts (50 -> 45) ==

Additional (1): fi-glk-j4005
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u

== Build changes ==

* Linux: CI_DRM_4810 -> Patchwork_10154

CI_DRM_4810: 4c0e813835d47e6e9285175e7b92e21fe3d4328f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4640: 9a8da36e708f9ed15b20689dfe305e41f9a19008 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10154: 9490ef9a07aee695e0e1360495c2384ea417ed64 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

9490ef9a07ae drm/i915: Adding YUV444 packed format support for skl+ b0a4446bc5d1 drm: Introduce new DRM_FORMAT_XYUV

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10154/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

✓ Fi.CI.IGT: success for Add XYUV format support (rev6)

In reply to Stanislav Lisovskiy
== Series Details ==

== Series Details ==

Series: Add XYUV format support (rev6)
URL : https://patchwork.freedesktop.org/series/48007/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4810_full -> Patchwork_10154_full =

== Summary - SUCCESS ==

No regressions found.

== Known issues ==

Here are the changes found in Patchwork_10154_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-apl:          PASS -> FAIL (fdo#106701)

    
    ==== Possible fixes ====

    igt@kms_cursor_legacy@cursor-vs-flip-toggle:
      shard-hsw:          FAIL (fdo#103355) -> PASS

    igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
      shard-glk:          FAIL (fdo#105363) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#106701 https://bugs.freedesktop.org/show_bug.cgi?id=106701
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4810 -> Patchwork_10154

CI_DRM_4810: 4c0e813835d47e6e9285175e7b92e21fe3d4328f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4640: 9a8da36e708f9ed15b20689dfe305e41f9a19008 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10154: 9490ef9a07aee695e0e1360495c2384ea417ed64 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10154/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw
In reply to Stanislav Lisovskiy
Quoted 7 lines · Stanislav Lisovskiy

Introduced new XYUV scan-in format for framebuffer and added support for it to i915(SkyLake+).

Stanislav Lisovskiy (2):
drm: Introduce new DRM_FORMAT_XYUV
drm/i915: Adding YUV444 packed format support for skl+

Quoted 7 lines
 drivers/gpu/drm/drm_fourcc.c         |  1 +
 drivers/gpu/drm/i915/i915_reg.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
 drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
 include/uapi/drm/drm_fourcc.h        |  1 +
 5 files changed, 20 insertions(+), 1 deletion(-)

Ping. There is an IGT patch which got Reviewed-by Ville. This one left in order to get XYUV support.

Signature · 7 lines
Best Regards,

Lisovskiy Stanislav
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#11 lore raw
Quoted 16 lines · Stanislav
Quoted 7 lines · Stanislav Lisovskiy

Introduced new XYUV scan-in format for framebuffer and added support for it to i915(SkyLake+).

Stanislav Lisovskiy (2):
drm: Introduce new DRM_FORMAT_XYUV
drm/i915: Adding YUV444 packed format support for skl+

Quoted 7 lines
 drivers/gpu/drm/drm_fourcc.c         |  1 +
 drivers/gpu/drm/i915/i915_reg.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
 drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
 include/uapi/drm/drm_fourcc.h        |  1 +
 5 files changed, 20 insertions(+), 1 deletion(-)
Quoted 2 lines

Ping. There is an IGT patch which got Reviewed-by Ville. This one left in order to get XYUV support.

Did we figure out userspace for this?

Was the conflict solved with the other guy (forgot who it is) trying to add the same format with a different name?

Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#12 lore raw
Quoted 17 lines · Ville Syrjälä
Quoted 16 lines · Stanislav
Quoted 14 lines · Stanislav Lisovskiy

Introduced new XYUV scan-in format for framebuffer and added support for it to i915(SkyLake+).

Stanislav Lisovskiy (2):
drm: Introduce new DRM_FORMAT_XYUV
drm/i915: Adding YUV444 packed format support for skl+

 drivers/gpu/drm/drm_fourcc.c         |  1 +
 drivers/gpu/drm/i915/i915_reg.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
 drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
 include/uapi/drm/drm_fourcc.h        |  1 +
 5 files changed, 20 insertions(+), 1 deletion(-)
Quoted 7 lines
Quoted 2 lines

Ping. There is an IGT patch which got Reviewed-by Ville. This one left in order to get XYUV support.

Did we figure out userspace for this?

Was the conflict solved with the other guy (forgot who it is) trying to add the same format with a different name?

Currently for userspace we have VLC(checked with Juha-Pekka) and also IGT test case.

I think those guys were from ARM and they were adding also support for XYUV. The only difference was that they called XYUV, like XYUV8888 something.
Our patches were otherwise identical regarding drm_fourcc.c part, I don't see their stuff merged, but I guess it really shouldn't matter, who does this first. i915 specific part doesn't conflict with their stuff. To be honest, I forgot the guy's name neither could find his email in my mailbox.
So hopefully somebody shows up here.

Quoted 1 line
Signature · 7 lines
Best Regards,

Lisovskiy Stanislav
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#13 lore raw

Hi,

Quoted 39 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Lisovskiy, Stanislav
Sent: perjantai 14. syyskuuta 2018 17.31
To: [email protected]
Cc: [email protected]; Syrjala, Ville <[email protected]>; Heikkila, Juha-pekka <[email protected]>; dri- [email protected]; Peres, Martin <[email protected]>
Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

Quoted 17 lines · Ville Syrjälä
Quoted 16 lines · Stanislav
Quoted 14 lines · Stanislav Lisovskiy

Introduced new XYUV scan-in format for framebuffer and added support for it to i915(SkyLake+).

Stanislav Lisovskiy (2):
drm: Introduce new DRM_FORMAT_XYUV
drm/i915: Adding YUV444 packed format support for skl+

 drivers/gpu/drm/drm_fourcc.c         |  1 +
 drivers/gpu/drm/i915/i915_reg.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
 include/uapi/drm/drm_fourcc.h        |  1 +
 5 files changed, 20 insertions(+), 1 deletion(-)
Quoted 7 lines
Quoted 2 lines

Ping. There is an IGT patch which got Reviewed-by Ville. This one left in order to get XYUV support.

Did we figure out userspace for this?

Was the conflict solved with the other guy (forgot who it is) trying to add the same format with a different name?

Currently for userspace we have VLC(checked with Juha-Pekka) and also IGT test case.

Quoted 8 lines

I think those guys were from ARM and they were adding also support for XYUV. The only difference was that they called XYUV, like XYUV8888 something.
Our patches were otherwise identical regarding drm_fourcc.c part, I don't see their stuff merged, but I guess it really shouldn't matter, who does this first. i915 specific part doesn't conflict with their stuff. To be honest, I forgot the guy's name neither could find his email in my mailbox.
So hopefully somebody shows up here.

Stan:
Alexandru-Cosmin Gheorghe <[email protected]> ?

Quoted 10 lines
Quoted 2 lines

--
Best Regards,

Lisovskiy Stanislav
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#14 lore raw
Quoted 59 lines · Jani

Hi,

Quoted 44 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf
Of Lisovskiy, Stanislav
Sent: perjantai 14. syyskuuta 2018 17.31
To: [email protected]
Cc: [email protected]; Syrjala, Ville <ville.syrjala@ intel.com>;
Heikkila, Juha-pekka <[email protected]>; dri- [email protected]; Peres, Martin <[email protected]>
Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

Quoted 18 lines · Ville Syrjälä
Quoted 16 lines · Stanislav
Quoted 14 lines · Stanislav Lisovskiy

Introduced new XYUV scan-in format for framebuffer and added support for it to i915(SkyLake+).

Stanislav Lisovskiy (2):
drm: Introduce new DRM_FORMAT_XYUV
drm/i915: Adding YUV444 packed format support for skl+

 drivers/gpu/drm/drm_fourcc.c         |  1 +
 drivers/gpu/drm/i915/i915_reg.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
 include/uapi/drm/drm_fourcc.h        |  1 +
 5 files changed, 20 insertions(+), 1 deletion(-)
Quoted 8 lines
Quoted 2 lines

Ping. There is an IGT patch which got Reviewed-by Ville. This one left in order to get XYUV support.

Did we figure out userspace for this?

Was the conflict solved with the other guy (forgot who it is) trying
to add the same format with a different name?

Currently for userspace we have VLC(checked with Juha-Pekka) and also IGT
test case.

Quoted 12 lines

I think those guys were from ARM and they were adding also support for
XYUV. The only difference was that they called XYUV, like XYUV8888 something.
Our patches were otherwise identical regarding drm_fourcc.c part, I don't
see their stuff merged, but I guess it really shouldn't matter, who does this
first. i915 specific part doesn't conflict with their stuff. To be honest, I forgot
the guy's name neither could find his email in my mailbox. So hopefully somebody shows up here.

Quoted 3 lines

Stan:
Alexandru-Cosmin Gheorghe <[email protected]> ?

Exactly, found now. Thanks for the hint!

Quoted 11 lines
Quoted 11 lines
Quoted 2 lines

--
Best Regards,

Lisovskiy Stanislav
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 7 lines
Best Regards,

Lisovskiy Stanislav
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#15 lore raw
Quoted 60 lines · Stanislav
Quoted 59 lines · Jani

Hi,

Quoted 56 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf
Of Lisovskiy, Stanislav
Sent: perjantai 14. syyskuuta 2018 17.31
To: [email protected]
Cc: [email protected]; Syrjala, Ville <ville.syrjala@ intel.com>;
Heikkila, Juha-pekka <[email protected]>; dri- [email protected]; Peres, Martin <[email protected]>
Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

Quoted 18 lines · Ville Syrjälä
Quoted 16 lines · Stanislav
Quoted 14 lines · Stanislav Lisovskiy

Introduced new XYUV scan-in format for framebuffer and added support for it to i915(SkyLake+).

Stanislav Lisovskiy (2):
drm: Introduce new DRM_FORMAT_XYUV
drm/i915: Adding YUV444 packed format support for skl+

 drivers/gpu/drm/drm_fourcc.c         |  1 +
 drivers/gpu/drm/i915/i915_reg.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
 include/uapi/drm/drm_fourcc.h        |  1 +
 5 files changed, 20 insertions(+), 1 deletion(-)
Quoted 8 lines
Quoted 2 lines

Ping. There is an IGT patch which got Reviewed-by Ville. This one left in order to get XYUV support.

Did we figure out userspace for this?

Was the conflict solved with the other guy (forgot who it is) trying
to add the same format with a different name?

Currently for userspace we have VLC(checked with Juha-Pekka) and also IGT
test case.

I think those guys were from ARM and they were adding also support for
XYUV. The only difference was that they called XYUV, like XYUV8888 something.
Our patches were otherwise identical regarding drm_fourcc.c part, I don't
see their stuff merged, but I guess it really shouldn't matter, who does this
first. i915 specific part doesn't conflict with their stuff. To be honest, I forgot
the guy's name neither could find his email in my mailbox. So hopefully somebody shows up here.

Quoted 5 lines
Quoted 3 lines

Stan:
Alexandru-Cosmin Gheorghe <[email protected]> ?

Exactly, found now. Thanks for the hint!

Yes, that's me.
Not a real conflict here, as long as your patches are ready to be merged feel free to do it and I will just rebase my series on top of that.

Quoted 20 lines
Quoted 12 lines
Quoted 12 lines
Quoted 3 lines

--
Best Regards,

Lisovskiy Stanislav
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 7 lines
Best Regards,

Lisovskiy Stanislav
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
Cheers,
Alex G
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#16 lore raw
Quoted 79 lines · Alexandru-Cosmin Gheorghe
Quoted 78 lines · Stanislav
Quoted 76 lines · Jani

Hi,

Quoted 62 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected] ] On
Behalf
Of Lisovskiy, Stanislav
Sent: perjantai 14. syyskuuta 2018 17.31
To: [email protected]
Cc: [email protected]; Syrjala, Ville <ville.syrjala@
intel.com>;
Heikkila, Juha-pekka <[email protected]>; dri- [email protected]; Peres, Martin <martin.peres@intel. com>
Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

Quoted 22 lines · Ville Syrjälä
Quoted 19 lines · Stanislav
Quoted 16 lines · Stanislav Lisovskiy

Introduced new XYUV scan-in format for framebuffer and added
support for it to i915(SkyLake+).

Stanislav Lisovskiy (2):
drm: Introduce new DRM_FORMAT_XYUV
drm/i915: Adding YUV444 packed format support for skl+

 drivers/gpu/drm/drm_fourcc.c         |  1 +
 drivers/gpu/drm/i915/i915_reg.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 15
+++++++++++++++
drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
 include/uapi/drm/drm_fourcc.h        |  1 +
 5 files changed, 20 insertions(+), 1 deletion(-)
Quoted 8 lines
Quoted 2 lines

Ping. There is an IGT patch which got Reviewed-by Ville. This one left in order to get XYUV support.

Did we figure out userspace for this?

Was the conflict solved with the other guy (forgot who it is) trying
to add the same format with a different name?

Currently for userspace we have VLC(checked with Juha-Pekka) and
also IGT
test case.

I think those guys were from ARM and they were adding also support
for
XYUV. The only difference was that they called XYUV, like XYUV8888
something.
Our patches were otherwise identical regarding drm_fourcc.c part, I
don't

Quoted 8 lines

see their stuff merged, but I guess it really shouldn't matter, who
does this
first. i915 specific part doesn't conflict with their stuff. To be
honest, I forgot
the guy's name neither could find his email in my mailbox. So hopefully somebody shows up here.

Stan:
Alexandru-Cosmin Gheorghe <[email protected]> ?

Quoted 6 lines
Quoted 1 line

Exactly, found now. Thanks for the hint!

Yes, that's me.
Not a real conflict here, as long as your patches are ready to be merged feel free to do it and I will just rebase my series on top of that.

I can change DRM_FORMAT_XYUV naming to DRM_FORMAT_XYUV8888 also, so that my patch series then is compatible with yours.

Quoted 25 lines
Quoted 23 lines
Quoted 14 lines
Quoted 14 lines
Quoted 5 lines

--
Best Regards,

Lisovskiy Stanislav
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 7 lines
Best Regards,

Lisovskiy Stanislav
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Best Regards,

Lisovskiy Stanislav
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#17 lore raw

Hi,

Quoted 82 lines · Stanislav
Quoted 81 lines · Alexandru-Cosmin Gheorghe
Quoted 79 lines · Stanislav
Quoted 73 lines · Jani

Hi,

Quoted 62 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected] ] On
Behalf
Of Lisovskiy, Stanislav
Sent: perjantai 14. syyskuuta 2018 17.31
To: [email protected]
Cc: [email protected]; Syrjala, Ville <ville.syrjala@
intel.com>;
Heikkila, Juha-pekka <[email protected]>; dri- [email protected]; Peres, Martin <martin.peres@intel. com>
Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

Quoted 22 lines · Ville Syrjälä
Quoted 19 lines · Stanislav
Quoted 16 lines · Stanislav Lisovskiy

Introduced new XYUV scan-in format for framebuffer and added
support for it to i915(SkyLake+).

Stanislav Lisovskiy (2):
drm: Introduce new DRM_FORMAT_XYUV
drm/i915: Adding YUV444 packed format support for skl+

 drivers/gpu/drm/drm_fourcc.c         |  1 +
 drivers/gpu/drm/i915/i915_reg.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 15
+++++++++++++++
drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
 include/uapi/drm/drm_fourcc.h        |  1 +
 5 files changed, 20 insertions(+), 1 deletion(-)
Quoted 8 lines
Quoted 2 lines

Ping. There is an IGT patch which got Reviewed-by Ville. This one left in order to get XYUV support.

Did we figure out userspace for this?

Was the conflict solved with the other guy (forgot who it is) trying
to add the same format with a different name?

Currently for userspace we have VLC(checked with Juha-Pekka) and
also IGT
test case.

I think those guys were from ARM and they were adding also support
for
XYUV. The only difference was that they called XYUV, like XYUV8888
something.
Our patches were otherwise identical regarding drm_fourcc.c part, I
don't

Quoted 8 lines

see their stuff merged, but I guess it really shouldn't matter, who
does this
first. i915 specific part doesn't conflict with their stuff. To be
honest, I forgot
the guy's name neither could find his email in my mailbox. So hopefully somebody shows up here.

Quoted 3 lines

Stan:
Alexandru-Cosmin Gheorghe <[email protected]> ?

Exactly, found now. Thanks for the hint!

Quoted 7 lines
Quoted 4 lines

Yes, that's me.
Not a real conflict here, as long as your patches are ready to be merged feel free to do it and I will just rebase my series on top of that.

I can change DRM_FORMAT_XYUV naming to DRM_FORMAT_XYUV8888 also, so that my patch series then is compatible with yours.

That would be nice.
Thank you.

Quoted 30 lines
Quoted 26 lines
Quoted 24 lines
Quoted 15 lines
Quoted 15 lines
Quoted 6 lines

--
Best Regards,

Lisovskiy Stanislav
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 7 lines
Best Regards,

Lisovskiy Stanislav
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 3 lines
Best Regards,

Lisovskiy Stanislav
Signature · 6 lines
Cheers,
Alex G
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#18 lore raw
In reply to Lisovskiy, Stanislav

Lisovskiy, Stanislav kirjoitti 14.9.2018 klo 17.30:

Quoted 21 lines · Ville Syrjälä
Quoted 20 lines · Stanislav
Quoted 18 lines · Stanislav Lisovskiy
Quoted 7 lines

Introduced new XYUV scan-in format for framebuffer and added support for it to i915(SkyLake+).

Stanislav Lisovskiy (2):
drm: Introduce new DRM_FORMAT_XYUV
drm/i915: Adding YUV444 packed format support for skl+

Quoted 7 lines
  drivers/gpu/drm/drm_fourcc.c         |  1 +
  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
  drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
  drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
  include/uapi/drm/drm_fourcc.h        |  1 +
  5 files changed, 20 insertions(+), 1 deletion(-)

Ping. There is an IGT patch which got Reviewed-by Ville. This one left in order to get XYUV support.

Quoted 7 lines
Quoted 4 lines

Did we figure out userspace for this?

Was the conflict solved with the other guy (forgot who it is) trying to add the same format with a different name?

Currently for userspace we have VLC(checked with Juha-Pekka) and also IGT test case.

Hei, no. VLC was *not* showing the mode correctly back then when we tested. VLC kms plugin is able to initialize the mode and it's all stable but VLC didn't have correct video converter to reach matching xYUV output. You remember Stan we tried to increase the recursion for decoding in case it would help? VLC doesn't have codec which produce correct output, one of those xxx -> YUV plug-ins in VLC should be patched before VLC can be considered as userspace for this mode.

/Juha-Pekka

Quoted 12 lines

I think those guys were from ARM and they were adding also support for XYUV. The only difference was that they called XYUV, like XYUV8888 something.
Our patches were otherwise identical regarding drm_fourcc.c part, I don't see their stuff merged, but I guess it really shouldn't matter, who does this first. i915 specific part doesn't conflict with their stuff. To be honest, I forgot the guy's name neither could find his email in my mailbox.
So hopefully somebody shows up here.

Quoted 1 line

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#19 lore raw
Quoted 32 lines · Juha-Pekka Heikkilä

Lisovskiy, Stanislav kirjoitti 14.9.2018 klo 17.30:

Quoted 22 lines · Ville Syrjälä
Quoted 21 lines
Quoted 18 lines · Stanislav
Quoted 7 lines · Stanislav Lisovskiy

Introduced new XYUV scan-in format for framebuffer and added support for it to i915(SkyLake+).

Stanislav Lisovskiy (2):
drm: Introduce new DRM_FORMAT_XYUV
drm/i915: Adding YUV444 packed format support for skl+

Quoted 7 lines
  drivers/gpu/drm/drm_fourcc.c         |  1 +
  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
  drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
  drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
  include/uapi/drm/drm_fourcc.h        |  1 +
  5 files changed, 20 insertions(+), 1 deletion(-)

Ping. There is an IGT patch which got Reviewed-by Ville. This one left in order to get XYUV support.

Quoted 7 lines
Quoted 4 lines

Did we figure out userspace for this?

Was the conflict solved with the other guy (forgot who it is) trying to add the same format with a different name?

Currently for userspace we have VLC(checked with Juha-Pekka) and also IGT test case.

Quoted 8 lines

Hei, no. VLC was *not* showing the mode correctly back then when we tested. VLC kms plugin is able to initialize the mode and it's all stable but VLC didn't have correct video converter to reach matching xYUV output. You remember Stan we tried to increase the recursion for
decoding in case it would help? VLC doesn't have codec which produce correct output, one of those xxx -> YUV plug-ins in VLC should be patched before VLC can be considered as userspace for this mode.

Ok, I remember we managed to make it work somehow and saw some picture, so for some reason I thought it is working already. What is our plan then? Should we try to improve VLC codecs/plugins or may be I should then work with some other user space case?

Quoted 17 lines

/Juha-Pekka

Quoted 14 lines

I think those guys were from ARM and they were adding also support for
XYUV. The only difference was that they called XYUV, like XYUV8888 something.
Our patches were otherwise identical regarding drm_fourcc.c part, I don't see their stuff merged, but I guess it really shouldn't matter,
who does this first. i915 specific part doesn't conflict with their stuff. To be honest, I forgot the guy's name neither could find his email in my mailbox.
So hopefully somebody shows up here.

Quoted 1 line
Signature · 7 lines
Best Regards,

Lisovskiy Stanislav
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#20 lore raw
Quoted 42 lines · Stanislav
Quoted 32 lines · Juha-Pekka Heikkilä

Lisovskiy, Stanislav kirjoitti 14.9.2018 klo 17.30:

Quoted 22 lines · Ville Syrjälä
Quoted 21 lines
Quoted 18 lines · Stanislav
Quoted 7 lines · Stanislav Lisovskiy

Introduced new XYUV scan-in format for framebuffer and added support for it to i915(SkyLake+).

Stanislav Lisovskiy (2):
drm: Introduce new DRM_FORMAT_XYUV
drm/i915: Adding YUV444 packed format support for skl+

Quoted 7 lines
   drivers/gpu/drm/drm_fourcc.c         |  1 +
   drivers/gpu/drm/i915/i915_reg.h      |  2 +-
   drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
   drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
   include/uapi/drm/drm_fourcc.h        |  1 +
   5 files changed, 20 insertions(+), 1 deletion(-)

Ping. There is an IGT patch which got Reviewed-by Ville. This one left in order to get XYUV support.

Quoted 7 lines
Quoted 4 lines

Did we figure out userspace for this?

Was the conflict solved with the other guy (forgot who it is) trying to add the same format with a different name?

Currently for userspace we have VLC(checked with Juha-Pekka) and also IGT test case.

Quoted 8 lines

Hei, no. VLC was *not* showing the mode correctly back then when we tested. VLC kms plugin is able to initialize the mode and it's all stable but VLC didn't have correct video converter to reach matching xYUV output. You remember Stan we tried to increase the recursion for
decoding in case it would help? VLC doesn't have codec which produce correct output, one of those xxx -> YUV plug-ins in VLC should be patched before VLC can be considered as userspace for this mode.

Quoted 5 lines

Ok, I remember we managed to make it work somehow and saw some picture, so for some reason I thought it is working already. What is our plan then? Should we try to improve VLC codecs/plugins or may be I should then work with some other user space case?

For VLC there are codecs which know about xYUV format but they seem to use it for input, I figure nobody so far needed it for output. If want to use VLC as userspace demo one of those codecs need to be patched up for outputting xYUV. As they already support many other YUV formats I wouldn't expect needed change to be significant on code level as KMS support is already in VLC.

Quoted 4 lines
Quoted 4 lines

/Juha-Pekka

Quoted 1 line
Quoted 13 lines
Quoted 5 lines
Quoted 5 lines

I think those guys were from ARM and they were adding also support for
XYUV. The only difference was that they called XYUV, like XYUV8888 something.
Our patches were otherwise identical regarding drm_fourcc.c part, I

Quoted 8 lines
Quoted 8 lines

don't see their stuff merged, but I guess it really shouldn't matter,
who does this first. i915 specific part doesn't conflict with their stuff. To be honest, I forgot the guy's name neither could find his email in my mailbox.
So hopefully somebody shows up here.

Quoted 1 line

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel