Skip to contentSkip to conversation

staging: tegra-video: fix V4L2 dependency

PATCH In review Arnd Bergmann 2 participants 2 messages May 27, 2020 – May 28, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: tegra-video: fix V4L2 dependency

Rather than using a dependency on VIDEO_V4L2, this driver uses "select", which fails when other dependencies are missing:

WARNING: unmet direct dependencies detected for VIDEO_V4L2
Depends on [n]: MEDIA_SUPPORT [=y] && (I2C [=y] || I2C [=y]=n) && VIDEO_DEV [=n] Selected by [y]:
- VIDEO_TEGRA [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && TEGRA_HOST1X [=y]
(plus an endless stream of link errors for other drivers that
depend on VIDEO_V4L2 but are now lacking their dependencies)

Fixes 3d8a97eabef0 ("media: tegra-video: Add Tegra210 Video input driver")
---
 drivers/staging/media/tegra-video/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/tegra-video/Kconfig +1 -1
index 3f03b5b39e6c..f6c61ec74386 100644
@@ -2,7 +2,7 @@
 config VIDEO_TEGRA
 	tristate "NVIDIA Tegra VI driver"
 	depends on TEGRA_HOST1X
-	select VIDEO_V4L2
+	depends on VIDEO_V4L2
 	select MEDIA_CONTROLLER
 	select VIDEOBUF2_DMA_CONTIG
 	help
Signature · 1 line
2.26.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 21 lines · Arnd Bergmann

Rather than using a dependency on VIDEO_V4L2, this driver uses "select", which fails when other dependencies are missing:

WARNING: unmet direct dependencies detected for VIDEO_V4L2
Depends on [n]: MEDIA_SUPPORT [=y] && (I2C [=y] || I2C [=y]=n) && VIDEO_DEV [=n] Selected by [y]:
- VIDEO_TEGRA [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && TEGRA_HOST1X [=y]
(plus an endless stream of link errors for other drivers that
depend on VIDEO_V4L2 but are now lacking their dependencies)

Fixes 3d8a97eabef0 ("media: tegra-video: Add Tegra210 Video input driver")
---
  drivers/staging/media/tegra-video/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/tegra-video/Kconfig +0 -0
index 3f03b5b39e6c..f6c61ec74386 100644

drivers/staging/media/tegra-video/Kconfig line 8

Quoted 8 lines
drivers/staging/media/tegra-video/Kconfig +1 -1
@@ -2,7 +2,7 @@
  config VIDEO_TEGRA
  	tristate "NVIDIA Tegra VI driver"
  	depends on TEGRA_HOST1X
-	select VIDEO_V4L2
+	depends on VIDEO_V4L2
  	select MEDIA_CONTROLLER
  	select VIDEOBUF2_DMA_CONTIG
  	help