Skip to contentSkip to conversation

scsi: qla2xxx: Use -EIO in qla_get_tmf()

PATCH In review Markus Elfring 2 participants 2 messages Apr 19, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: qla2xxx: Use -EIO in qla_get_tmf()

From: Markus Elfring <[email protected]>
Date: Fri, 19 Apr 2024 14:24:56 +0200

Add a minus sign before the error code “EIO” so that a negative value will eventually be returned as in another error case.

This issue was transformed by using the Coccinelle software.

---
 drivers/scsi/qla2xxx/qla_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_init.c +1 -1
index 8377624d76c9..8d93d9631ba3 100644
@@ -2281,7 +2281,7 @@ int qla_get_tmf(struct tmf_arg *arg)
 		if (TMF_NOT_READY(fcport)) {
 			ql_log(ql_log_warn, vha, 0x802c,
 			    "Unable to acquire TM resource due to disruption.\n");
-			rc = EIO;
+			rc = -EIO;
 			break;
 		}
 		if (ha->active_tmf < MAX_ACTIVE_TMF &&

--
2.44.0

#1 lore raw
Quoted 6 lines · Markus Elfring

From: Markus Elfring <[email protected]>
Date: Fri, 19 Apr 2024 14:24:56 +0200

Add a minus sign before the error code “EIO” so that a negative value will eventually be returned as in another error case.

No it won't. If you look how it's used the consumer doesn't pass on the error.

James