Skip to contentSkip to conversation

usb: dwc2: Fix memory leak in dwc2_hcd_init

PATCH In review Miaoqian Lin 2 participants 2 messages May 30, 2022 – Jun 2, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: dwc2: Fix memory leak in dwc2_hcd_init

usb_create_hcd will alloc memory for hcd, and we should call usb_put_hcd to free it when platform_get_resource() fails to prevent memory leak.
goto error2 label instead error1 to fix this.

Fixes 856e6e8e0f93 ("usb: dwc2: check return value after calling

platform_get_resource()")

---
 drivers/usb/dwc2/hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/dwc2/hcd.c +1 -1
index f63a27d11fac..3f107a06817d 100644
@@ -5190,7 +5190,7 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg)
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (!res) {
 		retval = -EINVAL;
-		goto error1;
+		goto error2;
 	}
 	hcd->rsrc_start = res->start;
 	hcd->rsrc_len = resource_size(res);
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Miaoqian Lin

usb_create_hcd will alloc memory for hcd, and we should call usb_put_hcd to free it when platform_get_resource() fails to prevent memory leak.
goto error2 label instead error1 to fix this.

Fixes 856e6e8e0f93 ("usb: dwc2: check return value after calling

platform_get_resource()")

Quoted 17 lines
---
  drivers/usb/dwc2/hcd.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/dwc2/hcd.c +1 -1
index f63a27d11fac..3f107a06817d 100644
@@ -5190,7 +5190,7 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg)
  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
  	if (!res) {
  		retval = -EINVAL;
-		goto error1;
+		goto error2;
  	}
  	hcd->rsrc_start = res->start;
  	hcd->rsrc_len = resource_size(res);