abi: change references to abi 20.0.1 to abi v21
Subsystems (3)
PATCH 1/1 abi: change references to abi 20.0.1 to abi v21
Change references to abi 20.0.1 to use abi v21.0, add myself as the map file maintainer to more closely monitor future abi changes.
--- MAINTAINERS | 2 ++ drivers/common/iavf/rte_common_iavf_version.map | 2 +- drivers/common/mlx5/rte_common_mlx5_version.map | 2 +- drivers/common/octeontx2/rte_common_octeontx2_version.map | 2 +- drivers/net/ionic/rte_pmd_ionic_version.map | 2 +- drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +- drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +- lib/librte_meter/rte_meter_version.map | 2 +- 8 files changed, 9 insertions(+), 7 deletions(-)
MAINTAINERS +2 -0
@@ -86,6 +86,8 @@ F: doc/ ABI Policy M: Ray Kinsella <[email protected]> F: doc/guides/contributing/abi_*.rst +F: drivers/*/*/*.map +F: lib/*/*.map Developers and Maintainers Tools M: Thomas Monjalon <[email protected]>
drivers/common/iavf/rte_common_iavf_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21.0 { global: iavf_init_adminq;
drivers/common/mlx5/rte_common_mlx5_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21.0 { global: mlx5_class_get;
drivers/common/octeontx2/rte_common_octeontx2_version.map +1 -1
@@ -34,7 +34,7 @@ DPDK_20.0 { local: *; }; -DPDK_20.0.1 { +DPDK_21.0 { global: otx2_eth_dev_is_sec_capable;
drivers/net/ionic/rte_pmd_ionic_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21.0 { local: *; };
drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21.0 { local: *; };
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map +1 -1
@@ -1,3 +1,3 @@ -DPDK_20.0.1 { +DPDK_21.0 { local: *; };
lib/librte_meter/rte_meter_version.map +1 -1
@@ -13,7 +13,7 @@ DPDK_20.0 { local: *; }; -DPDK_20.0.1 { +DPDK_21.0 { global: rte_meter_trtcm_rfc4115_color_aware_check;
Signature · 1 line
2.17.1
Travis ABI check warnings, can be safely ignored in this case, I think.
https://travis-ci.com/github/ovsrobot/dpdk/builds/161009923
Ray K
Quoted 104 lines · Ray Kinsella
Change references to abi 20.0.1 to use abi v21.0, add myself as the map file maintainer to more closely monitor future abi changes.
Signed-off-by Ray Kinsella <[email protected]>--- MAINTAINERS | 2 ++ drivers/common/iavf/rte_common_iavf_version.map | 2 +- drivers/common/mlx5/rte_common_mlx5_version.map | 2 +- drivers/common/octeontx2/rte_common_octeontx2_version.map | 2 +- drivers/net/ionic/rte_pmd_ionic_version.map | 2 +- drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +- drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +- lib/librte_meter/rte_meter_version.map | 2 +- 8 files changed, 9 insertions(+), 7 deletions(-)MAINTAINERS +2
-0@@ -86,6 +86,8 @@ F: doc/ ABI Policy M: Ray Kinsella <[email protected]> F: doc/guides/contributing/abi_*.rst +F: drivers/*/*/*.map +F: lib/*/*.map Developers and Maintainers Tools M: Thomas Monjalon <[email protected]>drivers/common/iavf/rte_common_iavf_version.map +1
-1@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21.0 { global: iavf_init_adminq;drivers/common/mlx5/rte_common_mlx5_version.map +1
-1@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21.0 { global: mlx5_class_get;drivers/common/octeontx2/rte_common_octeontx2_version.map +1
-1@@ -34,7 +34,7 @@ DPDK_20.0 { local: *; }; -DPDK_20.0.1 { +DPDK_21.0 { global: otx2_eth_dev_is_sec_capable;drivers/net/ionic/rte_pmd_ionic_version.map +1
-1@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21.0 { local: *; };drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map +1
-1@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21.0 { local: *; };drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map +1
-1@@ -1,3 +1,3 @@ -DPDK_20.0.1 { +DPDK_21.0 { local: *; };lib/librte_meter/rte_meter_version.map +1
-1@@ -13,7 +13,7 @@ DPDK_20.0 { local: *; }; -DPDK_20.0.1 { +DPDK_21.0 { global: rte_meter_trtcm_rfc4115_color_aware_check;
Quoted 4 lines · Ray Kinsella
Travis ABI check warnings, can be safely ignored in this case, I think.
How about comparing to 19.11 ABI then?
.travis.yml +1 -1
@@ -36,7 +36,7 @@ script: ./.ci/${TRAVIS_OS_NAME}-build.sh env: global: - - REF_GIT_TAG=v20.02 + - REF_GIT_TAG=v19.11 jobs: include:
Signature · 1 line
David Marchand
Quoted 7 lines · David Marchand
Quoted 4 lines · Ray Kinsella
Travis ABI check warnings, can be safely ignored in this case, I think.
How about comparing to 19.11 ABI then?
Theory is we should always be checking against v19.11 abi. So this _should_ be v19.11 ...
I will change in v2 and see what it throws up.
Quoted 14 lines
.travis.yml +1
-1@@ -36,7 +36,7 @@ script: ./.ci/${TRAVIS_OS_NAME}-build.sh env: global: - - REF_GIT_TAG=v20.02 + - REF_GIT_TAG=v19.11 jobs: include:
Concluded on separate thread it is best to leave this as v20.02.
Thanks,
Ray K
Quoted 22 lines · David Marchand
Quoted 4 lines · Ray Kinsella
Travis ABI check warnings, can be safely ignored in this case, I think.
How about comparing to 19.11 ABI then?
.travis.yml +1
-1@@ -36,7 +36,7 @@ script: ./.ci/${TRAVIS_OS_NAME}-build.sh env: global: - - REF_GIT_TAG=v20.02 + - REF_GIT_TAG=v19.11 jobs: include:
Quoted 2 lines · Ray Kinsella
Concluded on separate thread it is best to leave this as v20.02.
Ok, thanks for confirming.
Signature · 1 line
David Marchand
22/04/2020 10:07, Ray Kinsella:
Quoted 10 lines · David Marchand
Quoted 8 lines · Ray Kinsella
Quoted 4 lines
Travis ABI check warnings, can be safely ignored in this case, I think.
How about comparing to 19.11 ABI then?
Concluded on separate thread it is best to leave this as v20.02.
It means the ABI tool will be reporting a failure? The tool needs to reliably report zero false positive. How can we mitigate this issue?
Quoted 8 lines · Thomas Monjalon
22/04/2020 10:07, Ray Kinsella:
Quoted 7 lines · David Marchand
Quoted 6 lines · Ray Kinsella
Quoted 4 lines
Travis ABI check warnings, can be safely ignored in this case, I think.
Quoted 9 lines
Quoted 3 lines
Quoted 2 lines
How about comparing to 19.11 ABI then?
Concluded on separate thread it is best to leave this as v20.02.
It means the ABI tool will be reporting a failure? The tool needs to reliably report zero false positive. How can we mitigate this issue?
So I suggest we handle by adding
[suppress_function]
symbol_version = 20.0.1
[suppress_variable]
symbol_version = 20.0.1to libabigail.abignore.
libabigail will then ignore the removals?
Ray K
PATCH v2 1/1 abi: change references to abi 20.0.1 to abi v21
In reply to Ray KinsellaChange references to abi 20.0.1 to use abi v21, add myself as the map file maintainer to more closely monitor future abi changes. Add suppressions that were missed on changes to librte_lpm.
--- MAINTAINERS | 2 ++ devtools/libabigail.abignore | 13 ++++++++++++- drivers/common/iavf/rte_common_iavf_version.map | 2 +- drivers/common/mlx5/rte_common_mlx5_version.map | 2 +- .../octeontx2/rte_common_octeontx2_version.map | 2 +- drivers/net/ionic/rte_pmd_ionic_version.map | 2 +- .../rte_rawdev_octeontx2_ep_version.map | 2 +- drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +- lib/librte_meter/rte_meter_version.map | 2 +- 9 files changed, 21 insertions(+), 8 deletions(-)
MAINTAINERS +2 -0
@@ -86,6 +86,8 @@ F: doc/ ABI Policy M: Ray Kinsella <[email protected]> F: doc/guides/contributing/abi_*.rst +F: drivers/*/*/*.map +F: lib/*/*.map Developers and Maintainers Tools M: Thomas Monjalon <[email protected]>
devtools/libabigail.abignore +12 -1
@@ -2,7 +2,6 @@ symbol_version = EXPERIMENTAL [suppress_variable] symbol_version = EXPERIMENTAL - ; Explicit ignore for driver-only ABI [suppress_type] name = rte_cryptodev_ops
@@ -18,3 +17,15 @@ [suppress_type] type_kind = struct name = rte_event_ring +; Explicit ignore ABI 20.0.1 +[suppress_function] + symbol_version = DPDK_20.0.1 +[suppress_variable] + symbol_version = DPDK_20.0.1 +; Explicit ignore of const lpm6_lookup change +[suppress_function] + name = rte_lpm6_delete + parameter = '1 uint8_t* +[suppress_function] + name = rte_lpm6_is_rule_present + parameter = '1 uint8_t*
drivers/common/iavf/rte_common_iavf_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { global: iavf_init_adminq;
drivers/common/mlx5/rte_common_mlx5_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { global: mlx5_class_get;
drivers/common/octeontx2/rte_common_octeontx2_version.map +1 -1
@@ -34,7 +34,7 @@ DPDK_20.0 { local: *; }; -DPDK_20.0.1 { +DPDK_21 { global: otx2_eth_dev_is_sec_capable;
drivers/net/ionic/rte_pmd_ionic_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { local: *; };
drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { local: *; };
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map +1 -1
@@ -1,3 +1,3 @@ -DPDK_20.0.1 { +DPDK_21 { local: *; };
lib/librte_meter/rte_meter_version.map +1 -1
@@ -13,7 +13,7 @@ DPDK_20.0 { local: *; }; -DPDK_20.0.1 { +DPDK_21 { global: rte_meter_trtcm_rfc4115_color_aware_check;
Signature · 1 line
2.17.1
23/04/2020 08:41, Ray Kinsella:
Quoted 5 lines
Change references to abi 20.0.1 to use abi v21, add myself as the map file maintainer to more closely monitor future abi changes. Add suppressions that were missed on changes to
librte_lpm.Signed-off-by Ray Kinsella <[email protected]>
Please could you add a reference to the doc chapter stating this rule, in the commit log? Thanks
Quoted 4 lines · Ray Kinsella
Change references to abi 20.0.1 to use abi v21, add myself as the map file maintainer to more closely monitor future abi changes. Add suppressions that were missed on changes to
librte_lpm.
About the lpm change below, this might be because you are using an old version of libabigail.
I think the change went in:
$ git describe --contains 215b7eb4 libabigail-1.4~8
I use either libabigail 1.7 or the current master (when testing Dodji enhancements).
Quoted 28 lines
devtools/libabigail.abignore +12
-1@@ -2,7 +2,6 @@ symbol_version = EXPERIMENTAL [suppress_variable] symbol_version = EXPERIMENTAL - ; Explicit ignore for driver-only ABI [suppress_type] name = rte_cryptodev_ops@@ -18,3 +17,15 @@ [suppress_type] type_kind = struct name = rte_event_ring +; Explicit ignore ABI 20.0.1 +[suppress_function] + symbol_version = DPDK_20.0.1 +[suppress_variable] + symbol_version = DPDK_20.0.1 +; Explicit ignore of const lpm6_lookup change +[suppress_function] + name = rte_lpm6_delete + parameter = '1 uint8_t* +[suppress_function] + name = rte_lpm6_is_rule_present + parameter = '1 uint8_t*
Signature · 1 line
David Marchand
ah ok, the particular system I made the change on was Ubuntu 18.04.2. which is libabigail 1.2.0.
Given we still support v19.11 on Ubuntu 18.04.2.
I think it's worthwhile keeping the suppression until v20.11?
Ray K
Quoted 46 lines · David Marchand
Quoted 4 lines · Ray Kinsella
Change references to abi 20.0.1 to use abi v21, add myself as the map file maintainer to more closely monitor future abi changes. Add suppressions that were missed on changes to
librte_lpm.About the lpm change below, this might be because you are using an old version of libabigail.
I think the change went in:$ git describe --contains 215b7eb4 libabigail-1.4~8I use either libabigail 1.7 or the current master (when testing Dodji enhancements).
Quoted 28 lines
devtools/libabigail.abignore +12
-1@@ -2,7 +2,6 @@ symbol_version = EXPERIMENTAL [suppress_variable] symbol_version = EXPERIMENTAL - ; Explicit ignore for driver-only ABI [suppress_type] name = rte_cryptodev_ops@@ -18,3 +17,15 @@ [suppress_type] type_kind = struct name = rte_event_ring +; Explicit ignore ABI 20.0.1 +[suppress_function] + symbol_version = DPDK_20.0.1 +[suppress_variable] + symbol_version = DPDK_20.0.1 +; Explicit ignore of const lpm6_lookup change +[suppress_function] + name = rte_lpm6_delete + parameter = '1 uint8_t* +[suppress_function] + name = rte_lpm6_is_rule_present + parameter = '1 uint8_t*
Quoted 6 lines · Ray Kinsella
ah ok, the particular system I made the change on was Ubuntu 18.04.2. which is libabigail 1.2.0.
Given we still support v19.11 on Ubuntu 18.04.2.
I think it's worthwhile keeping the suppression until v20.11?
1.2 is fairly old and does not seem maintained by Ubuntu (asked for backport, and got ignored so far).
https://bugs.launchpad.net/ubuntu/+source/libabigail/+bug/1863607
Dodji told me that there were new checks added in newer sersions. I also fear that supporting an old libabigail version will force us to add a lot of other rules.
In Travis, we currently use libabigail 1.6 (mainly because I did not update to 1.7 when it was released).
Signature · 1 line
David Marchand
Hello,
Quoted 2 lines · Ray Kinsella
ah ok, the particular system I made the change on was Ubuntu 18.04.2. which is libabigail 1.2.0.
Whoah, 1.2 is super old.
In my opinion, one of the hallmarks of static analysis tools (and libabigail is just a static analysis framework) is to be able to recognize patterns used by developers, as much as we can.
Because we can't really do that at once, we try to add recognition of new patterns (of ABI changes) at every single release. Furthermore, there are some change patterns that ought to be recognized and categorized as harmless, whereas some others out to be categorized as harmful. That categorization is also the result of input coming from users as you, fine fellows.
All this to say that with every new version, the number of new supported features and bug fixes is potentially big.
To alleviate that, some distributors update libabigail even in their old stable distros, because the value of having an up to date version there outweighs the potential drawbacks.
Quoted 1 line
Given we still support v19.11 on Ubuntu 18.04.2.
So maybe that's a discussion worth having with the maintainer of the Ubuntu package of Libabigail?
Quoted 1 line
I think it's worthwhile keeping the suppression until v20.11?
[...]
Quoted 2 lines · David Marchand
In Travis, we currently use libabigail 1.6 (mainly because I did not update to 1.7 when it was released).
Right, that's probably another way to stay up to date independently from the underlying distribution.
I hope this helps,
Cheers,
Signature · 1 line
Dodji
Quoted 8 lines · Dodji Seketeli
Hello,
Quoted 2 lines · Ray Kinsella
ah ok, the particular system I made the change on was Ubuntu 18.04.2. which is libabigail 1.2.0.
Whoah, 1.2 is super old.
I have a huge clunking raid'ed "build" server,
that I am pretty conservative about upgrading on v18.04.2 :-)
Quoted 11 lines
In my opinion, one of the hallmarks of static analysis tools (and libabigail is just a static analysis framework) is to be able to recognize patterns used by developers, as much as we can.
Because we can't really do that at once, we try to add recognition of new patterns (of ABI changes) at every single release. Furthermore, there are some change patterns that ought to be recognized and categorized as harmless, whereas some others out to be categorized as harmful. That categorization is also the result of input coming from users as you, fine fellows.
Quoted 6 lines
All this to say that with every new version, the number of new supported features and bug fixes is potentially big.
To alleviate that, some distributors update libabigail even in their old stable distros, because the value of having an up to date version there outweighs the potential drawbacks.
Well it falls into the same category of problems of upgrading compilers. User's typically build their software build reliably on a given distro version. (or number of versions).
If the maintainer upgrades compilers between distro versions, it introduces new warnings and errors, and all hell will generally break loose, when the user least expects it. They typically expect that mayhem when upgrading to new distro versions.
Even tools like GNU indent can cause enormous problems.
I would imagine that most maintainers would be pretty conservative about making such changes.
Quoted 5 lines
Quoted 2 lines
Given we still support v19.11 on Ubuntu 18.04.2.
So maybe that's a discussion worth having with the maintainer of the Ubuntu package of Libabigail?
yes - I think it would be an interesting discussion alright.
I imagine the response might be inline with my understanding above. Let's find out - as we can expect v18.04 to be around for at least another two years I guess.
Another common way to handle this, is to be really explicit about what OS distros DPDK formally supports building on, which will then imply we support a small handful of versions of libabigail.
We then simply say we don't support 18.04 anymore - FD.io VPP are planning this formal switch at the moment.
Quoted 5 lines
Quoted 2 lines
I think it's worthwhile keeping the suppression until v20.11?
[...]
Quoted 7 lines
Quoted 2 lines · David Marchand
In Travis, we currently use libabigail 1.6 (mainly because I did not update to 1.7 when it was released).
Right, that's probably another way to stay up to date independently from the underlying distribution.
You typically don't want to encourage this, you end up with some people on a newer version, some people on an old version and never upgrading.
Then you never end up with a consistent view of what mitigations are actually required. Solving issues, becomes like a game of whack-a-mole.
Quoted 2 lines
I hope this helps,
It does, greatly thanks.
Quoted 3 lines
Cheers,
PATCH v3 1/1 abi: change references to abi 20.0.1 to abi v21
In reply to Ray Kinsellav3:
* Removed libabigail supressions in previous version.
* Clarified abi policy for only major abi versions in git commit.
Ray Kinsella (1):
abi: change references to abi 20.0.1 to abi v21
MAINTAINERS | 2 ++ drivers/common/iavf/rte_common_iavf_version.map | 2 +- drivers/common/mlx5/rte_common_mlx5_version.map | 2 +- drivers/common/octeontx2/rte_common_octeontx2_version.map | 2 +- drivers/net/ionic/rte_pmd_ionic_version.map | 2 +- drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +- drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +- lib/librte_meter/rte_meter_version.map | 2 +- 8 files changed, 9 insertions(+), 7 deletions(-)
--
2.7.4
PATCH v3 1/1 abi: change references to abi 20.0.1 to abi v21
Change references to abi 20.0.1 to use abi v21, see
https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines.
"Major ABI versions are declared no more frequently than yearly. Compatibility with the major ABI version is mandatory in subsequent releases until a new major ABI version is declared."
Add myself as the map file maintainer to more closely monitor future abi changes.
--- MAINTAINERS | 2 ++ drivers/common/iavf/rte_common_iavf_version.map | 2 +- drivers/common/mlx5/rte_common_mlx5_version.map | 2 +- drivers/common/octeontx2/rte_common_octeontx2_version.map | 2 +- drivers/net/ionic/rte_pmd_ionic_version.map | 2 +- drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +- drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +- lib/librte_meter/rte_meter_version.map | 2 +- 8 files changed, 9 insertions(+), 7 deletions(-)
MAINTAINERS +2 -0
@@ -86,6 +86,8 @@ F: doc/ ABI Policy M: Ray Kinsella <[email protected]> F: doc/guides/contributing/abi_*.rst +F: drivers/*/*/*.map +F: lib/*/*.map Developers and Maintainers Tools M: Thomas Monjalon <[email protected]>
drivers/common/iavf/rte_common_iavf_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { global: iavf_init_adminq;
drivers/common/mlx5/rte_common_mlx5_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { global: mlx5_class_get;
drivers/common/octeontx2/rte_common_octeontx2_version.map +1 -1
@@ -34,7 +34,7 @@ DPDK_20.0 { local: *; }; -DPDK_20.0.1 { +DPDK_21 { global: otx2_eth_dev_is_sec_capable;
drivers/net/ionic/rte_pmd_ionic_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { local: *; };
drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { local: *; };
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map +1 -1
@@ -1,3 +1,3 @@ -DPDK_20.0.1 { +DPDK_21 { local: *; };
lib/librte_meter/rte_meter_version.map +1 -1
@@ -13,7 +13,7 @@ DPDK_20.0 { local: *; }; -DPDK_20.0.1 { +DPDK_21 { global: rte_meter_trtcm_rfc4115_color_aware_check;
Signature · 1 line
2.7.4
PATCH v4 1/1 abi: change references to abi 20.0.1 to abi v21
In reply to Ray Kinsellav4:
* restored suppressions for v20.0.1 incorrectly removed in v3.
Ray Kinsella (1):
abi: change references to abi 20.0.1 to abi v21
MAINTAINERS | 2 ++ devtools/libabigail.abignore | 5 +++++ drivers/common/iavf/rte_common_iavf_version.map | 2 +- drivers/common/mlx5/rte_common_mlx5_version.map | 2 +- drivers/common/octeontx2/rte_common_octeontx2_version.map | 2 +- drivers/net/ionic/rte_pmd_ionic_version.map | 2 +- drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +- drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +- lib/librte_meter/rte_meter_version.map | 2 +- 9 files changed, 14 insertions(+), 7 deletions(-)
--
2.7.4
PATCH v4 1/1 abi: change references to abi 20.0.1 to abi v21
Change references to abi 20.0.1 to use abi v21, see
https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines.
"Major ABI versions are declared no more frequently than yearly. Compatibility with the major ABI version is mandatory in subsequent releases until a new major ABI version is declared."
Add myself as the map file maintainer to more closely monitor future abi changes.
--- MAINTAINERS | 2 ++ devtools/libabigail.abignore | 5 +++++ drivers/common/iavf/rte_common_iavf_version.map | 2 +- drivers/common/mlx5/rte_common_mlx5_version.map | 2 +- drivers/common/octeontx2/rte_common_octeontx2_version.map | 2 +- drivers/net/ionic/rte_pmd_ionic_version.map | 2 +- drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +- drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +- lib/librte_meter/rte_meter_version.map | 2 +- 9 files changed, 14 insertions(+), 7 deletions(-)
MAINTAINERS +2 -0
@@ -86,6 +86,8 @@ F: doc/ ABI Policy M: Ray Kinsella <[email protected]> F: doc/guides/contributing/abi_*.rst +F: drivers/*/*/*.map +F: lib/*/*.map Developers and Maintainers Tools M: Thomas Monjalon <[email protected]>
devtools/libabigail.abignore +5 -0
@@ -29,3 +29,8 @@ type_kind = enum name = rte_eth_event_type changed_enumerators = RTE_ETH_EVENT_MAX +; Explicit ignore ABI 20.0.1 +[suppress_function] + symbol_version = DPDK_20.0.1 +[suppress_variable] + symbol_version = DPDK_20.0.1
drivers/common/iavf/rte_common_iavf_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { global: iavf_init_adminq;
drivers/common/mlx5/rte_common_mlx5_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { global: mlx5_class_get;
drivers/common/octeontx2/rte_common_octeontx2_version.map +1 -1
@@ -34,7 +34,7 @@ DPDK_20.0 { local: *; }; -DPDK_20.0.1 { +DPDK_21 { global: otx2_eth_dev_is_sec_capable;
drivers/net/ionic/rte_pmd_ionic_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { local: *; };
drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { local: *; };
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map +1 -1
@@ -1,3 +1,3 @@ -DPDK_20.0.1 { +DPDK_21 { local: *; };
lib/librte_meter/rte_meter_version.map +1 -1
@@ -13,7 +13,7 @@ DPDK_20.0 { local: *; }; -DPDK_20.0.1 { +DPDK_21 { global: rte_meter_trtcm_rfc4115_color_aware_check;
Signature · 1 line
2.7.4
PATCH v5 1/1 abi: change references to abi 20.0.1 to abi v21
In reply to Ray KinsellaChange references to abi 20.0.1 to use abi v21, see
https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines
"Major ABI versions are declared no more frequently than yearly. Compatibility with the major ABI version is mandatory in subsequent releases until a new major ABI version is declared."
Combined abi policy and versioning in maintainers, add map files to the filter to more closely monitor future abi changes.
--- MAINTAINERS | 10 +++++----- devtools/libabigail.abignore | 5 +++++ drivers/common/iavf/rte_common_iavf_version.map | 2 +- drivers/common/mlx5/rte_common_mlx5_version.map | 2 +- .../common/octeontx2/rte_common_octeontx2_version.map | 2 +- drivers/net/ionic/rte_pmd_ionic_version.map | 2 +- .../octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +- drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +- lib/librte_meter/rte_meter_version.map | 2 +- 9 files changed, 17 insertions(+), 12 deletions(-)
MAINTAINERS +5 -5
@@ -83,10 +83,6 @@ M: Marko Kovacevic <[email protected]> F: README F: doc/ -ABI Policy -M: Ray Kinsella <[email protected]> -F: doc/guides/contributing/abi_*.rst - Developers and Maintainers Tools M: Thomas Monjalon <[email protected]> F: MAINTAINERS
@@ -140,10 +136,12 @@ M: Michael Santana <[email protected]> F: .travis.yml F: .ci/ -ABI versioning +ABI policy & versioning +M: Ray Kinsella <[email protected]> M: Neil Horman <[email protected]> F: lib/librte_eal/include/rte_compat.h F: lib/librte_eal/include/rte_function_versioning.h +F: doc/guides/contributing/abi_*.rst F: doc/guides/rel_notes/deprecation.rst F: devtools/check-abi.sh F: devtools/check-abi-version.sh
@@ -155,6 +153,8 @@ F: devtools/update_version_map_abi.py F: devtools/validate-abi.sh F: buildtools/check-symbols.sh F: buildtools/map-list-symbol.sh +F: drivers/*/*/*.map +F: lib/*/*.map Driver information M: Neil Horman <[email protected]>
devtools/libabigail.abignore +5 -0
@@ -29,3 +29,8 @@ type_kind = enum name = rte_eth_event_type changed_enumerators = RTE_ETH_EVENT_MAX +; Explicit ignore ABI 20.0.1 +[suppress_function] + symbol_version = DPDK_20.0.1 +[suppress_variable] + symbol_version = DPDK_20.0.1
drivers/common/iavf/rte_common_iavf_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { global: iavf_init_adminq;
drivers/common/mlx5/rte_common_mlx5_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { global: mlx5_class_get;
drivers/common/octeontx2/rte_common_octeontx2_version.map +1 -1
@@ -34,7 +34,7 @@ DPDK_20.0 { local: *; }; -DPDK_20.0.1 { +DPDK_21 { global: otx2_eth_dev_is_sec_capable;
drivers/net/ionic/rte_pmd_ionic_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { local: *; };
drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { local: *; };
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map +1 -1
@@ -1,3 +1,3 @@ -DPDK_20.0.1 { +DPDK_21 { local: *; };
lib/librte_meter/rte_meter_version.map +1 -1
@@ -13,7 +13,7 @@ DPDK_20.0 { local: *; }; -DPDK_20.0.1 { +DPDK_21 { global: rte_meter_trtcm_rfc4115_color_aware_check;
Signature · 1 line
2.23.0
PATCH v6 1/1 abi: change references to abi 20.0.1 to abi v21
In reply to Ray KinsellaSending again, as I missed the cover letter last time.
v6:
* combined policy and versioning in the maintainers file.
Ray Kinsella (1):
abi: change references to abi 20.0.1 to abi v21
MAINTAINERS | 10 +++++----- devtools/libabigail.abignore | 5 +++++ drivers/common/iavf/rte_common_iavf_version.map | 2 +- drivers/common/mlx5/rte_common_mlx5_version.map | 2 +- .../common/octeontx2/rte_common_octeontx2_version.map | 2 +- drivers/net/ionic/rte_pmd_ionic_version.map | 2 +- .../octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +- drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +- lib/librte_meter/rte_meter_version.map | 2 +- 9 files changed, 17 insertions(+), 12 deletions(-)
--
2.23.0
PATCH v6 1/1 abi: change references to abi 20.0.1 to abi v21
Change references to abi 20.0.1 to use abi v21, see
https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines
"Major ABI versions are declared no more frequently than yearly. Compatibility with the major ABI version is mandatory in subsequent releases until a new major ABI version is declared."
Combined abi policy and versioning in maintainers, add map files to the filter to more closely monitor future abi changes.
--- MAINTAINERS | 10 +++++----- devtools/libabigail.abignore | 5 +++++ drivers/common/iavf/rte_common_iavf_version.map | 2 +- drivers/common/mlx5/rte_common_mlx5_version.map | 2 +- .../common/octeontx2/rte_common_octeontx2_version.map | 2 +- drivers/net/ionic/rte_pmd_ionic_version.map | 2 +- .../octeontx2_ep/rte_rawdev_octeontx2_ep_version.map | 2 +- drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map | 2 +- lib/librte_meter/rte_meter_version.map | 2 +- 9 files changed, 17 insertions(+), 12 deletions(-)
MAINTAINERS +5 -5
@@ -83,10 +83,6 @@ M: Marko Kovacevic <[email protected]> F: README F: doc/ -ABI Policy -M: Ray Kinsella <[email protected]> -F: doc/guides/contributing/abi_*.rst - Developers and Maintainers Tools M: Thomas Monjalon <[email protected]> F: MAINTAINERS
@@ -140,10 +136,12 @@ M: Michael Santana <[email protected]> F: .travis.yml F: .ci/ -ABI versioning +ABI policy & versioning +M: Ray Kinsella <[email protected]> M: Neil Horman <[email protected]> F: lib/librte_eal/include/rte_compat.h F: lib/librte_eal/include/rte_function_versioning.h +F: doc/guides/contributing/abi_*.rst F: doc/guides/rel_notes/deprecation.rst F: devtools/check-abi.sh F: devtools/check-abi-version.sh
@@ -155,6 +153,8 @@ F: devtools/update_version_map_abi.py F: devtools/validate-abi.sh F: buildtools/check-symbols.sh F: buildtools/map-list-symbol.sh +F: drivers/*/*/*.map +F: lib/*/*.map Driver information M: Neil Horman <[email protected]>
devtools/libabigail.abignore +5 -0
@@ -29,3 +29,8 @@ type_kind = enum name = rte_eth_event_type changed_enumerators = RTE_ETH_EVENT_MAX +; Explicit ignore ABI 20.0.1 +[suppress_function] + symbol_version = DPDK_20.0.1 +[suppress_variable] + symbol_version = DPDK_20.0.1
drivers/common/iavf/rte_common_iavf_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { global: iavf_init_adminq;
drivers/common/mlx5/rte_common_mlx5_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { global: mlx5_class_get;
drivers/common/octeontx2/rte_common_octeontx2_version.map +1 -1
@@ -34,7 +34,7 @@ DPDK_20.0 { local: *; }; -DPDK_20.0.1 { +DPDK_21 { global: otx2_eth_dev_is_sec_capable;
drivers/net/ionic/rte_pmd_ionic_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { local: *; };
drivers/raw/octeontx2_ep/rte_rawdev_octeontx2_ep_version.map +1 -1
@@ -1,4 +1,4 @@ -DPDK_20.0.1 { +DPDK_21 { local: *; };
drivers/vdpa/mlx5/rte_pmd_mlx5_vdpa_version.map +1 -1
@@ -1,3 +1,3 @@ -DPDK_20.0.1 { +DPDK_21 { local: *; };
lib/librte_meter/rte_meter_version.map +1 -1
@@ -13,7 +13,7 @@ DPDK_20.0 { local: *; }; -DPDK_20.0.1 { +DPDK_21 { global: rte_meter_trtcm_rfc4115_color_aware_check;
Signature · 1 line
2.23.0
30/04/2020 12:27, Ray Kinsella:
Quoted 11 lines
Change references to abi 20.0.1 to use abi v21, see
https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines"Major ABI versions are declared no more frequently than yearly. Compatibility with the major ABI version is mandatory in subsequent releases until a new major ABI version is declared."
Combined abi policy and versioning in maintainers, add map files to the filter to more closely monitor future abi changes.
Signed-off-by Ray Kinsella <[email protected]>
Applied with added change for recent igc PMD:
drivers/net/igc/rte_pmd_igc_version.map +1 -1
@@ -1,3 +1,3 @@ -DPDK_20.0.2 { +DPDK_21 { local: *; };
30/04/2020 12:27, Ray Kinsella:
Quoted 1 line
Sending again, as I missed the cover letter last time.
You don't need a cover letter for a single patch.
The changelog can be added below --- in a patch.