Skip to contentSkip to conversation

perf record: Fix zomible status of child process

PATCH New desire 1 participant 1 message May 14, 2015 perf events

lore
Share & tools
lore

desire

author
#0 lore raw

PATCH 1/1 perf record: Fix zomible status of child process

If the child process exited between the following code, the child process will keep zomible status and perf process will keep "poll" forever
if (done || draining)

       break;
---//child process exit, done to 1
err = perf_evlist__poll(rec->evlist,-1);
so, change timeout to 1 second.
---
 tools/perf/builtin-record.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tools/perf/builtin-record.c +3 -1
index c3efdfb..0b242eb 100644
@@ -486,7 +486,9 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
 		if (hits == rec->samples) {
 			if (done || draining)
 				break;
-			err = perf_evlist__poll(rec->evlist, -1);
+			do{
+			err = perf_evlist__poll(rec->evlist, 1000);
+			}while((0 == err) && !done);
 			/*
 			 * Propagate error, only if there's any. Ignore positive
 			 * number of returned events and interrupt error.
Signature · 1 line
1.7.9.5