Skip to contentSkip to conversation

ACPI / video: disable native backlight for ThinkPad X201s

PATCH Applied Aaron Lu 2 participants 2 messages Sep 19, 2014 – Sep 22, 2014 ACPI

lore
Share & tools
lore

Aaron Lu

author
#0 lore raw

PATCH 1/1 ACPI / video: disable native backlight for ThinkPad X201s

The ThinkPad X201s has a working ACPI video backlight interface and is shipped before Win8; then there is BIOS update that starts to query _OSI("Windows 2012") and that would make our video module stop creating backlight interface and caused problem for the user. Add it to the DMI table to disable native backlight to fix this problem.

LINK https://bugzilla.kernel.org/show_bug.cgi?id=81691
LINK https://bugzilla.kernel.org/show_bug.cgi?id=51231
Cc 3.16+ <[email protected]> # 3.16+
Reported-and-tested-by Yves-Alexis Perez <[email protected]>
Signed-off-by Aaron Lu <[email protected]>
---
 drivers/acpi/video.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/acpi/video.c +8 -0
index fcbda105616e..8e7e18567ae6 100644
@@ -750,6 +750,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
 		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T520"),
 		},
 	},
+	{
+	 .callback = video_disable_native_backlight,
+	 .ident = "ThinkPad X201s",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X201s"),
+		},
+	},
 
 	/* The native backlight controls do not work on some older machines */
 	{
Signature · 1 line
1.9.3
Applied
#1 lore raw
Quoted 11 lines · Aaron Lu

The ThinkPad X201s has a working ACPI video backlight interface and is shipped before Win8; then there is BIOS update that starts to query _OSI("Windows 2012") and that would make our video module stop creating backlight interface and caused problem for the user. Add it to the DMI table to disable native backlight to fix this problem.

LINK https://bugzilla.kernel.org/show_bug.cgi?id=81691
LINK https://bugzilla.kernel.org/show_bug.cgi?id=51231
Cc 3.16+ <[email protected]> # 3.16+
Reported-and-tested-by Yves-Alexis Perez <[email protected]>
Signed-off-by Aaron Lu <[email protected]>

Queued up for 3.17-rc7, thanks!

Quoted 24 lines
---
 drivers/acpi/video.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/acpi/video.c +8 -0
index fcbda105616e..8e7e18567ae6 100644
@@ -750,6 +750,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
 		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T520"),
 		},
 	},
+	{
+	 .callback = video_disable_native_backlight,
+	 .ident = "ThinkPad X201s",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X201s"),
+		},
+	},
 
 	/* The native backlight controls do not work on some older machines */
 	{
Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.