Skip to contentSkip to conversation

sched/fair: fix boolreturn.cocci warning

PATCH New [email protected] 1 participant 1 message Jan 14, 2022 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched/fair: fix boolreturn.cocci warning

From: Yang Guang <[email protected]>

The coccinelle report ./kernel/sched/fair.c:9726:9-10:
WARNING: return of 0/1 in function 'imbalanced_active_balance' with return type bool

Return statements in functions returning bool should use true/false instead of 1/0.

---
 kernel/sched/fair.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/sched/fair.c +2 -2
index 095b0aa378df..354a36c1ab69 100644
@@ -9723,9 +9723,9 @@ imbalanced_active_balance(struct lb_env *env)
 	 */
 	if ((env->migration_type == migrate_task) &&
 	    (sd->nr_balance_failed > sd->cache_nice_tries+2))
-		return 1;
+		return true;
 
-	return 0;
+	return false;
 }
 
 static int need_active_balance(struct lb_env *env)
Signature · 1 line
2.30.2