Skip to contentSkip to conversation

n2100: reduce power button timer to 1 Hz

PATCH New Mikael Pettersson 3 participants 7 messages Sep 26, 2009 – Sep 28, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 n2100: reduce power button timer to 1 Hz

The power button on the n2100 apparently does not generate an interrupt when pressed, so the board support code sets up a periodic timer to sample it.

This timer operates at 10 Hz, which makes it the third worst cause of timeouts in my kernel when idle.

10 Hz seems excessive, so this patch adds a compile-time option to reduce the polling frequency to 1 Hz.

(This change could possibly be handled via a kernel boot option, or even be made unconditional, but I opted for a compile-time option for now.)

---
 arch/arm/mach-iop32x/Kconfig |   12 ++++++++++++
 arch/arm/mach-iop32x/n2100.c |   10 ++++++++--
 2 files changed, 20 insertions(+), 2 deletions(-)
arch/arm/mach-iop32x/Kconfig +12 -0
diff -rupN linux-2.6.31.arm-n2100-1-xint1-uart/arch/arm/mach-iop32x/Kconfig linux-2.6.31.arm-n2100-2-pbpt-hz1/arch/arm/mach-iop32x/Kconfig
@@ -64,4 +64,16 @@ config N2100_XINT1_UART
 
 	  Say Y if tickless operation is important for you.
 
+config N2100_PBPT_HZ1
+	bool "Set Thecus n2100 power button poll timer frequency to 1 Hz"
+	depends on MACH_N2100 && NO_HZ
+	help
+	  The Thecus n2100 power button does not generate an interrupt,
+	  so it is polled by a timer, by default at 10 Hz.
+
+	  This option reduces the polling frequency to 1 Hz, which helps
+	  tickless systems keep the timer interrupt rate low.
+
+	  Say Y if tickless operation is important for you.
+
 endif
arch/arm/mach-iop32x/n2100.c +8 -2
diff -rupN linux-2.6.31.arm-n2100-1-xint1-uart/arch/arm/mach-iop32x/n2100.c linux-2.6.31.arm-n2100-2-pbpt-hz1/arch/arm/mach-iop32x/n2100.c
@@ -307,6 +307,12 @@ static void n2100_power_off(void)
 
 static struct timer_list power_button_poll_timer;
 
+#ifdef CONFIG_N2100_PBPT_HZ1
+#define N2100_PBPT_DELTA	(HZ)
+#else
+#define N2100_PBPT_DELTA	(HZ / 10)
+#endif
+
 static void power_button_poll(unsigned long dummy)
 {
 	if (gpio_line_get(N2100_POWER_BUTTON) == 0) {
@@ -314,7 +320,7 @@ static void power_button_poll(unsigned l
 		return;
 	}
 
-	power_button_poll_timer.expires = jiffies + (HZ / 10);
+	power_button_poll_timer.expires = jiffies + N2100_PBPT_DELTA;
 	add_timer(&power_button_poll_timer);
 }
 
@@ -334,7 +340,7 @@ static void __init n2100_init_machine(vo
 
 	init_timer(&power_button_poll_timer);
 	power_button_poll_timer.function = power_button_poll;
-	power_button_poll_timer.expires = jiffies + (HZ / 10);
+	power_button_poll_timer.expires = jiffies + N2100_PBPT_DELTA;
 	add_timer(&power_button_poll_timer);
 }
 
#1 lore raw

PATCH 2/2 n2100: reduce power button timer to 1 Hz

Hello,

Quoted 6 lines · Mikael Pettersson

10 Hz seems excessive, so this patch adds a compile-time option to reduce the polling frequency to 1 Hz.

(This change could possibly be handled via a kernel boot option, or even be made unconditional, but I opted for a compile-time option for now.)

I don't think there is need to have an option for this. With HZ also round_jiffies() could be used, it doesn't need to be exact.

(I also think the code should check that the button is held down for a while before doing the shutdown, but that's a different issue.)

A.

#2 lore raw

PATCH 2/2 n2100: reduce power button timer to 1 Hz

Quoted 6 lines · Aaro Koskinen

Hello,

Quoted 3 lines · Mikael Pettersson

10 Hz seems excessive, so this patch adds a compile-time option to reduce the polling frequency to 1 Hz.

Quoted 6 lines
Quoted 3 lines

(This change could possibly be handled via a kernel boot option, or even be made unconditional, but I opted for a compile-time option for now.)

I don't think there is need to have an option for this. With HZ also round_jiffies() could be used, it doesn't need to be exact.

I don't quite follow you here. Can you elaborate?

#3 lore raw

PATCH 2/2 n2100: reduce power button timer to 1 Hz

Hello,

Quoted 5 lines · Mikael Pettersson
Quoted 4 lines · Aaro Koskinen
Quoted 3 lines · Mikael Pettersson

10 Hz seems excessive, so this patch adds a compile-time option to reduce the polling frequency to 1 Hz.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

(This change could possibly be handled via a kernel boot option, or even be made unconditional, but I opted for a compile-time option for now.)

I don't think there is need to have an option for this. With HZ also round_jiffies() could be used, it doesn't need to be exact.

I don't quite follow you here. Can you elaborate?

round_jiffies() rounds the time up or down to a full second. It's useful for timers that expire every N seconds. This way timeouts can be grouped, so there is less wakeups.

A.

#4 lore raw

PATCH 2/2 n2100: reduce power button timer to 1 Hz

Quoted 12 lines · Aaro Koskinen

Hello,

Quoted 9 lines · Mikael Pettersson
Quoted 8 lines · Aaro Koskinen
Quoted 6 lines · Mikael Pettersson

10 Hz seems excessive, so this patch adds a compile-time option to reduce the polling frequency to 1 Hz.

(This change could possibly be handled via a kernel boot option, or even be made unconditional, but I opted for a compile-time option for now.)

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

I don't think there is need to have an option for this. With HZ also round_jiffies() could be used, it doesn't need to be exact.

I don't quite follow you here. Can you elaborate?

round_jiffies() rounds the time up or down to a full second. It's useful for timers that expire every N seconds. This way timeouts can be grouped, so there is less wakeups.

Ah, the two sentences were not to be taken as a group:
1) no need for an option, i.e. reduce to 1 Hz unconditionally, and
2) with a 1 Hz timer, use round_jiffies() in the hope of grouping with other whole-Hz timers that also use round_jiffies().

I'll look into using round_jiffies().

#5 lore raw

PATCH 2/2 n2100: reduce power button timer to 1 Hz

In reply to Mikael Pettersson
Quoted 9 lines · Mikael Pettersson

The power button on the n2100 apparently does not generate an interrupt when pressed, so the board support code sets up a periodic timer to sample it.

This timer operates at 10 Hz, which makes it the third worst cause of timeouts in my kernel when idle.

10 Hz seems excessive, so this patch adds a compile-time option to reduce the polling frequency to 1 Hz.

How much power does this actually save?

#6 lore raw

PATCH 2/2 n2100: reduce power button timer to 1 Hz

Quoted 6 lines · Lennert Buytenhek
Quoted 4 lines · Mikael Pettersson

The power button on the n2100 apparently does not generate an interrupt when pressed, so the board support code sets up a periodic timer to sample it.

Quoted 7 lines
Quoted 5 lines

This timer operates at 10 Hz, which makes it the third worst cause of timeouts in my kernel when idle.

10 Hz seems excessive, so this patch adds a compile-time option to reduce the polling frequency to 1 Hz.

How much power does this actually save?

I have no way of measuring that, unfortunately.