Skip to contentSkip to conversation

NFS client ignores server preferred IO size when 'ascii' mount options used.

PATCH New Neil Brown 1 participant 1 message Oct 29, 2009

Subsystems (2)
lore
Share & tools
lore

Neil Brown

author
#0 lore raw

PATCH 1/1 NFS client ignores server preferred IO size when 'ascii' mount options used.

Hi Trond et al,

I just had a report from a customer that NFS (SLES11) was ignoring the rsize/wsize set by the server.

A quick inspection of the code (in current upstream) shows that this is indeed the case.

nfs_get_sb calls nfs_alloc_parsed_mount_data which set rsize and wsize in 'data' to NFS_MAX_FILE_IO_SIZE (which is not zero).

It then calls nfs_validate_mount_data which will over-write this valid if 'binary' mount options are in use, but with ascii mount options, the values will only be changed in rsize and/or wsize is explicitly listed.

So in the common case of ascii mount options and no rsize/wsize, they remain at NFS_MAX_FILE_IO_SIZE.

Then nfs_get_sb calls nfs_create_server which calls nfs_init_server which copies the rsize and rsize (being non-zero) across from 'data' to 'server' (clipping to NFS_{MIN,MAX}_FILE_IO_SIZE).

Then nfs_create_server calls nfs_probe_fsinfo which calls nfs_server_set_fsinfo which sets ->rsize to fsinfo->rtpref only if ->rsize is zero. But it isn't, it is NFS_MAX_FILE_IO_SIZE. So the ->rtpref and ->wtpref are ignored when they should be used.

I suspect the required patch will be something like the following though I haven't tested it yet (it is late:-).
There should probably be a comment in there pointing out that these values get their defaults from fsinfo.
I also have only looked at the v3 path, not the v4 path.

But I thought I'd let you know promptly as I'm not sure when I'll get around to proper testing.

NeilBrown

fs/nfs/super.c +2 -2
index 90be551..18c5f85 100644
@@ -734,8 +734,8 @@ static struct nfs_parsed_mount_data *nfs_alloc_parsed_mount_data(unsigned int ve
 
 	data = kzalloc(sizeof(*data), GFP_KERNEL);
 	if (data) {
-		data->rsize		= NFS_MAX_FILE_IO_SIZE;
-		data->wsize		= NFS_MAX_FILE_IO_SIZE;
+		data->rsize		= 0;
+		data->wsize		= 0;
 		data->acregmin		= NFS_DEF_ACREGMIN;
 		data->acregmax		= NFS_DEF_ACREGMAX;
 		data->acdirmin		= NFS_DEF_ACDIRMIN;