Skip to contentSkip to conversation

libxl: build fix

PATCH In review Christoph Egger 2 participants 2 messages Dec 1, 2009 – Dec 4, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libxl: build fix

Hi!

Attached patch makes libxl build on NetBSD.

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
tools/libxl/libxl_exec.c +1 -0
diff -r 030589859a8f tools/libxl/libxl_exec.c
@@ -25,6 +25,7 @@
 #include <assert.h>
 #include <sys/types.h>
 #include <sys/wait.h>
+#include <signal.h> /* for SIGKILL */
 
 #include "libxl.h"
 #include "libxl_internal.h"

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw

Christoph Egger writes ("[Xen-devel] [PATCH] libxl: build fix"):

Quoted 1 line

Attached patch makes libxl build on NetBSD.

The patch is fine, although I don't generally approve of comments like the one you've included:

+#include <signal.h> /* for SIGKILL */

I would just say:

+#include <signal.h>

and you can mention SIGKILL in the commit message.

There is an argument that all of these headers should be included in one place by libxl_internal.h.

Ian.