btrfs-tools Makefile: remove duplicated '-o $@' option from CC cmdline for libbtrfsutil/ subfolder
PATCH 1/1 btrfs-tools Makefile: remove duplicated '-o $@' option from CC cmdline for libbtrfsutil/ subfolder
Command line for target "libbtrfsutil/%.o" contained double usage of '-o $@' option and causes compilation error:
cc1: error: too many filenames given
---
...01-Makefile-fix-double-o-compiler-option-using.patch | 17 +++++++++++++++++ meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb | 1 +
2 files changed, 18 insertions(+)
create mode 100644 meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch
meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-dou$ renamed from meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch +0 -0
le-o-compiler-option-using.patch
new file mode 100644
index 0000000000..335067bc1f
meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch new file +17 -0
@@ -0,0 +1,17 @@ +Command line for target "libbtrfsutil/%.o" contained double usage + of '-o $@' option and caused error: + cc1: error: too many filenames given + +Index: git/Makefile +=================================================================== +--- git.orig/Makefile ++++ git/Makefile +@@ -414,7 +414,7 @@ libbtrfs.so.0 libbtrfs.so: libbtrfs.so.0 + + libbtrfsutil/%.o: libbtrfsutil/%.c + @echo " [CC] $@" +- $(Q)$(CC) $(LIBBTRFSUTIL_CFLAGS) -o $@ -c $< -o $@ ++ $(Q)$(CC) $(LIBBTRFSUTIL_CFLAGS) -c $< -o $@ + + libbtrfsutil.so.$(libbtrfsutil_version): $(libbtrfsutil_objects) + @echo " [LD] $@"
meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb +0 -0
@@ -19,6 +19,7 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git \
file://0001-Makefile-build-mktables-using-native-gcc.patch \
file://0001-Add-LDFLAGS-when-building-libbtrfsutil.so.patch \
file://0001-Add-a-possibility-to-specify-where-python-modules-ar.patch \
+ file://0001-Makefile-fix-double-o-compiler-option-using.patch \
"
inherit autotools-brokensep pkgconfig manpages distutils3-base
Signature · 1 line
2.14.1
Please don't send patches in HTML [1]. The patch you add is also missing a Signed-off-by and Upstream-Status [2] For such a trivial build issue, we encourage submitting the patch upstream too so we don't have to carry it forever.
[1] https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
[2] https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Quoted 56 lines · Ivan Efimov
Command line for target "libbtrfsutil/%.o" contained double usage of '-o $@' option and causes compilation error:
cc1: error: too many filenames given
Signed-off-by Ivan Efimov <[email protected]>--- ...01-Makefile-fix-double-o-compiler-option-using.patch | 17 +++++++++++++++++ meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb | 1 + 2 files changed, 18 insertions(+) create mode 100644 meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patchmeta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-dou$ renamed from meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch +0
-0le-o-compiler-option-using.patch
new file mode 100644
index 0000000000..335067bc1fmeta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch new file +17
-0@@ -0,0 +1,17 @@ +Command line for target "libbtrfsutil/%.o" contained double usage + of '-o $@' option and caused error: + cc1: error: too many filenames given + +Index: git/Makefile +=================================================================== +--- git.orig/Makefile ++++ git/Makefile +@@ -414,7 +414,7 @@ libbtrfs.so.0 libbtrfs.so: libbtrfs.so.0 + + libbtrfsutil/%.o: libbtrfsutil/%.c + @echo " [CC] $@" +- $(Q)$(CC) $(LIBBTRFSUTIL_CFLAGS) -o $@ -c $< -o $@ ++ $(Q)$(CC) $(LIBBTRFSUTIL_CFLAGS) -c $< -o $@ + + libbtrfsutil.so.$(libbtrfsutil_version): $(libbtrfsutil_objects) + @echo " [LD] $@"meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb +1
-1@@ -19,6 +19,7 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git \ file://0001-Makefile-build-mktables-using-native-gcc.patch \ file://0001-Add-LDFLAGS-when-building-libbtrfsutil.so.patch \ file://0001-Add-a-possibility-to-specify-where-python-modules-ar.patch \ + file://0001-Makefile-fix-double-o-compiler-option-using.patch \ " inherit autotools-brokensep pkgconfig manpages distutils3-base --2.14.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Thank you for info about https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
I mistakenly followed guide https://wiki.yoctoproject.org/wiki/Poky_Contributions.
Best regards,
Ivan
----- Original Message -----
From: "Ross Burton" <[email protected]>
To: "Ivan Efimov" <[email protected]>
Cc: "OE-core" <[email protected]>
Sent: Monday, February 25, 2019 4:24:24 PM
Subject: Re: [OE-core] [PATCH] btrfs-tools Makefile: remove duplicated '-o $@' option from CC cmdline for libbtrfsutil/ subfolder
Please don't send patches in HTML [1]. The patch you add is also missing a Signed-off-by and Upstream-Status [2] For such a trivial build issue, we encourage submitting the patch upstream too so we don't have to carry it forever.
[1] https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
[2] https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Quoted 56 lines · Ivan Efimov
Command line for target "libbtrfsutil/%.o" contained double usage of '-o $@' option and causes compilation error:
cc1: error: too many filenames given
Signed-off-by Ivan Efimov <[email protected]>--- ...01-Makefile-fix-double-o-compiler-option-using.patch | 17 +++++++++++++++++ meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb | 1 + 2 files changed, 18 insertions(+) create mode 100644 meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patchmeta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-dou$ renamed from meta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch +0
-0le-o-compiler-option-using.patch
new file mode 100644
index 0000000000..335067bc1fmeta/recipes-devtools/btrfs-tools/btrfs-tools/0001-Makefile-fix-double-o-compiler-option-using.patch new file +17
-0@@ -0,0 +1,17 @@ +Command line for target "libbtrfsutil/%.o" contained double usage + of '-o $@' option and caused error: + cc1: error: too many filenames given + +Index: git/Makefile +=================================================================== +--- git.orig/Makefile ++++ git/Makefile +@@ -414,7 +414,7 @@ libbtrfs.so.0 libbtrfs.so: libbtrfs.so.0 + + libbtrfsutil/%.o: libbtrfsutil/%.c + @echo " [CC] $@" +- $(Q)$(CC) $(LIBBTRFSUTIL_CFLAGS) -o $@ -c $< -o $@ ++ $(Q)$(CC) $(LIBBTRFSUTIL_CFLAGS) -c $< -o $@ + + libbtrfsutil.so.$(libbtrfsutil_version): $(libbtrfsutil_objects) + @echo " [LD] $@"meta/recipes-devtools/btrfs-tools/btrfs-tools_4.20.1.bb +1
-1@@ -19,6 +19,7 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git \ file://0001-Makefile-build-mktables-using-native-gcc.patch \ file://0001-Add-LDFLAGS-when-building-libbtrfsutil.so.patch \ file://0001-Add-a-possibility-to-specify-where-python-modules-ar.patch \ + file://0001-Makefile-fix-double-o-compiler-option-using.patch \ " inherit autotools-brokensep pkgconfig manpages distutils3-base --2.14.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 6 lines
[ https://inango.com/ | ] Ivan Efimov Architect, Arch Group [email protected] T +7 343 298 0147 C +7 904 9 888 350 [ https://inango.com/ | inango.com ] [ https://www.linkedin.com/company/inango ]