Skip to contentSkip to conversation

AIC7xxx driver build failure

PATCH Inaky Perez-Gonzalez 3 participants 5 messages Oct 20, 2002 – Nov 20, 2002

lore
Share & tools
lore
#0 lore raw

The AIC 7xxx driver fails to build because the Makefile fails to specify the correct include path to aicasm.

Justin, are you getting this?

This patch is against 2.5.44.

scsi/aic7xxx/Makefile renamed from scsi/aic7xxx/Makefile:1.1.1.2 +1 -1
diff -u drivers/scsi/aic7xxx/Makefile:1.1.1.2 drivers/scsi/aic7xxx/Makefile:1.1.1.1.4.2
@@ -39,7 +39,7 @@
 
 $(obj)/aic7xxx_seq.h: $(src)/aic7xxx.seq $(src)/aic7xxx.reg \
 		      $(obj)/aicasm/aicasm
-	$(obj)/aicasm/aicasm -I. -r $(obj)/aic7xxx_reg.h \
+	$(obj)/aicasm/aicasm -I$(obj) -r $(obj)/aic7xxx_reg.h \
 				 -o $(obj)/aic7xxx_seq.h $(src)/aic7xxx.seq
 
 $(obj)/aic7xxx_reg.h: $(obj)/aix7xxx_seq.h
Signature · 1 line
Inaky Perez-Gonzalez -- Not speaking for Intel - opinions are my own [or my fault]
#1 lore raw
Quoted 4 lines

The AIC 7xxx driver fails to build because the Makefile fails to specify the correct include path to aicasm.

Justin, are you getting this?

No, because this bug doesn't exist in the latest version of the driver in my tree or the last set of patches I sent to Linus (a month ago??).

--
Justin

#2 lore raw
Quoted 7 lines · Justin T. Gibbs
Quoted 4 lines

The AIC 7xxx driver fails to build because the Makefile fails to specify the correct include path to aicasm.

Justin, are you getting this?

No, because this bug doesn't exist in the latest version of the driver in my tree or the last set of patches I sent to Linus (a month ago??).

Care to send me the stuff Linus has dropped ?

#3 lore raw
Quoted 10 lines · Justin T. Gibbs
Quoted 7 lines
Quoted 4 lines

The AIC 7xxx driver fails to build because the Makefile fails to specify the correct include path to aicasm.

Justin, are you getting this?

No, because this bug doesn't exist in the latest version of the driver in my tree or the last set of patches I sent to Linus (a month ago??).

Care to send me the stuff Linus has dropped ?

I will send a new driver update as soon as our internal testing of the latest aic7xxx and aic79xx drivers has been completed. Since this new version adds Domain Validation, it will be a little bit. The last version I sent to Linus, which were cut before for the recent queue depth API change, can be found here:

http://people.FreeBSD.org/~gibbs/linux/linux-2.5-aic79xxx.tar.gz

--
Justin

#4 lore raw
In reply to Alan Cox
Quoted 10 lines · Justin T. Gibbs
Quoted 7 lines
Quoted 4 lines

The AIC 7xxx driver fails to build because the Makefile fails to specify the correct include path to aicasm.

Justin, are you getting this?

No, because this bug doesn't exist in the latest version of the driver in my tree or the last set of patches I sent to Linus (a month ago??).

Care to send me the stuff Linus has dropped ?

Updated aic7xxx and aic79xx drivers for 2.4 and 2.5 can be found here:

http://people.FreeBSD.org/~gibbs/linux/tarballs

Notable changes:

o Both drivers support Domain Validation
o Memory mapped I/O is now a config option
o New memory mapped I/O register test that will hopefully weed out broken VIA chipsets
o The reboot notifier hook has been disabled. The driver wants to shut itself down prior to reboot, but the reboot notifier is now called too early in 2.5.X for this to be effective. It looks like it might be possible for the driver to grow a device shutdown routine, but it was not obvious with a quick look at this new feature how to ensure that the [sd, sr, etc.] driver's shutdown routines would be called prior to the aic7xxx driver's routine. Some guidance in this area would be appreciated.
o Tag depth changes are now communicated to the midlayer.

--
Justin