pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes
Subsystems (2)
PATCH 1/1 pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes
It seems to be a typo
--- drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bonding/rte_eth_bond_pmd.c +1 -1
@@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev)if (internals->slaves[i].port_id == internals->current_primary_port) {if (rte_eth_dev_default_mac_addr_set ( - internals->primary_port, + internals->current_primary_port, bonded_eth_dev->data->mac_addrs)) {RTE_BOND_LOG (ERR ,"Failed to update port Id %d MAC address" , internals->current_primary_port);
Signature · 1 line
2.17.1
Yes, this does look like a typo on someone's part.
Please change use net/bonding: instead of pmd_bond:
Please add a Fixes: line
Please add a Cc: [email protected]
Quoted 21 lines · Sergey Lvov
It seems to be a typo
Signed-off-by Sergey Lvov <[email protected]>--- drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/bonding/rte_eth_bond_pmd.c +1
-1@@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev)if (internals->slaves[i].port_id == internals->current_primary_port) {if (rte_eth_dev_default_mac_addr_set ( - internals->primary_port, + internals->current_primary_port, bonded_eth_dev->data->mac_addrs)) {RTE_BOND_LOG (ERR ,"Failed to update port Id %d MAC address" , internals->current_primary_port);
Hi, Chas Williams & Sergey Lvov
There was a two-patch series about bonding those are still in reviewing state,
and the one of them includes the identical modification. Thanks.
http://patches.dpdk.org/patch/68742/
The series include two patches:
http://patches.dpdk.org/patch/68742/
http://patches.dpdk.org/patch/68743/
Best Regards
Xavier
Quoted 32 lines · Chas Williams
Yes, this does look like a typo on someone's part.
Please change use net/bonding: instead of
pmd_bond:
Please add a Fixes: line
Please add a Cc: [email protected]Review
Quoted 8 lines · Sergey Lvov
It seems to be a typo
Signed-off-by Sergey Lvov <[email protected]>--- drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/net/bonding/rte_eth_bond_pmd.cdrivers/net/bonding/rte_eth_bond_pmd.c mac_address_slaves_update(struct rte_eth_dev
Quoted 4 lines
index
612a64599..3ef0df84a100644drivers/net/bonding/rte_eth_bond_pmd.c +0
-0@@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev
*bonded_eth_dev)drivers/net/bonding/rte_eth_bond_pmd.c mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev)
Quoted 7 lines
drivers/net/bonding/rte_eth_bond_pmd.c +1
-1if (internals->slaves[i].port_id == internals->current_primary_port) {if (rte_eth_dev_default_mac_addr_set ( - internals->primary_port, + internals->current_primary_port, bonded_eth_dev->data->mac_addrs)) { RTE_BOND_LOG(ERR, "Failed to update port Id %dMAC address",
Quoted 2 lines
drivers/net/bonding/rte_eth_bond_pmd.c +0
-0internals->current_primary_port);
Hi, Sergey Lvov
There was a two-patch series about bonding those are still in reviewing state,
and the one of them includes the identical modification.
http://patches.dpdk.org/patch/68742/
Would you like to review it and give 'Signed-off-by' on the patch if there are no object?
Thanks, Xavier
Quoted 51 lines · Wei Hu (Xavier)
Hi, Chas Williams & Sergey Lvov
There was a two-patch series about bonding those are still in reviewing state,
and the one of them includes the identical modification. Thanks.
http://patches.dpdk.org/patch/68742/
The series include two patches:
http://patches.dpdk.org/patch/68742/
http://patches.dpdk.org/patch/68743/Best Regards
XavierQuoted 32 lines · Chas Williams
Yes, this does look like a typo on someone's part.
Please change use net/bonding: instead of
pmd_bond:
Please add a Fixes: line
Please add a Cc: [email protected]Review
Quoted 8 lines · Sergey Lvov
It seems to be a typo
Signed-off-by Sergey Lvov <[email protected]>--- drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/net/bonding/rte_eth_bond_pmd.cdrivers/net/bonding/rte_eth_bond_pmd.c mac_address_slaves_update(struct rte_eth_dev
Quoted 4 lines
index
612a64599..3ef0df84a100644drivers/net/bonding/rte_eth_bond_pmd.c +0
-0@@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev
*bonded_eth_dev)drivers/net/bonding/rte_eth_bond_pmd.c mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev)
Quoted 7 lines
drivers/net/bonding/rte_eth_bond_pmd.c +1
-1if (internals->slaves[i].port_id == internals->current_primary_port) {if (rte_eth_dev_default_mac_addr_set ( - internals->primary_port, + internals->current_primary_port, bonded_eth_dev->data->mac_addrs)) { RTE_BOND_LOG(ERR, "Failed to update port Id%d MAC address",
Quoted 2 lines
drivers/net/bonding/rte_eth_bond_pmd.c +0
-0internals->current_primary_port);
Hi, Sergey Lvov
Thanks for you reporting issues,
The identical modification had been applied to dpdk-next-net.
http://patches.dpdk.org/patch/68742/
repo: http://dpdk.org/git/next/dpdk-next-net
f109ce2c5c6b114f533ffcb69460385ac04db215
net/bonding: fix MAC address when switching active port
Could you like to 'Signed-off-by' on the patch if there are no object?
Thanks, Xavier
Quoted 68 lines · Wei Hu (Xavier)
Hi, Sergey Lvov
There was a two-patch series about bonding those are still in reviewing state,
and the one of them includes the identical modification.
http://patches.dpdk.org/patch/68742/
Would you like to review it and give 'Signed-off-by' on the patch if there are no object?
Thanks, Xavier
Quoted 51 lines · Wei Hu (Xavier)
Hi, Chas Williams & Sergey Lvov
There was a two-patch series about bonding those are still in reviewing state,
and the one of them includes the identical modification. Thanks.
http://patches.dpdk.org/patch/68742/
The series include two patches:
http://patches.dpdk.org/patch/68742/
http://patches.dpdk.org/patch/68743/Best Regards
XavierQuoted 32 lines · Chas Williams
Yes, this does look like a typo on someone's part.
Please change use net/bonding: instead of
pmd_bond:
Please add a Fixes: line
Please add a Cc: [email protected]Review
Quoted 8 lines · Sergey Lvov
It seems to be a typo
Signed-off-by Sergey Lvov <[email protected]>--- drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/net/bonding/rte_eth_bond_pmd.cdrivers/net/bonding/rte_eth_bond_pmd.c mac_address_slaves_update(struct rte_eth_dev
Quoted 4 lines
index
612a64599..3ef0df84a100644drivers/net/bonding/rte_eth_bond_pmd.c +0
-0@@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev
*bonded_eth_dev)drivers/net/bonding/rte_eth_bond_pmd.c mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev)
Quoted 7 lines
drivers/net/bonding/rte_eth_bond_pmd.c +1
-1if (internals->slaves[i].port_id == internals->current_primary_port) {if (rte_eth_dev_default_mac_addr_set ( - internals->primary_port, + internals->current_primary_port, bonded_eth_dev->data->mac_addrs)) { RTE_BOND_LOG(ERR, "Failed to update port Id%d MAC address",
Quoted 2 lines
drivers/net/bonding/rte_eth_bond_pmd.c +0
-0internals->current_primary_port);