Skip to contentSkip to conversation

gfs2: removed unnecessary semicolon

PATCH In review [email protected] 2 participants 3 messages Oct 2, 2019 – Oct 4, 2019 GFS2 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gfs2: removed unnecessary semicolon

From: Aliasgar Surti <[email protected]>

There is use of unnecessary semicolon after switch case. Removed the semicolon.

---
 fs/gfs2/recovery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/gfs2/recovery.c +1 -1
index c529f8749a89..f4aa8551277b 100644
@@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work)
 
 		default:
 			goto fail;
-		};
+		}
 
 		error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED,
 					   LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh);
Signature · 1 line
2.17.1
#1 lore raw

----- Original Message -----

Quoted 24 lines

From: Aliasgar Surti <[email protected]>

There is use of unnecessary semicolon after switch case. Removed the semicolon.

---
 fs/gfs2/recovery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/gfs2/recovery.c +1 -2
index c529f8749a89..f4aa8551277b 100644
@@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work)
 
 		default:
 			goto fail;
-		};
+		}
 
 		error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED,
 					   LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh);
--
Quoted 1 line

2.17.1

Hi,

Thanks for the patch. I did a quick search and found two more:

glops.c- break;
glops.c: };

inode.c- goto out_gunlock;
inode.c: };

Do you want to include those in your patch and re-submit it or should I cook up a second patch?

Regards,

Bob Peterson
Red Hat File Systems

#2 lore raw

----- Original Message -----

Quoted 31 lines

----- Original Message -----

Quoted 24 lines

From: Aliasgar Surti <[email protected]>

There is use of unnecessary semicolon after switch case. Removed the semicolon.

---
 fs/gfs2/recovery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/gfs2/recovery.c +1 -2
index c529f8749a89..f4aa8551277b 100644
@@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work)
 
 		default:
 			goto fail;
-		};
+		}
 
 		error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED,
 					   LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh);
--
Quoted 1 line

2.17.1

Hi,

Thanks for the patch. I did a quick search and found two more:

Quoted 8 lines

glops.c- break;
glops.c: };

inode.c- goto out_gunlock;
inode.c: };

Do you want to include those in your patch and re-submit it or should I cook up a second patch?

Hi,

I just went ahead and added the two above to your patch and pushed it to for-next. Thanks.

Regards,

Bob Peterson