Skip to contentSkip to conversation

ASoC: fsl: fix dependencies for wm8962

PATCH In review Arnd Bergmann 4 participants 11 messages Sep 30, 2014 – Oct 1, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: fsl: fix dependencies for wm8962

The wm8962 driver uses the input subsystem, but is selected by SND_SOC_FSL_ASOC_CARD, which can be built with CONFIG_INPUT disabled, resulting in this link error:

ERROR: "input_event" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!
ERROR: "input_register_device" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!
ERROR: "devm_input_allocate_device" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!

This adds an explicit Kconfig dependency to prevent this configuration from being used.

Fixes 708b4351f08 ("ASoC: fsl: Add Freescale Generic ASoC Sound Card with ASRC support")
sound/soc/fsl/Kconfig +1 -1
index 6164e78b466a..99e9386f7956 100644
@@ -282,7 +282,7 @@ config SND_SOC_IMX_MC13783
 
 config SND_SOC_FSL_ASOC_CARD
 	tristate "Generic ASoC Sound Card with ASRC support"
-	depends on OF && I2C
+	depends on OF && I2C && INPUT
 	select SND_SOC_IMX_AUDMUX
 	select SND_SOC_IMX_PCM_DMA
 	select SND_SOC_FSL_ESAI
maintainer
#1 lore raw
Quoted 3 lines · Arnd Bergmann

The wm8962 driver uses the input subsystem, but is selected by SND_SOC_FSL_ASOC_CARD, which can be built with CONFIG_INPUT disabled, resulting in this link error:

That select shouldn't be there in the first place, I asked Nicolin to fix this when I applied the driver but he's not got round to it yet.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
Quoted 7 lines · Mark Brown
Quoted 3 lines · Arnd Bergmann

The wm8962 driver uses the input subsystem, but is selected by SND_SOC_FSL_ASOC_CARD, which can be built with CONFIG_INPUT disabled, resulting in this link error:

That select shouldn't be there in the first place, I asked Nicolin to fix this when I applied the driver but he's not got round to it yet.

Would the below change be a proper fix?

sound/soc/fsl/Kconfig +0 -3
index 6164e78..081e406 100644
@@ -288,9 +288,6 @@ config SND_SOC_FSL_ASOC_CARD
        select SND_SOC_FSL_ESAI
        select SND_SOC_FSL_SAI
        select SND_SOC_FSL_SSI
-       select SND_SOC_CS42XX8_I2C
-       select SND_SOC_SGTL5000
-       select SND_SOC_WM8962
        help
         ALSA SoC Audio support with ASRC feature for Freescale SoCs that have
         ESAI/SAI/SSI and connect with external CODECs such as WM8962, CS42888
#3 lore raw
Quoted 10 lines · Fabio Estevam
Quoted 2 lines · Mark Brown

That select shouldn't be there in the first place, I asked Nicolin to fix this when I applied the driver but he's not got round to it yet.

Would the below change be a proper fix?

sound/soc/fsl/Kconfig +0 -0
index 6164e78..081e406 100644

sound/soc/fsl/Kconfig config SND_SOC_FSL_ASOC_CARD · line 293

Quoted 4 lines
sound/soc/fsl/Kconfig +0 -3
 
-       select SND_SOC_CS42XX8_I2C
-       select SND_SOC_SGTL5000
-       select SND_SOC_WM8962

Okay..if Mark means this...I think it makes sense to me now.

But in this case, we shall add them into imx_v6_v7_defconfig instead.

Thank you
Nicolin

#4 lore raw
Quoted 12 lines · Nicolin Chen
Quoted 10 lines · Fabio Estevam
Quoted 2 lines · Mark Brown

That select shouldn't be there in the first place, I asked Nicolin to fix this when I applied the driver but he's not got round to it yet.

Would the below change be a proper fix?

sound/soc/fsl/Kconfig +0 -0
index 6164e78..081e406 100644
Quoted 7 lines

sound/soc/fsl/Kconfig config SND_SOC_FSL_ASOC_CARD · line 293

Quoted 3 lines
sound/soc/fsl/Kconfig +0 -3
-       select SND_SOC_CS42XX8_I2C
-       select SND_SOC_SGTL5000
-       select SND_SOC_WM8962

Okay..if Mark means this...I think it makes sense to me now.

But in this case, we shall add them into imx_v6_v7_defconfig instead.

We already have
CONFIG_SND_SOC_IMX_WM8962=y
CONFIG_SND_SOC_IMX_SGTL5000=y

in imx_v6_v7_defconfig.

#5 lore raw
Quoted 6 lines · Fabio Estevam
Quoted 6 lines

sound/soc/fsl/Kconfig config SND_SOC_FSL_ASOC_CARD · line 293

Quoted 3 lines
sound/soc/fsl/Kconfig +0 -3
-       select SND_SOC_CS42XX8_I2C
-       select SND_SOC_SGTL5000
-       select SND_SOC_WM8962

Okay..if Mark means this...I think it makes sense to me now.

Quoted 7 lines
Quoted 1 line

But in this case, we shall add them into imx_v6_v7_defconfig instead.

We already have
CONFIG_SND_SOC_IMX_WM8962=y
CONFIG_SND_SOC_IMX_SGTL5000=y

in imx_v6_v7_defconfig.

Yea, and these are two things I plan to drop...

So when enabling the FSL_ASOC_CARD, I also needs to put those three into it as well.

#6 lore raw
In reply to Mark Brown
Quoted 7 lines · Mark Brown
Quoted 3 lines · Arnd Bergmann

The wm8962 driver uses the input subsystem, but is selected by SND_SOC_FSL_ASOC_CARD, which can be built with CONFIG_INPUT disabled, resulting in this link error:

That select shouldn't be there in the first place, I asked Nicolin to fix this when I applied the driver but he's not got round to it yet.

I think I might have missed something around those days, even though the 'Applied' mail seemly doesn't have any comment against this part:
http://mailman.alsa-project.org/pipermail/alsa-devel/2014-August/080083.html

Is that possible for you to copy and paste the comments again?

Thank you
Nicolin

maintainer
#7 lore raw
Quoted 10 lines · Nicolin Chen
Quoted 2 lines · Mark Brown

That select shouldn't be there in the first place, I asked Nicolin to fix this when I applied the driver but he's not got round to it yet.

I think I might have missed something around those days, even though the 'Applied' mail seemly doesn't have any comment against this part:
http://mailman.alsa-project.org/pipermail/alsa-devel/2014-August/080083.html

Is that possible for you to copy and paste the comments again?

I suspect it was on an earlier version of the patch or a cover letter;
IIRC you were resending while I was reviewing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141001/04bf7c83/attachment.sig>

#8 lore raw
Quoted 6 lines · Mark Brown
Quoted 4 lines · Nicolin Chen
Quoted 2 lines · Mark Brown

That select shouldn't be there in the first place, I asked Nicolin to fix this when I applied the driver but he's not got round to it yet.

Quoted 8 lines
Quoted 5 lines

I think I might have missed something around those days, even though the 'Applied' mail seemly doesn't have any comment against this part:
http://mailman.alsa-project.org/pipermail/alsa-devel/2014-August/080083.html

Is that possible for you to copy and paste the comments again?

I suspect it was on an earlier version of the patch or a cover letter; IIRC you were resending while I was reviewing.

I checked the Archive, the patch only got one version without cover letter. And this version only got one reply which is the Applied mail. I guess your earlier reply might have been swallowed somehow so I couldn't read it.

Anyway, it's my fault that I didn't pay attention to the Kconfig part. The driver is initially designed for imx-cs42888, but I changed my mind to merge it with others before I sent it. And I didn't rewrite the part inside the Kconfig. Will be careful next time.

And I think Fabio's suggestion/patch has no problem right?

Thank you
Nicolin

maintainer
#9 lore raw
Quoted 4 lines · Nicolin Chen

I checked the Archive, the patch only got one version without cover letter. And this version only got one reply which is the Applied mail. I guess your earlier reply might have been swallowed somehow so I couldn't read it.

No, there were definitely at least two versions.

Quoted 1 line

And I think Fabio's suggestion/patch has no problem right?

That is the fix I was asking for.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141001/375cba9e/attachment-0001.sig>

#10 lore raw
Quoted 8 lines · Mark Brown
Quoted 4 lines · Nicolin Chen

I checked the Archive, the patch only got one version without cover letter. And this version only got one reply which is the Applied mail. I guess your earlier reply might have been swallowed somehow so I couldn't read it.

No, there were definitely at least two versions.

Sorry if I've really missed something.

And I still can't find any other reply. I sent the patch with a RFC tag, so I wouldn't ignore any comment to it, especially the comment from you sir.

Quoted 4 lines
Quoted 2 lines

And I think Fabio's suggestion/patch has no problem right?

That is the fix I was asking for.

Is there any other comment against the driver you can remember?

Thank you
Nicolin