amd64_edac: assign DRAM chip select base and mask in a family-specific way
Quoted 18 lines · Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <[email protected]>
Subject: Re: [PATCH 09/21]amd64_edac: assign DRAM chip select base and mask in a family-specific way
To: "Doug Thompson" <[email protected]>
Cc: "Borislav Petkov" <[email protected]>, [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Date: Tuesday, May 5, 2009, 3:39 PM
Em Tue, 5 May 2009 12:28:01 -0700
(PDT)
Doug Thompson <[email protected]>
escreveu:Quoted 1 line
BACKGROUND: The error checking of the pci config space
read was added during the time when the kernel couldn't read the extended 4k config space via the AMD IOConfig port access function (12 bits of offset) not via MMCONFIG.
As this is unlikely to happen, I would also replace the:
if (err != 0)
Quoted 9 lines
by:
if (unlikely(err))in order to optimize the tests a little bit, avoiding the risk of cache flushes due to the branches.
Cheers,
Mauro
when the driver is configured without DEBUG config flag on, the statement becomes:
if (exp)
;which with a good optimizer the code disappears altogether in the production condition. Only with DEBUGGING on will these outputs be generated.
thanks for the extra review eyes
doug t