Skip to contentSkip to conversation

Remove bash-ism from configure

PATCH In review Anthony Liguori 5 participants 7 messages Feb 11, 2007 – Feb 12, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove bash-ism from configure

This is one I introduced in the gcc-3.x autodetect. It's against CVS from a little while ago so hopefully it's just fuzz.

Regards,

Anthony Liguori

configure +1 -1
diff -r 00e394f6a849 configure
@@ -339,7 +339,7 @@ int main(){return 0;}
 int main(){return 0;}
 EOF
     check_cc() {
-	which "$1" >&/dev/null
+	which "$1" 2>/dev/null
 	return $?
     }
 
#1 lore raw

Hi,

Quoted 2 lines · Anthony Liguori

This is one I introduced in the gcc-3.x autodetect. It's against CVS from a little while ago so hopefully it's just fuzz.

AFAICT "which" is not really portable, either. But then, I always have a bash, so I really don't care.

Ciao,
Dscho

#2 lore raw
Quoted 10 lines · Johannes Schindelin

Hi,

Quoted 2 lines · Anthony Liguori

This is one I introduced in the gcc-3.x autodetect. It's against CVS from a little while ago so hopefully it's just fuzz.

AFAICT "which" is not really portable, either. But then, I always have a bash, so I really don't care.

On my system, which is an executable, not a shell command so it's outside the scope of bashism. It's also used elsewhere within configure.

We claim to use /bin/sh so we should not be using bashism.

Regards,

Anthony Liguori

Quoted 5 lines

Ciao,
Dscho

#3 lore raw

Hallo.

Quoted 4 lines

From: Anthony Liguori <[email protected]>
Newsgroups: gmane.comp.emulators.qemu
Subject: Re: [PATCH] Remove bash-ism from configure
Date: Sun, 11 Feb 2007 11:41:32 -0600

[]

Quoted 2 lines

On my system, which is an executable, not a shell command so it's outside the scope of bashism. It's also used elsewhere within configure.

sh' version of which' may be found in the Debian.

____

#4 lore raw
In reply to Anthony Liguori
Quoted 5 lines · Anthony Liguori
Quoted 4 lines · Johannes Schindelin

Hi,

On Sat, 10 Feb 2007, Anthony Liguori wrote:

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

This is one I introduced in the gcc-3.x autodetect. It's against CVS from a little while ago so hopefully it's just fuzz.

AFAICT "which" is not really portable, either. But then, I always have a bash, so I really don't care.

On my system, which is an executable, not a shell command so it's outside the scope of bashism. It's also used elsewhere within configure.

You should take a look at that executable. On most systems I know, /usr/bin/which is a csh script. It has to be because it also finds aliases. It may or may not be portable to use 'which', I'm not really sure, but it's not very efficient.

Krister

#5 lore raw
Quoted 4 lines · Krister Joas

You should take a look at that executable. On most systems I know, / usr/bin/which is a csh script. It has to be because it also finds aliases. It may or may not be portable to use 'which', I'm not really sure, but it's not very efficient.

On my Linux boxes, which is either a sh script (on Debian), or a (compiled) program (on Gentoo and Slackware). On my firewall (based on FreeBSD), which is also a program (and also a /bin/sh builtin).

Signature · 4 lines
< Jernej Simončič ><><><><>< http://deepthought.ena.si/ >

Matter will be damaged in direct proportion to its value.
       -- Murphy's Constant
#6 lore raw
Quoted 10 lines · Jernej Simončič
Quoted 4 lines · Krister Joas

You should take a look at that executable. On most systems I know, / usr/bin/which is a csh script. It has to be because it also finds aliases. It may or may not be portable to use 'which', I'm not really sure, but it's not very efficient.

On my Linux boxes, which is either a sh script (on Debian), or a (compiled) program (on Gentoo and Slackware). On my firewall (based on FreeBSD), which is also a program (and also a /bin/sh builtin).

I stand corrected. NetBSD seems to have removed it completely and instead relies on shell built-in commands. On OpenBSD it's also a binary. My references were Solaris and Mac OS X, where it's unfortunately still a csh script.

Krister