Skip to contentSkip to conversation

ARM: Samsung: Use the correct I2C2 interrupt

PATCH New Kyungmin Park 4 participants 6 messages Sep 30, 2010 – Oct 7, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Kyungmin Park

author
#0 lore raw

PATCH 3/7 ARM: Samsung: Use the correct I2C2 interrupt

From: Kyungmin Park <[email protected]>

Use the correct I2C2 interrupt.

Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/plat-samsung/dev-i2c2.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/plat-samsung/dev-i2c2.c +2 -2
index 07036de..ff4ba69 100644
@@ -32,8 +32,8 @@ static struct resource s3c_i2c_resource[] = {
 		.flags = IORESOURCE_MEM,
 	},
 	[1] = {
-		.start = IRQ_CAN0,
-		.end   = IRQ_CAN0,
+		.start = IRQ_IIC2,
+		.end   = IRQ_IIC2,
 		.flags = IORESOURCE_IRQ,
 	},
 };
Signature · 1 line
1.5.3.3
#1 lore raw

PATCH 3/7 ARM: Samsung: Use the correct I2C2 interrupt

Quoted 14 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

Use the correct I2C2 interrupt.

Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/plat-samsung/dev-i2c2.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/plat-samsung/dev-i2c2.c +0 -0
index 07036de..ff4ba69 100644

arch/arm/plat-samsung/dev-i2c2.c static struct resource s3c_i2c_resource[] = { · line 37

Quoted 8 lines
arch/arm/plat-samsung/dev-i2c2.c +2 -2
@@ -32,8 +32,8 @@ static struct resource s3c_i2c_resource[] = {
 		.flags = IORESOURCE_MEM,
 	},
 	[1] = {
-		.start = IRQ_CAN0,
-		.end   = IRQ_CAN0,
+		.start = IRQ_IIC2,
+		.end   = IRQ_IIC2,

Is there any reason for using 'IIC' here to refer to 'I2C'?

Lothar Wa?mann

Signature · 9 lines
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
author
#2 lore raw

PATCH 3/7 ARM: Samsung: Use the correct I2C2 interrupt

Quoted 10 lines · Lothar Wa?mann
Quoted 9 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

Use the correct I2C2 interrupt.

Signed-off-by Kyungmin Park <[email protected]>

---
?arch/arm/plat-samsung/dev-i2c2.c | ? ?4 ++--
?1 files changed, 2 insertions(+), 2 deletions(-)

Quoted 14 lines

arch/arm/plat-samsung/dev-i2c2.c static struct resource s3c_i2c_resource[] = { · line 37

Quoted 13 lines
arch/arm/plat-samsung/dev-i2c2.c +2 -2
index 07036de..ff4ba69 100644
@@ -32,8 +32,8 @@ static struct resource s3c_i2c_resource[] = {
 ? ? ? ? ? ? ? .flags = IORESOURCE_MEM,
 ? ? ? },
 ? ? ? [1] = {
- ? ? ? ? ? ? .start = IRQ_CAN0,
- ? ? ? ? ? ? .end ? = IRQ_CAN0,
+ ? ? ? ? ? ? .start = IRQ_IIC2,
+ ? ? ? ? ? ? .end ? = IRQ_IIC2,

Is there any reason for using 'IIC' here to refer to 'I2C'?

Historical reason previous s3c24xx series use this name. I don't want to break the s3c24xx series codes.
Instead I use the I2C after S5P series. I2C3, I2C4 and so on.

If all person who works on s3c24xx and s5p series agree that use the I2C. It can be used.

Thank you,
Kyungmin Park

Quoted 14 lines

Lothar Wa?mann
--
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________

#3 lore raw

PATCH 3/7 ARM: Samsung: Use the correct I2C2 interrupt

On Thu, Sep 30, 2010 at 5:45 PM, Lothar Wa?mann <[email protected]>

Quoted 31 lines
Quoted 11 lines · wrote:

arch/arm/plat-

Quoted 10 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

Use the correct I2C2 interrupt.

Signed-off-by Kyungmin Park <[email protected]>

---
?arch/arm/plat-samsung/dev-i2c2.c | ? ?4 ++--
?1 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/plat- renamed from arch/arm/plat-samsung/dev-i2c2.c +0 -0

samsung/dev-i2c2.c

Quoted 5 lines
Quoted 5 lines

index 07036de..ff4ba69 100644

arch/arm/plat-samsung/dev-i2c2.c +0 -0
@@ -32,8 +32,8 @@ static struct resource s3c_i2c_resource[] = {
 ? ? ? ? ? ? ? .flags = IORESOURCE_MEM,
Quoted 8 lines

arch/arm/plat-samsung/dev-i2c2.c static struct resource s3c_i2c_resource[] = { · line 37

Quoted 7 lines
arch/arm/plat-samsung/dev-i2c2.c +2 -2
 ? ? ? },
 ? ? ? [1] = {
- ? ? ? ? ? ? .start = IRQ_CAN0,
- ? ? ? ? ? ? .end ? = IRQ_CAN0,
+ ? ? ? ? ? ? .start = IRQ_IIC2,
+ ? ? ? ? ? ? .end ? = IRQ_IIC2,

Is there any reason for using 'IIC' here to refer to 'I2C'?

Historical reason previous s3c24xx series use this name. I don't want to break the s3c24xx series codes.
Instead I use the I2C after S5P series. I2C3, I2C4 and so on.

Quoted 5 lines

If all person who works on s3c24xx and s5p series agree that use the I2C. It can be used.

Thank you,
Kyungmin Park

Hi, Kyungmin
IRQ_CAN0 is also used in arch/arm/mach-s5pc100/include/mach/irqs.h

Best Regards
Jongsun Han

author
#4 lore raw

PATCH 3/7 ARM: Samsung: Use the correct I2C2 interrupt

Quoted 32 lines · Jongsun Han

On Thu, Sep 30, 2010 at 5:45 PM, Lothar Wa?mann <[email protected]>

Quoted 31 lines
Quoted 11 lines · wrote:

arch/arm/plat-

Quoted 10 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

Use the correct I2C2 interrupt.

Signed-off-by Kyungmin Park <[email protected]>

---
?arch/arm/plat-samsung/dev-i2c2.c | ? ?4 ++--
?1 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/plat- renamed from arch/arm/plat-samsung/dev-i2c2.c +0 -0

samsung/dev-i2c2.c

Quoted 5 lines
Quoted 5 lines

index 07036de..ff4ba69 100644

arch/arm/plat-samsung/dev-i2c2.c +0 -0
@@ -32,8 +32,8 @@ static struct resource s3c_i2c_resource[] = {
 ? ? ? ? ? ? ? .flags = IORESOURCE_MEM,
Quoted 8 lines

arch/arm/plat-samsung/dev-i2c2.c static struct resource s3c_i2c_resource[] = { · line 37

Quoted 7 lines
arch/arm/plat-samsung/dev-i2c2.c +2 -2
 ? ? ? },
 ? ? ? [1] = {
- ? ? ? ? ? ? .start = IRQ_CAN0,
- ? ? ? ? ? ? .end ? = IRQ_CAN0,
+ ? ? ? ? ? ? .start = IRQ_IIC2,
+ ? ? ? ? ? ? .end ? = IRQ_IIC2,

Is there any reason for using 'IIC' here to refer to 'I2C'?

Historical reason previous s3c24xx series use this name. I don't want to break the s3c24xx series codes.
Instead I use the I2C after S5P series. I2C3, I2C4 and so on.

Quoted 8 lines
Quoted 5 lines

If all person who works on s3c24xx and s5p series agree that use the I2C. It can be used.

Thank you,
Kyungmin Park

Hi, Kyungmin
IRQ_CAN0 is also used in arch/arm/mach-s5pc100/include/mach/irqs.h

Yes it's defined and will be used. but not I2C2
I already check it. at least my manual it's s5pc100 don't have I2C2.

Thank you,
Kyungmin Park

Quoted 6 lines

Best Regards
Jongsun Han

#5 lore raw

PATCH 3/7 ARM: Samsung: Use the correct I2C2 interrupt

In reply to Kyungmin Park

Review

Quoted 11 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

Use the correct I2C2 interrupt.

Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/plat-samsung/dev-i2c2.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/arch/arm/plat-samsung/dev-i2c2.c

Quoted 5 lines

index 07036de..ff4ba69 100644

arch/arm/plat-samsung/dev-i2c2.c +0 -0
@@ -32,8 +32,8 @@ static struct resource s3c_i2c_resource[] = {
 		.flags = IORESOURCE_MEM,

arch/arm/plat-samsung/dev-i2c2.c static struct resource s3c_i2c_resource[] = {

Quoted 10 lines
arch/arm/plat-samsung/dev-i2c2.c +2 -3
 	},
 	[1] = {
-		.start = IRQ_CAN0,
-		.end   = IRQ_CAN0,
+		.start = IRQ_IIC2,
+		.end   = IRQ_IIC2,
 		.flags = IORESOURCE_IRQ,
 	},
 };
--

Hi,

Looks ok...
In my opinion, could you please merge your 2nd and this patch to one, changing I2C2 interrupt name?
And need to add s5pc100's I2C2 interrupt name changing in there.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.