Skip to contentSkip to conversation

phy: phy-rockchip-inno-usb2: add phy description for px30

PATCH In review Heiko Stuebner 3 participants 4 messages Sep 17, 2019 – Oct 31, 2019

Subsystems (3)
lore
Share & tools
lore

Heiko Stuebner

author maintainer
#0 lore raw

PATCH 1/1 phy: phy-rockchip-inno-usb2: add phy description for px30

The px30 soc from Rockchip shares the same register description as the rk3328, so can re-use its definitions.

---
 Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 1 +
 drivers/phy/rockchip/phy-rockchip-inno-usb2.c                    | 1 +
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt +1 -0
index 00639baae74a..541f5298827c 100644
@@ -2,6 +2,7 @@ ROCKCHIP USB2.0 PHY WITH INNO IP BLOCK
 
 Required properties (phy (parent) node):
  - compatible : should be one of the listed compatibles:
+	* "rockchip,px30-usb2phy"
 	* "rockchip,rk3228-usb2phy"
 	* "rockchip,rk3328-usb2phy"
 	* "rockchip,rk3366-usb2phy"
drivers/phy/rockchip/phy-rockchip-inno-usb2.c +1 -0
index eae865ff312c..680cc0c8825c 100644
@@ -1423,6 +1423,7 @@ static const struct rockchip_usb2phy_cfg rv1108_phy_cfgs[] = {
 };
 
 static const struct of_device_id rockchip_usb2phy_dt_match[] = {
+	{ .compatible = "rockchip,px30-usb2phy", .data = &rk3328_phy_cfgs },
 	{ .compatible = "rockchip,rk3228-usb2phy", .data = &rk3228_phy_cfgs },
 	{ .compatible = "rockchip,rk3328-usb2phy", .data = &rk3328_phy_cfgs },
 	{ .compatible = "rockchip,rk3366-usb2phy", .data = &rk3366_phy_cfgs },
Signature · 1 line
2.20.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Heiko Stuebner

The px30 soc from Rockchip shares the same register description as the rk3328, so can re-use its definitions.

---
 Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 1 +
 drivers/phy/rockchip/phy-rockchip-inno-usb2.c                    | 1 +
 2 files changed, 2 insertions(+)
author maintainer
#2 lore raw
In reply to Heiko Stuebner

Hi Kishon,

Am Dienstag, 17. September 2019, 10:25:32 CET schrieb Heiko Stuebner:

Quoted 4 lines

The px30 soc from Rockchip shares the same register description as the rk3328, so can re-use its definitions.

could you pick this up as well please?

Thanks
Heiko

Quoted 30 lines
---
 Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 1 +
 drivers/phy/rockchip/phy-rockchip-inno-usb2.c                    | 1 +
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt +1 -0
index 00639baae74a..541f5298827c 100644
@@ -2,6 +2,7 @@ ROCKCHIP USB2.0 PHY WITH INNO IP BLOCK
 
 Required properties (phy (parent) node):
  - compatible : should be one of the listed compatibles:
+	* "rockchip,px30-usb2phy"
 	* "rockchip,rk3228-usb2phy"
 	* "rockchip,rk3328-usb2phy"
 	* "rockchip,rk3366-usb2phy"
drivers/phy/rockchip/phy-rockchip-inno-usb2.c +1 -0
index eae865ff312c..680cc0c8825c 100644
@@ -1423,6 +1423,7 @@ static const struct rockchip_usb2phy_cfg rv1108_phy_cfgs[] = {
 };
 
 static const struct of_device_id rockchip_usb2phy_dt_match[] = {
+	{ .compatible = "rockchip,px30-usb2phy", .data = &rk3328_phy_cfgs },
 	{ .compatible = "rockchip,rk3228-usb2phy", .data = &rk3228_phy_cfgs },
 	{ .compatible = "rockchip,rk3328-usb2phy", .data = &rk3328_phy_cfgs },
 	{ .compatible = "rockchip,rk3366-usb2phy", .data = &rk3366_phy_cfgs },
#3 lore raw
Quoted 9 lines · Heiko Stuebner

Hi Kishon,

Am Dienstag, 17. September 2019, 10:25:32 CET schrieb Heiko Stuebner:

Quoted 4 lines

The px30 soc from Rockchip shares the same register description as the rk3328, so can re-use its definitions.

could you pick this up as well please?

merged now, thanks.

-Kishon

Quoted 38 lines

Thanks
Heiko

Quoted 30 lines
---
 Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 1 +
 drivers/phy/rockchip/phy-rockchip-inno-usb2.c                    | 1 +
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt +1 -0
index 00639baae74a..541f5298827c 100644
@@ -2,6 +2,7 @@ ROCKCHIP USB2.0 PHY WITH INNO IP BLOCK
 
 Required properties (phy (parent) node):
  - compatible : should be one of the listed compatibles:
+	* "rockchip,px30-usb2phy"
 	* "rockchip,rk3228-usb2phy"
 	* "rockchip,rk3328-usb2phy"
 	* "rockchip,rk3366-usb2phy"
drivers/phy/rockchip/phy-rockchip-inno-usb2.c +1 -0
index eae865ff312c..680cc0c8825c 100644
@@ -1423,6 +1423,7 @@ static const struct rockchip_usb2phy_cfg rv1108_phy_cfgs[] = {
 };
 
 static const struct of_device_id rockchip_usb2phy_dt_match[] = {
+	{ .compatible = "rockchip,px30-usb2phy", .data = &rk3328_phy_cfgs },
 	{ .compatible = "rockchip,rk3228-usb2phy", .data = &rk3228_phy_cfgs },
 	{ .compatible = "rockchip,rk3328-usb2phy", .data = &rk3328_phy_cfgs },
 	{ .compatible = "rockchip,rk3366-usb2phy", .data = &rk3366_phy_cfgs },