Skip to contentSkip to conversation

ARM: shmobile: r8a7779: Fix PFC - MOD_SEL2 missed an entry

PATCH New Phil Edworthy 3 participants 8 messages Nov 22, 2012 – Dec 19, 2012

Subsystems (4)
Arm (32-bit) Arm sub-architectures SuperH Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Phil Edworthy

author
#0 lore raw

PATCH 1/1 ARM: shmobile: r8a7779: Fix PFC - MOD_SEL2 missed an entry

The list of functions selected by the MOD_SEL2 register was missing an entry. This caused all entries after this to modify the MOD_SEL2 register incorrectly.

Signed-off-by Phil Edworthy <[email protected]>
---
 arch/arm/mach-shmobile/pfc-r8a7779.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-shmobile/pfc-r8a7779.c +1 -1
index 9fac32e4..15f6a48 100644
@@ -2525,7 +2525,7 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
 	    /* SEL_SCIF [2] */
 	    FN_SEL_SCIF_0, FN_SEL_SCIF_1, FN_SEL_SCIF_2, FN_SEL_SCIF_3,
 	    /* SEL_CANCLK [2] */
-	    FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2,
+	    FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2, 0,
 	    /* SEL_CAN0 [1] */
 	    FN_SEL_CAN0_0, FN_SEL_CAN0_1,
 	    /* SEL_HSCIF1 [1] */
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 ARM: shmobile: r8a7779: Fix PFC - MOD_SEL2 missed an entry

Quoted 5 lines · On Thursday 22 November 2012 16:28:57 Phil Edworthy wrote:

The list of functions selected by the MOD_SEL2 register was missing an entry. This caused all entries after this to modify the MOD_SEL2 register incorrectly.

Signed-off-by Phil Edworthy <[email protected]>
Acked-by Laurent Pinchart <[email protected]>

Simon, this will conflict with my PFC patch series. As I'm still waiting for review and need to send a v2 anyway, please apply this patch to your tree and push it for v3.8 if time permits. I'll rebase my series on top of it.

Quoted 17 lines
---
 arch/arm/mach-shmobile/pfc-r8a7779.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-shmobile/pfc-r8a7779.c index 9fac32e4..15f6a48 100644

arch/arm/mach-shmobile/pfc-r8a7779.c +1 -1
@@ -2525,7 +2525,7 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
 	    /* SEL_SCIF [2] */
 	    FN_SEL_SCIF_0, FN_SEL_SCIF_1, FN_SEL_SCIF_2, FN_SEL_SCIF_3,
 	    /* SEL_CANCLK [2] */
-	    FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2,
+	    FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2, 0,
 	    /* SEL_CAN0 [1] */
 	    FN_SEL_CAN0_0, FN_SEL_CAN0_1,
 	    /* SEL_HSCIF1 [1] */
Signature · 3 lines
Regards,

Laurent Pinchart
#2 lore raw

PATCH 1/1 ARM: shmobile: r8a7779: Fix PFC - MOD_SEL2 missed an entry

In reply to Phil Edworthy
Quoted 3 lines · Phil Edworthy

The list of functions selected by the MOD_SEL2 register was missing an entry. This caused all entries after this to modify the MOD_SEL2 register incorrectly.

Laurent, can you handle this in your series?
I believe it removes this file.

Quoted 28 lines
Signed-off-by Phil Edworthy <[email protected]>
---
 arch/arm/mach-shmobile/pfc-r8a7779.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-shmobile/pfc-r8a7779.c +1 -1
index 9fac32e4..15f6a48 100644
@@ -2525,7 +2525,7 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
 	    /* SEL_SCIF [2] */
 	    FN_SEL_SCIF_0, FN_SEL_SCIF_1, FN_SEL_SCIF_2, FN_SEL_SCIF_3,
 	    /* SEL_CANCLK [2] */
-	    FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2,
+	    FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2, 0,
 	    /* SEL_CAN0 [1] */
 	    FN_SEL_CAN0_0, FN_SEL_CAN0_1,
 	    /* SEL_HSCIF1 [1] */
Signature · 7 lines
1.7.5.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

PATCH 1/1 ARM: shmobile: r8a7779: Fix PFC - MOD_SEL2 missed an entry

Quoted 7 lines · Simon Horman
Quoted 3 lines · Phil Edworthy

The list of functions selected by the MOD_SEL2 register was missing an entry. This caused all entries after this to modify the MOD_SEL2 register incorrectly.

Laurent, can you handle this in your series?
I believe it removes this file.

Sorry, I missed the fact that this is for stable. Laurent, can you handle upstream and I'll handle stable?

Quoted 32 lines
Quoted 27 lines
Signed-off-by Phil Edworthy <[email protected]>
---
 arch/arm/mach-shmobile/pfc-r8a7779.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-shmobile/pfc-r8a7779.c +1 -1
index 9fac32e4..15f6a48 100644
@@ -2525,7 +2525,7 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
 	    /* SEL_SCIF [2] */
 	    FN_SEL_SCIF_0, FN_SEL_SCIF_1, FN_SEL_SCIF_2, FN_SEL_SCIF_3,
 	    /* SEL_CANCLK [2] */
-	    FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2,
+	    FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2, 0,
 	    /* SEL_CAN0 [1] */
 	    FN_SEL_CAN0_0, FN_SEL_CAN0_1,
 	    /* SEL_HSCIF1 [1] */
Signature · 7 lines
1.7.5.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw

PATCH 1/1 ARM: shmobile: r8a7779: Fix PFC - MOD_SEL2 missed an entry

Quoted 11 lines · Simon Horman
Quoted 7 lines · Simon Horman
Quoted 3 lines · Phil Edworthy

The list of functions selected by the MOD_SEL2 register was missing an entry. This caused all entries after this to modify the MOD_SEL2 register incorrectly.

Laurent, can you handle this in your series?
I believe it removes this file.

Sorry, I missed the fact that this is for stable. Laurent, can you handle upstream and I'll handle stable?

Sorry, yet another thing.

Phil, could you explain what problems manifest at for users without this change? To be included in stable it is important that it solves a problem that actually manifests.

Quoted 37 lines
Quoted 22 lines
Quoted 22 lines
Signed-off-by Phil Edworthy <[email protected]>
---
 arch/arm/mach-shmobile/pfc-r8a7779.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-shmobile/pfc-r8a7779.c +1 -1
index 9fac32e4..15f6a48 100644
@@ -2525,7 +2525,7 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
 	    /* SEL_SCIF [2] */
 	    FN_SEL_SCIF_0, FN_SEL_SCIF_1, FN_SEL_SCIF_2, FN_SEL_SCIF_3,
 	    /* SEL_CANCLK [2] */
-	    FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2,
+	    FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2, 0,
 	    /* SEL_CAN0 [1] */
 	    FN_SEL_CAN0_0, FN_SEL_CAN0_1,
 	    /* SEL_HSCIF1 [1] */
Signature · 1 line
1.7.5.4
Quoted 10 lines
Quoted 5 lines

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#5 lore raw

PATCH 1/1 ARM: shmobile: r8a7779: Fix PFC - MOD_SEL2 missed an entry

Hi Simon,

Quoted 7 lines · On Tuesday 18 December 2012 13:28:54 Simon Horman wrote:
Quoted 6 lines · Simon Horman
Quoted 5 lines · Simon Horman
Quoted 3 lines · Phil Edworthy

The list of functions selected by the MOD_SEL2 register was missing an entry. This caused all entries after this to modify the MOD_SEL2 register incorrectly.

Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

Laurent, can you handle this in your series?
I believe it removes this file.

Sorry, I missed the fact that this is for stable. Laurent, can you handle upstream and I'll handle stable?

Sure. I've added the patch to my tree.

Quoted 29 lines

Sorry, yet another thing.

Phil, could you explain what problems manifest at for users without this change? To be included in stable it is important that it solves a problem that actually manifests.

Quoted 23 lines
Quoted 23 lines
Quoted 23 lines
Signed-off-by Phil Edworthy <[email protected]>

---

 arch/arm/mach-shmobile/pfc-r8a7779.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-shmobile/pfc-r8a7779.c index 9fac32e4..15f6a48 100644

arch/arm/mach-shmobile/pfc-r8a7779.c +1 -1
@@ -2525,7 +2525,7 @@ static struct pinmux_cfg_reg
 pinmux_config_regs[] = {
 
 	    /* SEL_SCIF [2] */
 	    FN_SEL_SCIF_0, FN_SEL_SCIF_1, FN_SEL_SCIF_2, FN_SEL_SCIF_3,
 	    /* SEL_CANCLK [2] */
 
-	    FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2,
+	    FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2, 0,
arch/arm/mach-shmobile/pfc-r8a7779.c +0 -0
 	    /* SEL_CAN0 [1] */
 	    FN_SEL_CAN0_0, FN_SEL_CAN0_1,
 	    /* SEL_HSCIF1 [1] */
Signature · 3 lines
Regards,

Laurent Pinchart
author
#6 lore raw

PATCH 1/1 ARM: shmobile: r8a7779: Fix PFC - MOD_SEL2 missed an entry

In reply to Simon Horman

Hi Simon,

Quoted 4 lines · Simon Horman
Quoted 3 lines · Simon Horman
Quoted 2 lines · Phil Edworthy
Quoted 1 line

The list of functions selected by the MOD_SEL2 register was

missing

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

an entry. This caused all entries after this to modify the

MOD_SEL2

Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

register incorrectly.

Laurent, can you handle this in your series?
I believe it removes this file.

Quoted 7 lines
Quoted 2 lines

Sorry, I missed the fact that this is for stable. Laurent, can you handle upstream and I'll handle stable?

Sorry, yet another thing.

Phil, could you explain what problems manifest at for users without this change? To be included in stable it is important that it solves a

problem

Quoted 1 line

that actually manifests.

If the user requests certain pin functionality (e.g. any HSPI2_B pins such as GPIO_FN_HSPI_CLK2_B), the MOD_SEL2 register won't be set up correctly, so it won't work. I am not sure if that warrants going onto stable or not
- your call!

Thanks
Phil

#7 lore raw

PATCH 1/1 ARM: shmobile: r8a7779: Fix PFC - MOD_SEL2 missed an entry

Quoted 21 lines · phil.edworthy at renesas.com

Hi Simon,

Quoted 4 lines · Simon Horman
Quoted 3 lines · Simon Horman
Quoted 2 lines · Phil Edworthy
Quoted 1 line

The list of functions selected by the MOD_SEL2 register was

missing

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

an entry. This caused all entries after this to modify the

MOD_SEL2

Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

register incorrectly.

Laurent, can you handle this in your series?
I believe it removes this file.

Quoted 7 lines
Quoted 2 lines

Sorry, I missed the fact that this is for stable. Laurent, can you handle upstream and I'll handle stable?

Sorry, yet another thing.

Phil, could you explain what problems manifest at for users without this change? To be included in stable it is important that it solves a

Quoted 7 lines

problem

Quoted 1 line

that actually manifests.

If the user requests certain pin functionality (e.g. any HSPI2_B pins such as GPIO_FN_HSPI_CLK2_B), the MOD_SEL2 register won't be set up correctly, so it won't work. I am not sure if that warrants going onto stable or not
- your call!

Thanks. At this stage I think that it isn't stable material. Regardless, I will see about getting the fix included in 3.8.