Skip to contentSkip to conversation

travis-ci: Build EDK2 roms

PATCH In review Philippe Mathieu-Daudé 3 participants 11 messages Mar 11, 2019 – Sep 21, 2019 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

cover travis-ci: Build EDK2 roms

Hi,

This series add a job to Travis CI to build the last EDK2 stable release roms within QEMU.
This job is only triggered if a commit matches 'EDK2' or during QEMU releases (when tags are pushed).

Job output: https://travis-ci.org/philmd/qemu/jobs/504460932
Duration: 33 min 51 sec (output 5080 lines)

Based on Laszlo's series "bundle edk2 platform firmware with QEMU":
https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02846.html

Please review,

Phil.

Based-on: [email protected]

Philippe Mathieu-Daudé (5):
roms/edk2: Avoid bashism in Makefile 'shell' function roms/edk2: Avoid bashism in script
roms/edk2: Pass extra arguments to the build script via
EDK2_BUILD_OPTIONS
NOTFORMERGE roms/edk2: Use arm-linux-gnueabihf-gcc on Debian based
distribs
.travis.yml: Build and install EDK2 roms

 .travis.yml        | 21 +++++++++++++++++++++
 roms/Makefile.edk2 |  8 +++++++-
 roms/edk2-funcs.sh |  9 +++++++--
 3 files changed, 35 insertions(+), 3 deletions(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/5 roms/edk2: Avoid bashism in Makefile 'shell' function

The shell builtin 'source' command is a bash extension. Use the '.' portable command.

This fix building when /bin/sh is dash (Ubuntu 16):

  $ make -C roms efi
  [...]
  Fd File Name:QEMU_EFI
  (/source/qemu/roms/edk2/Build/ArmVirtQemu-AARCH64/DEBUG_GCC5/FV/QEMU_EFI.fd)
  Fd File Name:QEMU_VARS
  (/source/qemu/roms/edk2/Build/ArmVirtQemu-AARCH64/DEBUG_GCC5/FV/QEMU_VARS.fd)
  GUID cross reference file can be found at
  /source/qemu/roms/edk2/Build/ArmVirtQemu-AARCH64/DEBUG_GCC5/FV/Guid.xref
  - Done -
  Build end time: 16:33:29, Mar.09 2019
  Build total time: 00:03:35
  cp edk2/Build/ArmVirtQemu-AARCH64/DEBUG_/FV/QEMU_EFI.fd \
  	../pc-bios/edk2-aarch64-code.fd
  cp: cannot stat 'edk2/Build/ArmVirtQemu-AARCH64/DEBUG_/FV/QEMU_EFI.fd':
  No such file or directory
  Makefile.edk2:45: recipe for target '../pc-bios/edk2-aarch64-code.fd' failed
  make[1]: *** [../pc-bios/edk2-aarch64-code.fd] Error 1
  make[1]: Leaving directory '/source/qemu/roms'
  Makefile:148: recipe for target 'efi' failed
  make: *** [efi] Error 2
  make: Leaving directory '/source/qemu/roms'
---
 roms/Makefile.edk2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
roms/Makefile.edk2 +1 -1
index ad6fff044c..6c5e9b9eea 100644
@@ -11,7 +11,7 @@
 # THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, WITHOUT
 # WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 
-toolchain = $(shell source ./edk2-funcs.sh && qemu_edk2_get_toolchain $(1))
+toolchain = $(shell . ./edk2-funcs.sh && qemu_edk2_get_toolchain $(1))
 
 licenses := \
 	edk2/License.txt \
Signature · 1 line
2.20.1
#2 lore raw

PATCH 2/5 roms/edk2: Avoid bashism in script

In reply to Philippe Mathieu-Daudé

Use the POSIX '=' to evaluate equality.

This fixes building the roms with a dash shell:

  $ make -C roms efi
  [...]
  cp edk2/Build/ArmVirtQemu-ARM/DEBUG_GCC5/FV/QEMU_EFI.fd \
        ../pc-bios/edk2-arm-code.fd
  truncate --size=64M ../pc-bios/edk2-arm-code.fd
  /bin/sh: 111: [: i686: unexpected operator
  /bin/sh: 112: [: i686: unexpected operator
  /bin/sh: 116: [: i686: unexpected operator
---
 roms/edk2-funcs.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
roms/edk2-funcs.sh +2 -2
index 7fc62f074c..402fc126fb 100644
@@ -108,8 +108,8 @@ qemu_edk2_get_cross_prefix()
 
   host_arch=$(uname -m)
 
-  if [ "$gcc_arch" == "$host_arch" ] ||
-     ( [ "$gcc_arch" == i686 ] && [ "$host_arch" == x86_64 ] ); then
+  if [ "$gcc_arch" = "$host_arch" ] ||
+     ( [ "$gcc_arch" = i686 ] && [ "$host_arch" = x86_64 ] ); then
     # no cross-compiler needed
     :
   else
Signature · 1 line
2.20.1
#3 lore raw

PATCH 3/5 roms/edk2: Pass extra arguments to the build script via EDK2_BUILD_OPTIONS

In reply to Philippe Mathieu-Daudé

The current EDK2 options produce a very verbose output. When building the roms on Continuous Integration systems (such Travis CI) the system limit is quickly reached.

Add an variable to optionally pass arguments to the edk2-build.sh script.

Example of use:

  $ EDK2_BUILD_OPTIONS="--quiet --silent" make -C roms efi
  ...
---
 roms/Makefile.edk2 | 6 ++++++
 1 file changed, 6 insertions(+)
roms/Makefile.edk2 +6 -0
index 6c5e9b9eea..70f84b20df 100644
@@ -44,6 +44,7 @@ submodules:
 ../pc-bios/edk2-aarch64-code.fd: submodules
 	+./edk2-build.sh \
 		aarch64 \
+		$(EDK2_BUILD_OPTIONS) \
 		--arch=AARCH64 \
 		--platform=ArmVirtPkg/ArmVirtQemu.dsc \
 		-D NETWORK_IP6_ENABLE \
@@ -55,6 +56,7 @@ submodules:
 ../pc-bios/edk2-arm-code.fd: submodules
 	+./edk2-build.sh \
 		arm \
+		$(EDK2_BUILD_OPTIONS) \
 		--arch=ARM \
 		--platform=ArmVirtPkg/ArmVirtQemu.dsc \
 		-D NETWORK_IP6_ENABLE \
@@ -66,6 +68,7 @@ submodules:
 ../pc-bios/edk2-i386-code.fd: submodules
 	+./edk2-build.sh \
 		i386 \
+		$(EDK2_BUILD_OPTIONS) \
 		--arch=IA32 \
 		--platform=OvmfPkg/OvmfPkgIa32.dsc \
 		-D NETWORK_IP6_ENABLE \
@@ -78,6 +81,7 @@ submodules:
 ../pc-bios/edk2-i386-secure-code.fd: submodules
 	+./edk2-build.sh \
 		i386 \
+		$(EDK2_BUILD_OPTIONS) \
 		--arch=IA32 \
 		--platform=OvmfPkg/OvmfPkgIa32.dsc \
 		-D NETWORK_IP6_ENABLE \
@@ -92,6 +96,7 @@ submodules:
 ../pc-bios/edk2-x86_64-code.fd: submodules
 	+./edk2-build.sh \
 		x86_64 \
+		$(EDK2_BUILD_OPTIONS) \
 		--arch=X64 \
 		--platform=OvmfPkg/OvmfPkgX64.dsc \
 		-D NETWORK_IP6_ENABLE \
@@ -104,6 +109,7 @@ submodules:
 ../pc-bios/edk2-x86_64-secure-code.fd: submodules
 	+./edk2-build.sh \
 		x86_64 \
+		$(EDK2_BUILD_OPTIONS) \
 		--arch=IA32 \
 		--arch=X64 \
 		--platform=OvmfPkg/OvmfPkgIa32X64.dsc \
Signature · 1 line
2.20.1
#4 lore raw

PATCH 4/5 NOTFORMERGE roms/edk2: Use arm-linux-gnueabihf-gcc on Debian based distribs

In reply to Philippe Mathieu-Daudé

Do not enforce GCCx_ARM_PREFIX=arm-linux-gnu- on Debian based distributions.
This is a kludge not meant for merging!

---
 roms/edk2-funcs.sh | 5 +++++
 1 file changed, 5 insertions(+)
roms/edk2-funcs.sh +5 -0
index 402fc126fb..2f1fa2af1a 100644
@@ -113,6 +113,11 @@ qemu_edk2_get_cross_prefix()
     # no cross-compiler needed
     :
   else
+    if [ -f /etc/lsb-release ] && [ "$gcc_arch" = arm ]; then
+      # XXX kludge for Debian-based distribs
+      printf 'arm-linux-gnueabihf-\n'
+      return 0
+    fi
     printf '%s-linux-gnu-\n' "$gcc_arch"
   fi
 }
Signature · 1 line
2.20.1
#5 lore raw

PATCH 5/5 .travis.yml: Build and install EDK2 roms

In reply to Philippe Mathieu-Daudé

Add a job to build and install the EDK2 platform firmware binaries.

This job is only triggered if the last commit matches the EDK2 name (case insensitive), or when tag are created (such releases or release candidates).

---
 .travis.yml | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
.travis.yml +21 -0
index e942175dd3..628cc52c99 100644
@@ -258,3 +258,24 @@ matrix:
     - env:
         - CONFIG="--disable-system"
         - TEST_CMD="make -j3 check-tcg V=1"
+
+
+    # EDK2 roms builds
+    - if: tag IS present OR commit_message =~ /(edk2|EDK2)/
+      env:
+        - CONFIG="--disable-system --disable-user --prefix=$PWD/dist"
+        - EDK2_BUILD_OPTIONS="--quiet --silent"
+      script:
+        - git submodule update --init roms/edk2
+        - make -j3
+        - make -C roms efi -j2
+        - make install
+      addons:
+        apt:
+          packages:
+            - dos2unix
+            - gcc-aarch64-linux-gnu
+            - gcc-arm-linux-gnueabihf
+            - iasl
+            - nasm
+            - uuid-dev
Signature · 1 line
2.20.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

#7 lore raw

Re: [Qemu-devel] [PATCH 5/5] .travis.yml: Build and install EDK2 roms

Hi Laszlo,

Quoted 38 lines · Laszlo Ersek
Quoted 37 lines · Philippe Mathieu-Daudé

Add a job to build and install the EDK2 platform firmware binaries.

This job is only triggered if the last commit matches the EDK2 name (case insensitive), or when tag are created (such releases or release candidates).

---
 .travis.yml | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
.travis.yml +18 -0
index e942175dd3..628cc52c99 100644
@@ -258,3 +258,24 @@ matrix:
     - env:
         - CONFIG="--disable-system"
         - TEST_CMD="make -j3 check-tcg V=1"
+
+
+    # EDK2 roms builds
+    - if: tag IS present OR commit_message =~ /(edk2|EDK2)/
+      env:
+        - CONFIG="--disable-system --disable-user --prefix=$PWD/dist"
+        - EDK2_BUILD_OPTIONS="--quiet --silent"
+      script:
+        - git submodule update --init roms/edk2
+        - make -j3
+        - make -C roms efi -j2
+        - make install
+      addons:
+        apt:
+          packages:
+            - dos2unix
+            - gcc-aarch64-linux-gnu
+            - gcc-arm-linux-gnueabihf
Quoted 8 lines

.travis.yml matrix: · line 281

Quoted 4 lines
.travis.yml +3 -0
+            - iasl
+            - nasm
+            - uuid-dev

Regardless of what problem we're trying to address with "--quiet --silent", those options are wrong. You certainly want detailed build logs for the case a CI job fails (at build time or at runtime).

On Travis we get:

The job exceeded the maximum log length, and has been terminated.
(https://travis-ci.org/philmd/qemu/jobs/545329905)

So I moved to GitLab, but we still get:

"Job's log exceeded limit of 4194304 bytes."
(https://gitlab.com/philmd/qemu/-/jobs/230772314)

Regarding the options to pass to edk2-build.sh,

$ build --help
  -j LOGFILE, --log=LOGFILE
                   Put log in specified file as well as on console.
  -s, --silent     Make use of silent mode of (n)make.
  -q, --quiet      Disable all messages except FATAL ERRORS.
  -v, --verbose    Turn on verbose output with informational messages
                   printed, including library instances selected, final
                   dependency expression, and warning messages, etc.

'--log' duplicate the output, and I don't want to reduce the log details, so I understand I should use:

  ./edk2-build.sh [...] --log=build.log >/dev/null || cat build.log

Is that correct? But then I'd need to modify Makefile.edk2 to redirect stdout.

Quoted 5 lines

The reason why I only include DEBUG firmware builds in the edk2 bundling series is similar -- RELEASE builds lack DEBUG messages and ASSERT()s, and as such they are 100% unsupportable in my book. Bugs in software are the norm, not the exception, so we should allow (even force) the user (and remote systems) to provide as much information as they can.

Sure, we have the same book here ;)

Regards,

Phil.

#8 lore raw

Re: [Qemu-devel] [PATCH 5/5] .travis.yml: Build and install EDK2 roms

Quoted 71 lines · Philippe Mathieu-Daudé

Hi Laszlo,

Quoted 38 lines · Laszlo Ersek
Quoted 37 lines · Philippe Mathieu-Daudé

Add a job to build and install the EDK2 platform firmware binaries.

This job is only triggered if the last commit matches the EDK2 name (case insensitive), or when tag are created (such releases or release candidates).

---
 .travis.yml | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
.travis.yml +18 -0
index e942175dd3..628cc52c99 100644
@@ -258,3 +258,24 @@ matrix:
     - env:
         - CONFIG="--disable-system"
         - TEST_CMD="make -j3 check-tcg V=1"
+
+
+    # EDK2 roms builds
+    - if: tag IS present OR commit_message =~ /(edk2|EDK2)/
+      env:
+        - CONFIG="--disable-system --disable-user --prefix=$PWD/dist"
+        - EDK2_BUILD_OPTIONS="--quiet --silent"
+      script:
+        - git submodule update --init roms/edk2
+        - make -j3
+        - make -C roms efi -j2
+        - make install
+      addons:
+        apt:
+          packages:
+            - dos2unix
+            - gcc-aarch64-linux-gnu
+            - gcc-arm-linux-gnueabihf
Quoted 8 lines

.travis.yml matrix: · line 281

Quoted 4 lines
.travis.yml +3 -0
+            - iasl
+            - nasm
+            - uuid-dev

Regardless of what problem we're trying to address with "--quiet --silent", those options are wrong. You certainly want detailed build logs for the case a CI job fails (at build time or at runtime).

On Travis we get:

The job exceeded the maximum log length, and has been terminated.
(https://travis-ci.org/philmd/qemu/jobs/545329905)

So I moved to GitLab, but we still get:

"Job's log exceeded limit of 4194304 bytes."
(https://gitlab.com/philmd/qemu/-/jobs/230772314)

Regarding the options to pass to edk2-build.sh,

$ build --help
  -j LOGFILE, --log=LOGFILE
                   Put log in specified file as well as on console.
  -s, --silent     Make use of silent mode of (n)make.
  -q, --quiet      Disable all messages except FATAL ERRORS.
  -v, --verbose    Turn on verbose output with informational messages
                   printed, including library instances selected, final
                   dependency expression, and warning messages, etc.
Quoted 7 lines

'--log' duplicate the output, and I don't want to reduce the log details, so I understand I should use:

  ./edk2-build.sh [...] --log=build.log >/dev/null || cat build.log

Is that correct? But then I'd need to modify Makefile.edk2 to redirect stdout.

Would it be possible to invoke the outermost make like this?

  make -C roms -j2 efi >make.roms.efi.log 2>&1 \
  || ( tail -c 2M make.roms.efi.log; false )

Thanks
Laszlo

Quoted 13 lines
Quoted 6 lines

The reason why I only include DEBUG firmware builds in the edk2 bundling series is similar -- RELEASE builds lack DEBUG messages and ASSERT()s, and as such they are 100% unsupportable in my book. Bugs in software are the norm, not the exception, so we should allow (even force) the user (and remote systems) to provide as much information as they can.

Sure, we have the same book here ;)

Regards,

Phil.

#9 lore raw

Re: [Qemu-devel] [PATCH 5/5] .travis.yml: Build and install EDK2 roms

In reply to Philippe Mathieu-Daudé
Quoted 71 lines · Philippe Mathieu-Daudé

Hi Laszlo,

Quoted 38 lines · Laszlo Ersek
Quoted 37 lines · Philippe Mathieu-Daudé

Add a job to build and install the EDK2 platform firmware binaries.

This job is only triggered if the last commit matches the EDK2 name (case insensitive), or when tag are created (such releases or release candidates).

---
 .travis.yml | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
.travis.yml +18 -0
index e942175dd3..628cc52c99 100644
@@ -258,3 +258,24 @@ matrix:
     - env:
         - CONFIG="--disable-system"
         - TEST_CMD="make -j3 check-tcg V=1"
+
+
+    # EDK2 roms builds
+    - if: tag IS present OR commit_message =~ /(edk2|EDK2)/
+      env:
+        - CONFIG="--disable-system --disable-user --prefix=$PWD/dist"
+        - EDK2_BUILD_OPTIONS="--quiet --silent"
+      script:
+        - git submodule update --init roms/edk2
+        - make -j3
+        - make -C roms efi -j2
+        - make install
+      addons:
+        apt:
+          packages:
+            - dos2unix
+            - gcc-aarch64-linux-gnu
+            - gcc-arm-linux-gnueabihf
Quoted 8 lines

.travis.yml matrix: · line 281

Quoted 4 lines
.travis.yml +3 -0
+            - iasl
+            - nasm
+            - uuid-dev

Regardless of what problem we're trying to address with "--quiet --silent", those options are wrong. You certainly want detailed build logs for the case a CI job fails (at build time or at runtime).

On Travis we get:

The job exceeded the maximum log length, and has been terminated.
(https://travis-ci.org/philmd/qemu/jobs/545329905)

So I moved to GitLab, but we still get:

"Job's log exceeded limit of 4194304 bytes."
(https://gitlab.com/philmd/qemu/-/jobs/230772314)

Regarding the options to pass to edk2-build.sh,

$ build --help
  -j LOGFILE, --log=LOGFILE
                   Put log in specified file as well as on console.
  -s, --silent     Make use of silent mode of (n)make.
  -q, --quiet      Disable all messages except FATAL ERRORS.
  -v, --verbose    Turn on verbose output with informational messages
                   printed, including library instances selected, final
                   dependency expression, and warning messages, etc.
Quoted 7 lines

'--log' duplicate the output, and I don't want to reduce the log details, so I understand I should use:

  ./edk2-build.sh [...] --log=build.log >/dev/null || cat build.log

Is that correct? But then I'd need to modify Makefile.edk2 to redirect stdout.

Would it be possible to invoke the outermost make like this?

  make -C roms -j2 efi >make.roms.efi.log 2>&1 \
  || ( tail -c 2M make.roms.efi.log; false )

Thanks
Laszlo

Quoted 13 lines
Quoted 6 lines

The reason why I only include DEBUG firmware builds in the edk2 bundling series is similar -- RELEASE builds lack DEBUG messages and ASSERT()s, and as such they are 100% unsupportable in my book. Bugs in software are the norm, not the exception, so we should allow (even force) the user (and remote systems) to provide as much information as they can.

Sure, we have the same book here ;)

Regards,

Phil.

#10 lore raw

Re: [Qemu-devel] [PATCH 5/5] .travis.yml: Build and install EDK2 roms

Quoted 77 lines · Laszlo Ersek
Quoted 76 lines · Philippe Mathieu-Daudé

Hi Laszlo,

Quoted 38 lines · Laszlo Ersek
Quoted 37 lines · Philippe Mathieu-Daudé

Add a job to build and install the EDK2 platform firmware binaries.

This job is only triggered if the last commit matches the EDK2 name (case insensitive), or when tag are created (such releases or release candidates).

---
 .travis.yml | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
.travis.yml +18 -0
index e942175dd3..628cc52c99 100644
@@ -258,3 +258,24 @@ matrix:
     - env:
         - CONFIG="--disable-system"
         - TEST_CMD="make -j3 check-tcg V=1"
+
+
+    # EDK2 roms builds
+    - if: tag IS present OR commit_message =~ /(edk2|EDK2)/
+      env:
+        - CONFIG="--disable-system --disable-user --prefix=$PWD/dist"
+        - EDK2_BUILD_OPTIONS="--quiet --silent"
+      script:
+        - git submodule update --init roms/edk2
+        - make -j3
+        - make -C roms efi -j2
+        - make install
+      addons:
+        apt:
+          packages:
+            - dos2unix
+            - gcc-aarch64-linux-gnu
+            - gcc-arm-linux-gnueabihf
Quoted 8 lines

.travis.yml matrix: · line 281

Quoted 4 lines
.travis.yml +3 -0
+            - iasl
+            - nasm
+            - uuid-dev

Regardless of what problem we're trying to address with "--quiet --silent", those options are wrong. You certainly want detailed build logs for the case a CI job fails (at build time or at runtime).

On Travis we get:

The job exceeded the maximum log length, and has been terminated.
(https://travis-ci.org/philmd/qemu/jobs/545329905)

So I moved to GitLab, but we still get:

"Job's log exceeded limit of 4194304 bytes."
(https://gitlab.com/philmd/qemu/-/jobs/230772314)

Regarding the options to pass to edk2-build.sh,

$ build --help
  -j LOGFILE, --log=LOGFILE
                   Put log in specified file as well as on console.
  -s, --silent     Make use of silent mode of (n)make.
  -q, --quiet      Disable all messages except FATAL ERRORS.
  -v, --verbose    Turn on verbose output with informational messages
                   printed, including library instances selected, final
                   dependency expression, and warning messages, etc.

'--log' duplicate the output, and I don't want to reduce the log details, so I understand I should use:

  ./edk2-build.sh [...] --log=build.log >/dev/null || cat build.log
Quoted 7 lines
Quoted 2 lines

Is that correct? But then I'd need to modify Makefile.edk2 to redirect stdout.

Would it be possible to invoke the outermost make like this?

  make -C roms -j2 efi >make.roms.efi.log 2>&1 \
  || ( tail -c 2M make.roms.efi.log; false )

Or something like:

after_failure:
- tail -c 2M make.roms.efi.log

as Cleber suggested for his acceptance tests. Generally we want to try and make the builds less noisy and only echo relevant details when it fails. However we've tended to turn up the noise so we can debug stuff and that is just painful to browser on the Travis website.

Quoted 17 lines

Thanks
Laszlo

Quoted 13 lines
Quoted 6 lines

The reason why I only include DEBUG firmware builds in the edk2 bundling series is similar -- RELEASE builds lack DEBUG messages and ASSERT()s, and as such they are 100% unsupportable in my book. Bugs in software are the norm, not the exception, so we should allow (even force) the user (and remote systems) to provide as much information as they can.

Sure, we have the same book here ;)

Regards,

Phil.

--
Alex Bennée

#11 lore raw

Re: [PATCH 5/5] .travis.yml: Build and install EDK2 roms

Quoted 78 lines · Alex Bennée
Quoted 77 lines · Laszlo Ersek
Quoted 76 lines · Philippe Mathieu-Daudé

Hi Laszlo,

Quoted 38 lines · Laszlo Ersek
Quoted 37 lines · Philippe Mathieu-Daudé

Add a job to build and install the EDK2 platform firmware binaries.

This job is only triggered if the last commit matches the EDK2 name (case insensitive), or when tag are created (such releases or release candidates).

---
 .travis.yml | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
.travis.yml +18 -0
index e942175dd3..628cc52c99 100644
@@ -258,3 +258,24 @@ matrix:
     - env:
         - CONFIG="--disable-system"
         - TEST_CMD="make -j3 check-tcg V=1"
+
+
+    # EDK2 roms builds
+    - if: tag IS present OR commit_message =~ /(edk2|EDK2)/
+      env:
+        - CONFIG="--disable-system --disable-user --prefix=$PWD/dist"
+        - EDK2_BUILD_OPTIONS="--quiet --silent"
+      script:
+        - git submodule update --init roms/edk2
+        - make -j3
+        - make -C roms efi -j2
+        - make install
+      addons:
+        apt:
+          packages:
+            - dos2unix
+            - gcc-aarch64-linux-gnu
+            - gcc-arm-linux-gnueabihf
Quoted 8 lines

.travis.yml matrix: · line 281

Quoted 4 lines
.travis.yml +3 -0
+            - iasl
+            - nasm
+            - uuid-dev

Regardless of what problem we're trying to address with "--quiet --silent", those options are wrong. You certainly want detailed build logs for the case a CI job fails (at build time or at runtime).

On Travis we get:

The job exceeded the maximum log length, and has been terminated.
(https://travis-ci.org/philmd/qemu/jobs/545329905)

So I moved to GitLab, but we still get:

"Job's log exceeded limit of 4194304 bytes."
(https://gitlab.com/philmd/qemu/-/jobs/230772314)

Regarding the options to pass to edk2-build.sh,

$ build --help
  -j LOGFILE, --log=LOGFILE
                   Put log in specified file as well as on console.
  -s, --silent     Make use of silent mode of (n)make.
  -q, --quiet      Disable all messages except FATAL ERRORS.
  -v, --verbose    Turn on verbose output with informational messages
                   printed, including library instances selected, final
                   dependency expression, and warning messages, etc.

'--log' duplicate the output, and I don't want to reduce the log details, so I understand I should use:

  ./edk2-build.sh [...] --log=build.log >/dev/null || cat build.log
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines

Is that correct? But then I'd need to modify Makefile.edk2 to redirect stdout.

Would it be possible to invoke the outermost make like this?

  make -C roms -j2 efi >make.roms.efi.log 2>&1 \
  || ( tail -c 2M make.roms.efi.log; false )

The build gets killed:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. Check the details on how to adjust your build configuration on:

https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

The build has been terminated

Quoted 9 lines

Or something like:

after_failure:
- tail -c 2M make.roms.efi.log

as Cleber suggested for his acceptance tests. Generally we want to try and make the builds less noisy and only echo relevant details when it fails. However we've tended to turn up the noise so we can debug stuff and that is just painful to browser on the Travis website.

I'll try that.

Quoted 15 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

The reason why I only include DEBUG firmware builds in the edk2 bundling series is similar -- RELEASE builds lack DEBUG messages and ASSERT()s, and as such they are 100% unsupportable in my book. Bugs in software are the norm, not the exception, so we should allow (even force) the user (and remote systems) to provide as much information as they can.

Quoted 6 lines
Quoted 6 lines

Sure, we have the same book here ;)

Regards,

Phil.

--
Alex Bennée