Skip to contentSkip to conversation

grundler

parisc-linux-cvs Philipp Rumpf 2 participants 2 messages Sep 2, 1999 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 5 lines · On Wed, Sep 01, 1999 at 05:02:23PM -0600, [email protected] wrote:

Update of /home/cvs/parisc/linux/drivers/gecko
In directory puffin.external.hp.com:/tmp/cvs-serv4014/linux/drivers/gecko

Modified Files:
dino.c

okay, let's go through the changes here too:

- strange STATIC define with a comment about "performance" kernels.

I don't see the point. Is there one ?

- use of irq_t all over the place

I don't mind this, but it really doesn't matter and just using int has the advantage of still being able to printk it.

- Dino-specific IRQ management

As far as I am concerned, there is no way I want to have 5 different IRQ managements in the kernel. It is not needed, the performance loss is minimal, I don't see any other advantages to it. (I just skipped that code so you don't get all my complaints)

- #if 0-ing out dino_walk_bus

remove it. we really don't need any #if 0 bodies swimming around our trees.

- check for potentially defect Dino chips

Nothing negative I can say about that

- +** TODO: Dino needs a method to look at and possibly "claim" GSC devices.

it's what you #if 0-ed out. (

        struct gsc_dev *dev = gsc_devices;

	while(dev = dev->next) {
		if(is_dino(dev)) {
			blah blah 
		}
	}

).

- split dino init into two parts

I don't see the point.

- changes to dino_config_write_byte aso (renaming them in the process)

Is this for supporting more than one PCI bus via pci-to-pci bridges ? looks unnecessary to me, but I really don't know

- +** Performance is going to stink if drivers use I/O port instead +** of MMIO.

This is not Dino-specific.

- use of readb aso instead of gsc_readb aso

gsc_readb is there for a reason.

Philipp Rumpf

#2 lore raw
Quoted 3 lines · Philipp Rumpf

- use of readb aso instead of gsc_readb aso

gsc_readb is there for a reason.

Let me amplify on this a little. As I understand it, Linus has decreed that readb/writeb/(etc) shall work on busses which `look like PCI'. All other busses (zorro, podule, sbus, ...) shall define their own *_readb/writeb/... functions. People have proposed auto-detecting which bus is being written to and doing the right thing, but Linus disagrees. So that's why we have gsc_readb, because GSC looks insufficiently like PCI. Does this make sense?

Signature · 4 lines
Matthew Wilcox <[email protected]>
"Windows and MacOS are products, contrived by engineers in the service of
specific companies. Unix, by contrast, is not so much a product as it is a
painstakingly compiled oral history of the hacker subculture." - N Stephenson