Skip to contentSkip to conversation

Missing directories from CVS

parisc-linux Ryan Bradetich 4 participants 6 messages Sep 23, 1999 – Sep 24, 1999

lore
Share & tools
lore
#0 lore raw

Alex:

The following directories seem to be missing from the CVS repository:

drivers/isdn/eicon
drivers/isdn/divert
drivers/usb
fs/efs
net/irda

-Ryan

#1 lore raw
Quoted 9 lines · Ryan Bradetich

Alex:

The following directories seem to be missing from the CVS repository:

drivers/isdn/eicon
drivers/isdn/divert
drivers/usb
fs/efs
net/irda

Yeah...I complained to Alex about this yesterday already. And guess what? He fixed it! (kudos!)
You should try again...

I did a checkout, make config (for 715), make dep. (make vmlinux is still running)

gcc is used to build scripts/mkdep, scripts/split-include and bin2hex. The only thing I'm missing is native "gcc". I don't have a native "gcc" since I don't want to be confused about what's native and what's cross-environment. So I built those items by hand with "cc".

Oh yeah...don't forget to ftp the ramdisk.bin if you start from scratch like I did.

cheers,
grant

Grant Grundler
Communications Infrastructure Computer Operations
+1.408.447.7253

#2 lore raw

Grant Grundler wrote:
...

Quoted 2 lines

I did a checkout, make config (for 715), make dep. (make vmlinux is still running)

vmlinux built shortly after I posted...

Quoted 1 line

gcc is used to build scripts/mkdep, scripts/split-include and bin2hex.

Add one more to the list: arch/parisc/boot/mkImage

And on this one "cc" gets picky about pointer math. Here's my diff for mkImage.c:

118c118
< *entry_point = *(unsigned long*)(ptr + 6*sizeof(long));
---

Quoted 1 line
    *entry_point = *(unsigned long*)((char *)ptr + 6*sizeof(long));

131,132c131,132
< short magic = *(short *)(ptr+sizeof(short));
< long *arr = (unsigned long *)ptr;
---

Quoted 2 lines
    short magic = *(short *)((char *)ptr+sizeof(short));
    long *arr         = (long *)ptr;

Any objections to committing this change?

On second thought, both changes should be written as:

	*entry_point = ((unsigned long *)ptr)[6];
and	
	short magic = ((short *)ptr)[1];

thanks,
grant

#3 lore raw
Quoted 6 lines

And on this one "cc" gets picky about pointer math. Here's my diff for mkImage.c:

< *entry_point = *(unsigned long*)(ptr + 6*sizeof(long));
---

Quoted 1 line
    *entry_point = *(unsigned long*)((char *)ptr + 6*sizeof(long));

OK, so I'm too lazy to go look... what type is ptr? I'd guess that it's declared void*, since that's the only way the pointer math could work in gcc and not in HP-cc.

Quoted 5 lines

Any objections to committing this change?
On second thought, both changes should be written as:

	*entry_point = ((unsigned long *)ptr)[6];
and	
	short magic = ((short *)ptr)[1];

How about just using filehdr.h, or copying struct header from it, and using the real structure...? (I think we've released the format enough that we could clone the structure, failing that:

  struct header {
	unsigned short magic;
	short fill0;
	long fill[5];
	unsigned long entry_point;

};
will fit the bill quite nicely.

LaMont "I hate magic offsets" Jones

#4 lore raw

Am Thu, 23 Sep 1999 schrieb LaMont Jones:

Quoted 9 lines
Quoted 6 lines

And on this one "cc" gets picky about pointer math. Here's my diff for mkImage.c:

< *entry_point = *(unsigned long*)(ptr + 6*sizeof(long));
---

Quoted 1 line
    *entry_point = *(unsigned long*)((char *)ptr + 6*sizeof(long));

OK, so I'm too lazy to go look... what type is ptr? I'd guess that it's declared void*, since that's the only way the pointer math could work in gcc and not in HP-cc.

Yes.

Quoted 10 lines
Quoted 6 lines

Any objections to committing this change?
On second thought, both changes should be written as:

	*entry_point = ((unsigned long *)ptr)[6];
and	
	short magic = ((short *)ptr)[1];

How about just using filehdr.h, or copying struct header from it, and using the real structure...? (I think we've released the format enough that we could clone the structure, failing that:

Quoted 7 lines
  struct header {
	unsigned short magic;
	short fill0;
	long fill[5];
	unsigned long entry_point;

};
will fit the bill quite nicely.

Yes, I think this would be the best solution. When I wrote the program, I tried to include the header-files som.h and elf.h, but then I always got different errors from every of the arch-compilers (iA32 or hpux). So maybe it is best to use the structure as above and write the structure-layout directly into the source.
Does someone want to fill it in and commit it ?

Quoted 2 lines

LaMont "I hate magic offsets" Jones

Helge "master of bad pointer arithmetic" Deller :-)

#5 lore raw
Quoted 6 lines

Yes, I think this would be the best solution. When I wrote the program, I tri to include the header-files som.h and elf.h, but then I always got different errors from every of the arch-compilers (iA32 or hpux). So maybe i is best to use the structure as above and write the structure-layout directly into the source.
Does someone want to fill it in and commit it ?

I'm already working with Grant on doing just that, but it'll probably be this weekend at the earliest...

lamont