Skip to contentSkip to conversation

PPC scr_{read,write}w() cleanup (fwd)

DISCUSSION Geert Uytterhoeven 2 participants 3 messages Oct 29, 1999 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 2 lines · Cort Dougan

The problem here is with the common build where we build in both vgacon and fb.

What's the problem there? If vgacon is enabled, scr_write() will be writew(), i.e. little endian. But since scr_readw() == readw() is little endian as well, it'll work fine.

Or am I missing something?

Quoted 2 lines

I'm willing to switch PReP to fb entirely if it's reasonable that it will work on all PReP boxes. Any suggestions?

I don't think it will work on all PReP boxes yet. There's no frame buffer device for S3 [89]6[48] yet :-(

Quoted 9 lines

} Does this work on your boxes? I really like to have this fixed.
}
} Finally I found some time to sort out the PPC scr_{read,write}w() mess. } Now scr_{read,write}w() always swaps bytes if {vga,mda}con was compiled in, } while we did a runtime check before.
}
} This patch matters specifically for people with PReP boxes, who may want to use } vgacon on one head and a real frame buffer device on either a second head or on } the first head after boot up (insmod *fb.o takes over vgacon).

    [...]

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven ----------------- Sony Suprastructure Center Europe (SUPC-E) [email protected] ------------------- Sint-Stevens-Woluwestraat 55 Phone +32-2-7248632 Fax +32-2-7262686 ---------------- B-1130 Brussels, Belgium

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

#2 lore raw

Maybe I'm confused. If so, point out where I'm wrong here:

We build in VGA_CONSOLE and FB for a common build. We end up getting the wrong scr_read/write if we end up using the wrong one (through vt_buffer.h).

Will vt_buffer.h "do the right thing" in this case?

} What's the problem there? If vgacon is enabled, scr_write() will be writew(), } i.e. little endian. But since scr_readw() == readw() is little endian as well, } it'll work fine.
}
} Or am I missing something?
}
} > I'm willing to switch PReP to fb entirely if it's reasonable that it will } > work on all PReP boxes. Any suggestions?
}
} I don't think it will work on all PReP boxes yet. There's no frame buffer } device for S3 [89]6[48] yet :-(
}
} > } Does this work on your boxes? I really like to have this fixed.
} > }
} > } Finally I found some time to sort out the PPC scr_{read,write}w() mess. } > } Now scr_{read,write}w() always swaps bytes if {vga,mda}con was compiled in, } > } while we did a runtime check before.
} > }
} > } This patch matters specifically for people with PReP boxes, who may want to use } > } vgacon on one head and a real frame buffer device on either a second head or on } > } the first head after boot up (insmod *fb.o takes over vgacon).
}
} [...]
}
} Gr{oetje,eeting}s,
}
} Geert
}
} --
} Geert Uytterhoeven ----------------- Sony Suprastructure Center Europe (SUPC-E) } [email protected] ------------------- Sint-Stevens-Woluwestraat 55 } Phone +32-2-7248632 Fax +32-2-7262686 ---------------- B-1130 Brussels, Belgium

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

#3 lore raw
Quoted 7 lines · Cort Dougan

Maybe I'm confused. If so, point out where I'm wrong here:

We build in VGA_CONSOLE and FB for a common build. We end up getting the wrong scr_read/write if we end up using the wrong one (through vt_buffer.h).

Will vt_buffer.h "do the right thing" in this case?

I think so: vt_buffer.h includes asm/vga.h first if CONFIG_VGA_CONSOLE or CONFIG_MDA_CONSOLE are set.

Quoted 13 lines

} What's the problem there? If vgacon is enabled, scr_write() will be writew(), } i.e. little endian. But since scr_readw() == readw() is little endian as well, } it'll work fine.
}
} Or am I missing something?
}
} > I'm willing to switch PReP to fb entirely if it's reasonable that it will } > work on all PReP boxes. Any suggestions?
}
} I don't think it will work on all PReP boxes yet. There's no frame buffer } device for S3 [89]6[48] yet :-(
}
} > } Does this work on your boxes? I really like to have this fixed.

Quoted 8 lines

} > }
} > } Finally I found some time to sort out the PPC scr_{read,write}w() mess. } > } Now scr_{read,write}w() always swaps bytes if {vga,mda}con was compiled in, } > } while we did a runtime check before.
} > }
} > } This patch matters specifically for people with PReP boxes, who may want to use } > } vgacon on one head and a real frame buffer device on either a second head or on } > } the first head after boot up (insmod *fb.o takes over vgacon).

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven ----------------- Sony Suprastructure Center Europe (SUPC-E) [email protected] ------------------- Sint-Stevens-Woluwestraat 55 Phone +32-2-7248632 Fax +32-2-7262686 ---------------- B-1130 Brussels, Belgium

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/