Skip to contentSkip to conversation

ARM: shmobile: uImage load address rework

PATCH New Magnus Damm 4 participants 24 messages Jun 5, 2013 – Jun 6, 2013

Subsystems (4)
Arm (32-bit) Arm sub-architectures SuperH Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Magnus Damm

author maintainer
#0 lore raw

cover ARM: shmobile: uImage load address rework

ARM: shmobile: uImage load address rework

[PATCH 01/15] ARM: shmobile: Per-board uImage load addresses [PATCH 02/15] ARM: shmobile: AG5EVM uImage rework
[PATCH 03/15] ARM: shmobile: AP4EVB uImage rework
[PATCH 04/15] ARM: shmobile: APE6EVM uImage rework
[PATCH 05/15] ARM: shmobile: Armadillo800EVA uImage rework [PATCH 06/15] ARM: shmobile: Bock-W uImage rework
[PATCH 07/15] ARM: shmobile: Bonito uImage rework
[PATCH 08/15] ARM: shmobile: KZM9D uImage rework
[PATCH 09/15] ARM: shmobile: KZM9G uImage rework
[PATCH 10/15] ARM: shmobile: Kota2 uImage rework
[PATCH 11/15] ARM: shmobile: Lager uImage rework
[PATCH 12/15] ARM: shmobile: Mackerel uImage rework [PATCH 13/15] ARM: shmobile: Marzen uImage rework
[PATCH 14/15] ARM: shmobile: Armadillo800EVA reference uImage rework [PATCH 15/15] ARM: shmobile: Remove MEMORY_START uImage load address

Rework the mach-shmobile uImage load address calculation by storing the per-board load addresses in Makefile.boot. This removes the CONFIG_MEMORY_START dependency from Makefile.boot, and it also makes it possible to create safe kernel images that boot on multiple boards.

This is one of several series of code that reworks code not to rely on CONFIG_MEMORY_START/SIZE which in turn is needed for ARCH_MULTIPLATFORM.

Signed-off-by Magnus Damm <[email protected]>

---

Written against renesas.git renesas-next-20130604v2

 arch/arm/mach-shmobile/Makefile.boot |   26 ++++++++++++++++++++++----
 1 file changed, 22 insertions(+), 4 deletions(-)
author maintainer
#1 lore raw

PATCH 1/15 ARM: shmobile: Per-board uImage load addresses

From: Magnus Damm <[email protected]>

Introduce per-board uImage load address calculation.

This will allow us to use the same uImage for multiple boards if the load address happens to match. For now keep on using CONFIG_MEMORY_START.

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Makefile.boot |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
arch/arm/mach-shmobile/Makefile.boot +4 -1
@@ -1,6 +1,9 @@
-__ZRELADDR	:= $(shell /bin/bash -c 'printf "0x%08x" \
+loadaddr-y	:= $(shell /bin/bash -c 'printf "0x%08x" \
 		     $$[$(CONFIG_MEMORY_START) + 0x8000]')
 
+__ZRELADDR	:= $(shell /bin/bash -c \
+		     'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
+
    zreladdr-y   += $(__ZRELADDR)
 
 # Unsupported legacy stuff
#2 lore raw

PATCH 1/15 ARM: shmobile: Per-board uImage load addresses

arch/arm/mach-shmobile/Makefile.boot line 6

Quoted 4 lines · On Wednesday 05 June 2013 16:06:25 Magnus Damm wrote:
arch/arm/mach-shmobile/Makefile.boot +3 -0
+__ZRELADDR     := $(shell /bin/bash -c \
+                    'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
+

It's not important, but I think this can be written much simpler using makefile syntax as

__ZRELADDR := $(sort $(loadaddr-y))

Arnd

author maintainer
#3 lore raw

PATCH 1/15 ARM: shmobile: Per-board uImage load addresses

Hi Arnd,

Quoted 10 lines · Arnd Bergmann

arch/arm/mach-shmobile/Makefile.boot line 6

Quoted 4 lines · On Wednesday 05 June 2013 16:06:25 Magnus Damm wrote:
arch/arm/mach-shmobile/Makefile.boot +3 -0
+__ZRELADDR     := $(shell /bin/bash -c \
+                    'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
+

It's not important, but I think this can be written much simpler using makefile syntax as

__ZRELADDR := $(sort $(loadaddr-y))

Yes, correct. Just double checked by comparing the output. Your proposal is much cleaner, will follow that if/when I send a V2.

Thanks,

/ magnus

author maintainer
#4 lore raw

PATCH 2/15 ARM: shmobile: AG5EVM uImage rework

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add AG5EVM specific load address to Makefile.boot

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Makefile.boot |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-shmobile/Makefile.boot +2 -0
@@ -1,6 +1,8 @@
 loadaddr-y	:= $(shell /bin/bash -c 'printf "0x%08x" \
 		     $$[$(CONFIG_MEMORY_START) + 0x8000]')
 
+loadaddr-$(CONFIG_MACH_AG5EVM) += 0x40008000
+
 __ZRELADDR	:= $(shell /bin/bash -c \
 		     'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
author maintainer
#5 lore raw

PATCH 3/15 ARM: shmobile: AP4EVB uImage rework

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add AP4EVB specific load address to Makefile.boot

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Makefile.boot |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-shmobile/Makefile.boot +1 -0
@@ -2,6 +2,7 @@ loadaddr-y	:= $(shell /bin/bash -c 'prin
 		     $$[$(CONFIG_MEMORY_START) + 0x8000]')
 
 loadaddr-$(CONFIG_MACH_AG5EVM) += 0x40008000
+loadaddr-$(CONFIG_MACH_AP4EVB) += 0x40008000
 
 __ZRELADDR	:= $(shell /bin/bash -c \
 		     'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
author maintainer
#6 lore raw

PATCH 4/15 ARM: shmobile: APE6EVM uImage rework

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add APE6EVM specific load address to Makefile.boot

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Makefile.boot |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-shmobile/Makefile.boot +1 -0
@@ -3,6 +3,7 @@ loadaddr-y	:= $(shell /bin/bash -c 'prin
 
 loadaddr-$(CONFIG_MACH_AG5EVM) += 0x40008000
 loadaddr-$(CONFIG_MACH_AP4EVB) += 0x40008000
+loadaddr-$(CONFIG_MACH_APE6EVM) += 0x40008000
 
 __ZRELADDR	:= $(shell /bin/bash -c \
 		     'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
author maintainer
#7 lore raw

PATCH 5/15 ARM: shmobile: Armadillo800EVA uImage rework

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add Armadillo800EVA specific load address to Makefile.boot

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Makefile.boot |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-shmobile/Makefile.boot +1 -0
@@ -4,6 +4,7 @@ loadaddr-y	:= $(shell /bin/bash -c 'prin
 loadaddr-$(CONFIG_MACH_AG5EVM) += 0x40008000
 loadaddr-$(CONFIG_MACH_AP4EVB) += 0x40008000
 loadaddr-$(CONFIG_MACH_APE6EVM) += 0x40008000
+loadaddr-$(CONFIG_MACH_ARMADILLO800EVA) += 0x40008000
 
 __ZRELADDR	:= $(shell /bin/bash -c \
 		     'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
author maintainer
#8 lore raw

PATCH 6/15 ARM: shmobile: Bock-W uImage rework

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add Bock-W specific load address to Makefile.boot

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Makefile.boot |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-shmobile/Makefile.boot +1 -0
@@ -5,6 +5,7 @@ loadaddr-$(CONFIG_MACH_AG5EVM) += 0x4000
 loadaddr-$(CONFIG_MACH_AP4EVB) += 0x40008000
 loadaddr-$(CONFIG_MACH_APE6EVM) += 0x40008000
 loadaddr-$(CONFIG_MACH_ARMADILLO800EVA) += 0x40008000
+loadaddr-$(CONFIG_MACH_BOCKW) += 0x60008000
 
 __ZRELADDR	:= $(shell /bin/bash -c \
 		     'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
author maintainer
#9 lore raw

PATCH 7/15 ARM: shmobile: Bonito uImage rework

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add Bonito specific load address to Makefile.boot

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Makefile.boot |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-shmobile/Makefile.boot +1 -0
@@ -6,6 +6,7 @@ loadaddr-$(CONFIG_MACH_AP4EVB) += 0x4000
 loadaddr-$(CONFIG_MACH_APE6EVM) += 0x40008000
 loadaddr-$(CONFIG_MACH_ARMADILLO800EVA) += 0x40008000
 loadaddr-$(CONFIG_MACH_BOCKW) += 0x60008000
+loadaddr-$(CONFIG_MACH_BONITO) += 0x40008000
 
 __ZRELADDR	:= $(shell /bin/bash -c \
 		     'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
author maintainer
#10 lore raw

PATCH 8/15 ARM: shmobile: KZM9D uImage rework

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add KZM9D specific load address to Makefile.boot

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Makefile.boot |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-shmobile/Makefile.boot +1 -0
@@ -7,6 +7,7 @@ loadaddr-$(CONFIG_MACH_APE6EVM) += 0x400
 loadaddr-$(CONFIG_MACH_ARMADILLO800EVA) += 0x40008000
 loadaddr-$(CONFIG_MACH_BOCKW) += 0x60008000
 loadaddr-$(CONFIG_MACH_BONITO) += 0x40008000
+loadaddr-$(CONFIG_MACH_KZM9D) += 0x40008000
 
 __ZRELADDR	:= $(shell /bin/bash -c \
 		     'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
author maintainer
#11 lore raw

PATCH 9/15 ARM: shmobile: KZM9G uImage rework

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add KZM9G specific load addresses to Makefile.boot, both the C version of the code is covered as well as the DT -reference code.

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Makefile.boot |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-shmobile/Makefile.boot +2 -0
@@ -8,6 +8,8 @@ loadaddr-$(CONFIG_MACH_ARMADILLO800EVA)
 loadaddr-$(CONFIG_MACH_BOCKW) += 0x60008000
 loadaddr-$(CONFIG_MACH_BONITO) += 0x40008000
 loadaddr-$(CONFIG_MACH_KZM9D) += 0x40008000
+loadaddr-$(CONFIG_MACH_KZM9G) += 0x41008000
+loadaddr-$(CONFIG_MACH_KZM9G_REFERENCE) += 0x41008000
 
 __ZRELADDR	:= $(shell /bin/bash -c \
 		     'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
author maintainer
#12 lore raw

PATCH 10/15 ARM: shmobile: Kota2 uImage rework

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add Kota2 specific load address to Makefile.boot

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Makefile.boot |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-shmobile/Makefile.boot +1 -0
@@ -7,6 +7,7 @@ loadaddr-$(CONFIG_MACH_APE6EVM) += 0x400
 loadaddr-$(CONFIG_MACH_ARMADILLO800EVA) += 0x40008000
 loadaddr-$(CONFIG_MACH_BOCKW) += 0x60008000
 loadaddr-$(CONFIG_MACH_BONITO) += 0x40008000
+loadaddr-$(CONFIG_MACH_KOTA2) += 0x41008000
 loadaddr-$(CONFIG_MACH_KZM9D) += 0x40008000
 loadaddr-$(CONFIG_MACH_KZM9G) += 0x41008000
 loadaddr-$(CONFIG_MACH_KZM9G_REFERENCE) += 0x41008000
author maintainer
#13 lore raw

PATCH 11/15 ARM: shmobile: Lager uImage rework

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add Lager specific load address to Makefile.boot

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Makefile.boot |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-shmobile/Makefile.boot +1 -0
@@ -11,6 +11,7 @@ loadaddr-$(CONFIG_MACH_KOTA2) += 0x41008
 loadaddr-$(CONFIG_MACH_KZM9D) += 0x40008000
 loadaddr-$(CONFIG_MACH_KZM9G) += 0x41008000
 loadaddr-$(CONFIG_MACH_KZM9G_REFERENCE) += 0x41008000
+loadaddr-$(CONFIG_MACH_LAGER) += 0x40008000
 
 __ZRELADDR	:= $(shell /bin/bash -c \
 		     'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
author maintainer
#14 lore raw

PATCH 12/15 ARM: shmobile: Mackerel uImage rework

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add Mackerel specific load address to Makefile.boot

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Makefile.boot |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-shmobile/Makefile.boot +1 -0
@@ -12,6 +12,7 @@ loadaddr-$(CONFIG_MACH_KZM9D) += 0x40008
 loadaddr-$(CONFIG_MACH_KZM9G) += 0x41008000
 loadaddr-$(CONFIG_MACH_KZM9G_REFERENCE) += 0x41008000
 loadaddr-$(CONFIG_MACH_LAGER) += 0x40008000
+loadaddr-$(CONFIG_MACH_MACKEREL) += 0x40008000
 
 __ZRELADDR	:= $(shell /bin/bash -c \
 		     'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
author maintainer
#15 lore raw

PATCH 13/15 ARM: shmobile: Marzen uImage rework

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add Marzen specific load addresses to Makefile.boot, both the C version of the code is covered as well as the DT -reference code.

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Makefile.boot |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-shmobile/Makefile.boot +2 -0
@@ -13,6 +13,8 @@ loadaddr-$(CONFIG_MACH_KZM9G) += 0x41008
 loadaddr-$(CONFIG_MACH_KZM9G_REFERENCE) += 0x41008000
 loadaddr-$(CONFIG_MACH_LAGER) += 0x40008000
 loadaddr-$(CONFIG_MACH_MACKEREL) += 0x40008000
+loadaddr-$(CONFIG_MACH_MARZEN) += 0x60008000
+loadaddr-$(CONFIG_MACH_MARZEN_REFERENCE) += 0x60008000
 
 __ZRELADDR	:= $(shell /bin/bash -c \
 		     'echo $(loadaddr-y) | tr " " "\n" | sort | uniq')
author maintainer
#16 lore raw

PATCH 14/15 ARM: shmobile: Armadillo800EVA reference uImage rework

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Add uImage load address to Makefile.boot for the recently added Armadillo800EVA DT Reference code

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Makefile.boot |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-shmobile/Makefile.boot +1 -0
@@ -4,6 +4,7 @@ loadaddr-$(CONFIG_MACH_AG5EVM) += 0x4000
 loadaddr-$(CONFIG_MACH_AP4EVB) += 0x40008000
 loadaddr-$(CONFIG_MACH_APE6EVM) += 0x40008000
 loadaddr-$(CONFIG_MACH_ARMADILLO800EVA) += 0x40008000
+loadaddr-$(CONFIG_MACH_ARMADILLO800EVA_REFERENCE) += 0x40008000
 loadaddr-$(CONFIG_MACH_BOCKW) += 0x60008000
 loadaddr-$(CONFIG_MACH_BONITO) += 0x40008000
 loadaddr-$(CONFIG_MACH_KOTA2) += 0x41008000
author maintainer
#17 lore raw

PATCH 15/15 ARM: shmobile: Remove MEMORY_START uImage load address

In reply to Magnus Damm

From: Magnus Damm <[email protected]>

Remove the CONFIG_MEMORY_START dependency in Makefile.boot now when we keep track of board specific load addresses.

Signed-off-by Magnus Damm <[email protected]>

---

 arch/arm/mach-shmobile/Makefile.boot |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/arm/mach-shmobile/Makefile.boot +2 -3
@@ -1,6 +1,5 @@
-loadaddr-y	:= $(shell /bin/bash -c 'printf "0x%08x" \
-		     $$[$(CONFIG_MEMORY_START) + 0x8000]')
-
+# per-board load address for uImage
+loadaddr-y	:=
 loadaddr-$(CONFIG_MACH_AG5EVM) += 0x40008000
 loadaddr-$(CONFIG_MACH_AP4EVB) += 0x40008000
 loadaddr-$(CONFIG_MACH_APE6EVM) += 0x40008000
#18 lore raw

cover ARM: shmobile: uImage load address rework

In reply to Magnus Damm

Hi Magnus,

Quoted 18 lines · On Wednesday 05 June 2013 16:06:16 Magnus Damm wrote:

ARM: shmobile: uImage load address rework

[PATCH 01/15] ARM: shmobile: Per-board uImage load addresses [PATCH 02/15] ARM: shmobile: AG5EVM uImage rework
[PATCH 03/15] ARM: shmobile: AP4EVB uImage rework
[PATCH 04/15] ARM: shmobile: APE6EVM uImage rework
[PATCH 05/15] ARM: shmobile: Armadillo800EVA uImage rework [PATCH 06/15] ARM: shmobile: Bock-W uImage rework
[PATCH 07/15] ARM: shmobile: Bonito uImage rework
[PATCH 08/15] ARM: shmobile: KZM9D uImage rework
[PATCH 09/15] ARM: shmobile: KZM9G uImage rework
[PATCH 10/15] ARM: shmobile: Kota2 uImage rework
[PATCH 11/15] ARM: shmobile: Lager uImage rework
[PATCH 12/15] ARM: shmobile: Mackerel uImage rework [PATCH 13/15] ARM: shmobile: Marzen uImage rework
[PATCH 14/15] ARM: shmobile: Armadillo800EVA reference uImage rework [PATCH 15/15] ARM: shmobile: Remove MEMORY_START uImage load address

Quoted 7 lines

Rework the mach-shmobile uImage load address calculation by storing the per-board load addresses in Makefile.boot. This removes the CONFIG_MEMORY_START dependency from Makefile.boot, and it also makes it possible to create safe kernel images that boot on multiple boards.

This is one of several series of code that reworks code not to rely on CONFIG_MEMORY_START/SIZE which in turn is needed for ARCH_MULTIPLATFORM.

Thank you for the patches. I've been waiting for this for a long time :-)

If you need to submit a v2 you might want to squash 05/15 and 14/15.

Quoted 1 line
Signed-off-by Magnus Damm <[email protected]>
Reviewed-by Laurent Pinchart <[email protected]>
Signature · 3 lines
Regards,

Laurent Pinchart
author maintainer
#19 lore raw

cover ARM: shmobile: uImage load address rework

Hi Laurent,

Quoted 26 lines · Laurent Pinchart

Hi Magnus,

Quoted 23 lines · On Wednesday 05 June 2013 16:06:16 Magnus Damm wrote:

ARM: shmobile: uImage load address rework

[PATCH 01/15] ARM: shmobile: Per-board uImage load addresses [PATCH 02/15] ARM: shmobile: AG5EVM uImage rework
[PATCH 03/15] ARM: shmobile: AP4EVB uImage rework
[PATCH 04/15] ARM: shmobile: APE6EVM uImage rework
[PATCH 05/15] ARM: shmobile: Armadillo800EVA uImage rework [PATCH 06/15] ARM: shmobile: Bock-W uImage rework
[PATCH 07/15] ARM: shmobile: Bonito uImage rework
[PATCH 08/15] ARM: shmobile: KZM9D uImage rework
[PATCH 09/15] ARM: shmobile: KZM9G uImage rework
[PATCH 10/15] ARM: shmobile: Kota2 uImage rework
[PATCH 11/15] ARM: shmobile: Lager uImage rework
[PATCH 12/15] ARM: shmobile: Mackerel uImage rework [PATCH 13/15] ARM: shmobile: Marzen uImage rework
[PATCH 14/15] ARM: shmobile: Armadillo800EVA reference uImage rework [PATCH 15/15] ARM: shmobile: Remove MEMORY_START uImage load address

Rework the mach-shmobile uImage load address calculation by storing the per-board load addresses in Makefile.boot. This removes the CONFIG_MEMORY_START dependency from Makefile.boot, and it also makes it possible to create safe kernel images that boot on multiple boards.

Quoted 6 lines
Quoted 2 lines

This is one of several series of code that reworks code not to rely on CONFIG_MEMORY_START/SIZE which in turn is needed for ARCH_MULTIPLATFORM.

Thank you for the patches. I've been waiting for this for a long time :-)

If you need to submit a v2 you might want to squash 05/15 and 14/15.

Yeah, agree, it should have been like that. The KZM9G and Marzen boards are like that.

The reason is that I happened to discover the Armadillo800EVA DT reference code rather late so to fix that I sneaked in an incremental fix as 14/15.

Quoted 3 lines
Quoted 1 line
Signed-off-by Magnus Damm <[email protected]>
Reviewed-by Laurent Pinchart <[email protected]>

Thanks!

/ magnus

#20 lore raw

cover ARM: shmobile: uImage load address rework

In reply to Magnus Damm

Hi

Quoted 17 lines

ARM: shmobile: uImage load address rework

[PATCH 01/15] ARM: shmobile: Per-board uImage load addresses [PATCH 02/15] ARM: shmobile: AG5EVM uImage rework
[PATCH 03/15] ARM: shmobile: AP4EVB uImage rework
[PATCH 04/15] ARM: shmobile: APE6EVM uImage rework
[PATCH 05/15] ARM: shmobile: Armadillo800EVA uImage rework [PATCH 06/15] ARM: shmobile: Bock-W uImage rework
[PATCH 07/15] ARM: shmobile: Bonito uImage rework
[PATCH 08/15] ARM: shmobile: KZM9D uImage rework
[PATCH 09/15] ARM: shmobile: KZM9G uImage rework
[PATCH 10/15] ARM: shmobile: Kota2 uImage rework
[PATCH 11/15] ARM: shmobile: Lager uImage rework
[PATCH 12/15] ARM: shmobile: Mackerel uImage rework [PATCH 13/15] ARM: shmobile: Marzen uImage rework
[PATCH 14/15] ARM: shmobile: Armadillo800EVA reference uImage rework [PATCH 15/15] ARM: shmobile: Remove MEMORY_START uImage load address

I tested these patches on Bock-W board (as 0x60008000 binary), and on Mackerel board (as 0x40008000 binary)
These work well for me :)

I have same opinion with Laurent.
5) and 14) can be 1 patch if you need to sent v2 patches :P

for 6), 12) patch

Tested-by Kuninori Morimoto <[email protected]>

for all patches

Reviewed-by Kuninori Morimoto <[email protected]>

Best regards
---
Kuninori Morimoto

author maintainer
#21 lore raw

cover ARM: shmobile: uImage load address rework

Hi Morimoto-san,

Quoted 21 lines · Kuninori Morimoto

Hi

Quoted 17 lines

ARM: shmobile: uImage load address rework

[PATCH 01/15] ARM: shmobile: Per-board uImage load addresses [PATCH 02/15] ARM: shmobile: AG5EVM uImage rework
[PATCH 03/15] ARM: shmobile: AP4EVB uImage rework
[PATCH 04/15] ARM: shmobile: APE6EVM uImage rework
[PATCH 05/15] ARM: shmobile: Armadillo800EVA uImage rework [PATCH 06/15] ARM: shmobile: Bock-W uImage rework
[PATCH 07/15] ARM: shmobile: Bonito uImage rework
[PATCH 08/15] ARM: shmobile: KZM9D uImage rework
[PATCH 09/15] ARM: shmobile: KZM9G uImage rework
[PATCH 10/15] ARM: shmobile: Kota2 uImage rework
[PATCH 11/15] ARM: shmobile: Lager uImage rework
[PATCH 12/15] ARM: shmobile: Mackerel uImage rework [PATCH 13/15] ARM: shmobile: Marzen uImage rework
[PATCH 14/15] ARM: shmobile: Armadillo800EVA reference uImage rework [PATCH 15/15] ARM: shmobile: Remove MEMORY_START uImage load address

Quoted 3 lines

I tested these patches on Bock-W board (as 0x60008000 binary), and on Mackerel board (as 0x40008000 binary)
These work well for me :)

Thanks for testing.

Quoted 2 lines

I have same opinion with Laurent.
5) and 14) can be 1 patch if you need to sent v2 patches :P

Gotcha!

Quoted 7 lines

for 6), 12) patch

Tested-by Kuninori Morimoto <[email protected]>

for all patches

Reviewed-by Kuninori Morimoto <[email protected]>

Thanks,

/ magnus

#22 lore raw

cover ARM: shmobile: uImage load address rework

In reply to Magnus Damm
Quoted 18 lines · On Wednesday 05 June 2013 16:06:16 Magnus Damm wrote:

ARM: shmobile: uImage load address rework

[PATCH 01/15] ARM: shmobile: Per-board uImage load addresses [PATCH 02/15] ARM: shmobile: AG5EVM uImage rework
[PATCH 03/15] ARM: shmobile: AP4EVB uImage rework
[PATCH 04/15] ARM: shmobile: APE6EVM uImage rework
[PATCH 05/15] ARM: shmobile: Armadillo800EVA uImage rework [PATCH 06/15] ARM: shmobile: Bock-W uImage rework
[PATCH 07/15] ARM: shmobile: Bonito uImage rework
[PATCH 08/15] ARM: shmobile: KZM9D uImage rework
[PATCH 09/15] ARM: shmobile: KZM9G uImage rework
[PATCH 10/15] ARM: shmobile: Kota2 uImage rework
[PATCH 11/15] ARM: shmobile: Lager uImage rework
[PATCH 12/15] ARM: shmobile: Mackerel uImage rework [PATCH 13/15] ARM: shmobile: Marzen uImage rework
[PATCH 14/15] ARM: shmobile: Armadillo800EVA reference uImage rework [PATCH 15/15] ARM: shmobile: Remove MEMORY_START uImage load address

Quoted 7 lines

Rework the mach-shmobile uImage load address calculation by storing the per-board load addresses in Makefile.boot. This removes the CONFIG_MEMORY_START dependency from Makefile.boot, and it also makes it possible to create safe kernel images that boot on multiple boards.

This is one of several series of code that reworks code not to rely on CONFIG_MEMORY_START/SIZE which in turn is needed for ARCH_MULTIPLATFORM.

Looks good to me. I just really wouldn't bother creating so many patches for this when you just modify a single file multiple times. A single patch would be just as good, unless you are desperate to top the LWN patch statistics ;-)

Arnd

author maintainer
#23 lore raw

cover ARM: shmobile: uImage load address rework

Hi Arnd,

Quoted 24 lines · Arnd Bergmann
Quoted 23 lines · On Wednesday 05 June 2013 16:06:16 Magnus Damm wrote:

ARM: shmobile: uImage load address rework

[PATCH 01/15] ARM: shmobile: Per-board uImage load addresses [PATCH 02/15] ARM: shmobile: AG5EVM uImage rework
[PATCH 03/15] ARM: shmobile: AP4EVB uImage rework
[PATCH 04/15] ARM: shmobile: APE6EVM uImage rework
[PATCH 05/15] ARM: shmobile: Armadillo800EVA uImage rework [PATCH 06/15] ARM: shmobile: Bock-W uImage rework
[PATCH 07/15] ARM: shmobile: Bonito uImage rework
[PATCH 08/15] ARM: shmobile: KZM9D uImage rework
[PATCH 09/15] ARM: shmobile: KZM9G uImage rework
[PATCH 10/15] ARM: shmobile: Kota2 uImage rework
[PATCH 11/15] ARM: shmobile: Lager uImage rework
[PATCH 12/15] ARM: shmobile: Mackerel uImage rework [PATCH 13/15] ARM: shmobile: Marzen uImage rework
[PATCH 14/15] ARM: shmobile: Armadillo800EVA reference uImage rework [PATCH 15/15] ARM: shmobile: Remove MEMORY_START uImage load address

Rework the mach-shmobile uImage load address calculation by storing the per-board load addresses in Makefile.boot. This removes the CONFIG_MEMORY_START dependency from Makefile.boot, and it also makes it possible to create safe kernel images that boot on multiple boards.

Quoted 7 lines
Quoted 2 lines

This is one of several series of code that reworks code not to rely on CONFIG_MEMORY_START/SIZE which in turn is needed for ARCH_MULTIPLATFORM.

Looks good to me. I just really wouldn't bother creating so many patches for this when you just modify a single file multiple times. A single patch would be just as good, unless you are desperate to top the LWN patch statistics ;-)

Yes, you got it, always desperate! =)

I guess I had some idea that people could reply to each board specific email with information about testing and potential issues, but so far I have not seen anyone taking advantage of that opportunity.

Thanks,

/ magnus