Skip to contentSkip to conversation

vdpa/ifc: fix vhost message size check issue

PATCH Applied Andy Pei 2 participants 4 messages Jun 21, 2022 – Jul 4, 2022 virtio core

lore
Share & tools
lore

Andy Pei

author
#0 lore raw

PATCH 1/1 vdpa/ifc: fix vhost message size check issue

For vhost message VHOST_USER_GET_CONFIG, we do not check payload size in vhost lib, we check payload size in driver specific ops.
For ifc vdpa driver, we just need to make sure payload size is not smaller than sizeof(struct virtio_blk_config).

Fixes 856d03bcdc54 ("vdpa/ifc: add block operations")
---
 drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vdpa/ifc/ifcvf_vdpa.c +1 -1
index 8bc971c..ac42de9 100644
@@ -1400,7 +1400,7 @@ struct rte_vdpa_dev_info {
 	uint64_t capacity = 0;
 	uint8_t *byte;
 
-	if (size != sizeof(struct virtio_blk_config)) {
+	if (size < sizeof(struct virtio_blk_config)) {
 		DRV_LOG(ERR, "Invalid len: %u, required: %u",
 			size, (uint32_t)sizeof(struct virtio_blk_config));
 		return -1;
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Andy Pei

For vhost message VHOST_USER_GET_CONFIG, we do not check payload size in vhost lib, we check payload size in driver specific ops.
For ifc vdpa driver, we just need to make sure payload size is not smaller than sizeof(struct virtio_blk_config).

Quoted 7 lines
Fixes 856d03bcdc54 ("vdpa/ifc: add block operations")
---
  drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks,
Maxime

#2 lore raw
In reply to Andy Pei
Quoted 6 lines · Andy Pei

For vhost message VHOST_USER_GET_CONFIG, we do not check payload size in vhost lib, we check payload size in driver specific ops.
For ifc vdpa driver, we just need to make sure payload size is not smaller than sizeof(struct virtio_blk_config).

Quoted 6 lines
Fixes 856d03bcdc54 ("vdpa/ifc: add block operations")
---
  drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to dpdk-next-virtio/main.

Thanks,
Maxime

author
#3 lore raw

Hi Maxime,

Thanks for your effort.

Quoted 29 lines

-----Original Message-----
From: Maxime Coquelin <[email protected]>
Sent: Friday, July 1, 2022 9:55 PM
To: Pei, Andy <[email protected]>; [email protected]
Cc: Xia, Chenbo <[email protected]>; Xu, Rosen <[email protected]>; Xiao, QimaiX <[email protected]>
Subject: Re: [PATCH] vdpa/ifc: fix vhost message size check issue

Quoted 1 line · Andy Pei

For vhost message VHOST_USER_GET_CONFIG, we do not check payload

size

Quoted 10 lines

in vhost lib, we check payload size in driver specific ops. For ifc vdpa driver, we just need to make sure payload size is not smaller than sizeof(struct virtio_blk_config).

Fixes 856d03bcdc54 ("vdpa/ifc: add block operations")
---
  drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to dpdk-next-virtio/main.

Thanks,
Maxime