Skip to contentSkip to conversation

KVM: s390: start using the GIB

PATCH Michael Mueller 1 participant 1 message Dec 3, 2018 1 message not in the archive s390

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 41 lines · Cornelia Huck
Quoted 38 lines · On Mon, 3 Dec 2018 11:09:37 +0100 Michael Mueller <[email protected]> wrote:
Quoted 24 lines · Cornelia Huck
Quoted 21 lines · On Fri, 30 Nov 2018 15:32:15 +0100 Michael Mueller <[email protected]> wrote:

By initializing the GIB, it will be used by the kvm host.

---
   Documentation/kmsg/s390/kvm | 12 ++++++++++++
   arch/s390/kvm/kvm-s390.c    | 10 +++++++++-
   2 files changed, 21 insertions(+), 1 deletion(-)
Documentation/kmsg/s390/kvm +5 -0
index 76ffe2012254..6908476a54f1 100644
@@ -10,3 +10,15 @@
    * If this problem persists after a reload of the kvm kernel module, gather
    * Linux debug data and contact your support organization.
    */
+
+/*?
+ * Text: "Failed to initialize GIB rc=%d\n"
+ * Severity: Error
+ * Parameter:
Quoted 8 lines

Documentation/kmsg/s390/kvm line 24

Quoted 7 lines
Documentation/kmsg/s390/kvm +7 -0
+ *   @1: return code of the GIB initialization call
+ * Description:
+ * The initialization if the GIB (Guest Information Block) was not successful.
+ * User action:
+ * If this problem persists after a reload of the kvm kernel module, gather
+ * Linux debug data and contact your support organization.
+ */

This does not exist upstream. Wrong branch?

No, not the wrong branch, wrong file. These are the very first kmsgs for kvm and
it turns out that we defined

Quoted 6 lines
Quoted 3 lines

#define KMSG_COMPONENT "kvm-s390"

as the location.

The upstream s390 features branch does not contain a Documentation/kmsg/ directory. IIRC this was never accepted upstream?

I wasn't aware of that but see it now! So the patch has to be broken up...

Quoted 1 line