Skip to contentSkip to conversation

tty/sysrq: change the definition of sysrq_key_table's element to make it more readable

PATCH Superseded wujunwen 2 participants 3 messages Apr 5, 2022 – Apr 10, 2022 TTY layer and serial drivers

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

wujunwen

author
#0 lore raw

PATCH 1/1 tty/sysrq: change the definition of sysrq_key_table's element to make it more readable

the definition of sysrq_key_table's elements, like sysrq_thaw_op and sysrq_showallcpus_op are massive, so we should make it consistent.

---
 drivers/tty/sysrq.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)
drivers/tty/sysrq.c +6 -8
index bbfd004449b5..9485156bf48b 100644
@@ -274,6 +274,8 @@ static const struct sysrq_key_op sysrq_showallcpus_op = {
 	.action_msg	= "Show backtrace of all active CPUs",
 	.enable_mask	= SYSRQ_ENABLE_DUMP,
 };
+#else
+#define sysrq_showallcpus_op (*(const struct sysrq_key_op *)NULL)
 #endif
 
 static void sysrq_handle_showregs(int key)
@@ -405,6 +407,7 @@ static const struct sysrq_key_op sysrq_moom_op = {
 	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
 };
 
+#ifdef CONFIG_BLOCK
 static void sysrq_handle_thaw(int key)
 {
 	emergency_thaw_all();
@@ -415,6 +418,9 @@ static const struct sysrq_key_op sysrq_thaw_op = {
 	.action_msg	= "Emergency Thaw of all frozen filesystems",
 	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
 };
+#else
+#define sysrq_thaw_op (*(const struct sysrq_key_op *)NULL)
+#endif
 
 static void sysrq_handle_kill(int key)
 {
@@ -468,17 +474,9 @@ static const struct sysrq_key_op *sysrq_key_table[62] = {
 	NULL,				/* g */
 	NULL,				/* h - reserved for help */
 	&sysrq_kill_op,			/* i */
-#ifdef CONFIG_BLOCK
 	&sysrq_thaw_op,			/* j */
-#else
-	NULL,				/* j */
-#endif
 	&sysrq_SAK_op,			/* k */
-#ifdef CONFIG_SMP
 	&sysrq_showallcpus_op,		/* l */
-#else
-	NULL,				/* l */
-#endif
 	&sysrq_showmem_op,		/* m */
 	&sysrq_unrt_op,			/* n */
 	/* o: This will often be registered as 'Off' at init time */
Signature · 1 line
2.25.1
maintainer
#1 lore raw

Hi,

Quoted 1 line · wujunwen

the definition of sysrq_key_table's elements, like sysrq_thaw_op and

The starts the sentence, so should be with capital T.

Quoted 1 line

sysrq_showallcpus_op are massive,

massive?

Quoted 1 line

so we should make it consistent.

You should elaborate consistent to what.

Quoted 1 line

Is this really your real full name?

Other than that, the patch appears to be correct.

Quoted 52 lines
  drivers/tty/sysrq.c | 14 ++++++--------
  1 file changed, 6 insertions(+), 8 deletions(-)
drivers/tty/sysrq.c +6 -8
index bbfd004449b5..9485156bf48b 100644
@@ -274,6 +274,8 @@ static const struct sysrq_key_op sysrq_showallcpus_op = {
  	.action_msg	= "Show backtrace of all active CPUs",
  	.enable_mask	= SYSRQ_ENABLE_DUMP,
  };
+#else
+#define sysrq_showallcpus_op (*(const struct sysrq_key_op *)NULL)
  #endif
 
  static void sysrq_handle_showregs(int key)
@@ -405,6 +407,7 @@ static const struct sysrq_key_op sysrq_moom_op = {
  	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
  };
 
+#ifdef CONFIG_BLOCK
  static void sysrq_handle_thaw(int key)
  {
  	emergency_thaw_all();
@@ -415,6 +418,9 @@ static const struct sysrq_key_op sysrq_thaw_op = {
  	.action_msg	= "Emergency Thaw of all frozen filesystems",
  	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
  };
+#else
+#define sysrq_thaw_op (*(const struct sysrq_key_op *)NULL)
+#endif
 
  static void sysrq_handle_kill(int key)
  {
@@ -468,17 +474,9 @@ static const struct sysrq_key_op *sysrq_key_table[62] = {
  	NULL,				/* g */
  	NULL,				/* h - reserved for help */
  	&sysrq_kill_op,			/* i */
-#ifdef CONFIG_BLOCK
  	&sysrq_thaw_op,			/* j */
-#else
-	NULL,				/* j */
-#endif
  	&sysrq_SAK_op,			/* k */
-#ifdef CONFIG_SMP
  	&sysrq_showallcpus_op,		/* l */
-#else
-	NULL,				/* l */
-#endif
  	&sysrq_showmem_op,		/* m */
  	&sysrq_unrt_op,			/* n */
  	/* o: This will often be registered as 'Off' at init time */
Signature · 2 lines
js
suse labs
author
#2 lore raw

Dear Jiri
Sorry ,sysrq_showallcpus_op etc. are not massive,but confused. "CONFIG_TRACING" make the definition of the sysrq_ftrace_dump outside sysrq_key_table
but "CONFIG_SMP" make the definition of the sysrq_showallcpus_op inside sysrq_key_table. so unitify the code will make code more readable. wujunwen is realy my name,Junwen Wu is better.

Jiri, I plan to modify the commit message as follow:
Subject: [PATCH v1] tty/sysrq: change the definition of sysrq_key_table's element to make it more readable

The definition of sysrq_key_table's elements, like sysrq_thaw_op and sysrq_showallcpus_op are not consistent with sysrq_ftrace_dump_op, Consistency makes code more readable.

Is this ok?

beside,if this commit message is ok,the subject will comment PATCH v2 ?

Thanks