Skip to contentSkip to conversation

compile problem in current x86.git

DISCUSSION Jeremy Fitzhardinge 3 participants 7 messages Feb 25, 2008 – Feb 26, 2008

lore
Share & tools
lore
#0 lore raw

CC arch/x86/kernel/traps_32.o
/home/jeremy/hg/xen/paravirt/linux/arch/x86/kernel/traps_32.c:59:27: error: asm/kmemcheck.h: No such file or directory

asm-x86/kmemcheck.h does seem to be completely missing. Looks like 8db0acefb3025795abe3f37669354677a03de680 "x86: add hooks for kmemcheck" should have added the file.

J

#1 lore raw

Hello!

Quoted 7 lines · Jeremy Fitzhardinge

CC arch/x86/kernel/traps_32.o
/home/jeremy/hg/xen/paravirt/linux/arch/x86/kernel/traps_32.c:59:27: error: asm/kmemcheck.h: No such file or directory

asm-x86/kmemcheck.h does seem to be completely missing. Looks like 8db0acefb3025795abe3f37669354677a03de680 "x86: add hooks for kmemcheck" should have added the file.

Hm. This is x86#testing, no? I don't think there's any kmemcheck code whatsoever in other branches.

The file should be added with this commit:

kmemcheck: add the kmemcheck core
http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commit;h=c83d05d69382945c92a2e7a2b168c1cc2aa77c29

Vegard

#2 lore raw
Quoted 11 lines · Vegard Nossum
Quoted 3 lines

asm-x86/kmemcheck.h does seem to be completely missing. Looks like 8db0acefb3025795abe3f37669354677a03de680 "x86: add hooks for kmemcheck" should have added the file.

Hm. This is x86#testing, no? I don't think there's any kmemcheck code whatsoever in other branches.

The file should be added with this commit:

kmemcheck: add the kmemcheck core
http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commit;h=c83d05d69382945c92a2e7a2b168c1cc2aa77c29

yes, x86.git looks fine here too:

~/linux.trees.git> git-checkout -b tmp x86/testing
Branch tmp set up to track remote branch refs/remotes/x86/testing. Switched to a new branch "tmp"
~/linux.trees.git> cd include/asm-x86/ ~/linux.trees.git/include/asm-x86> ls -l kmemcheck.h -rw-rw-r-- 1 mingo mingo 55 2008-02-25 21:41 kmemcheck.h ~/linux.trees.git/include/asm-x86> cd .. ~/linux.trees.git/include> cd ..
~/linux.trees.git> ls -ldt include/asm-x86/kmemcheck.h -rw-rw-r-- 1 mingo mingo 55 2008-02-25 21:41 include/asm-x86/kmemcheck.h ~/linux.trees.git> git-log | head -1
commit c9d2f5489cec70f814bf64033290e5f05b4d7f33

Ingo

#3 lore raw
Quoted 3 lines
Quoted 3 lines

Hm. This is x86#testing, no? I don't think there's any kmemcheck code whatsoever in other branches.

ah. that was x86.git#mm i think - a kmemcheck commit indeed prematurely got into that branch.

I've updated x86.git and it should all have the correct ordering now. (as of HEAD c9d2f5489cec70f814bf6)

Jeremy, you might want to start tracking x86.git#testing:

http://people.redhat.com/mingo/x86.git/README

if you want to follow the latest & greatest x86.git code.

Ingo

#5 lore raw
Quoted 9 lines · Jeremy Fitzhardinge
Quoted 6 lines · Ingo Molnar

Jeremy, you might want to start tracking x86.git#testing:

http://people.redhat.com/mingo/x86.git/README

if you want to follow the latest & greatest x86.git code.

Right, will do.

generally it's as well tested on x86 as #mm (so you should not notice any difference while tracking it), but it also includes work in progress bits that might touch other subsystems as well.

Ingo

#6 lore raw
In reply to Ingo Molnar
Quoted 16 lines · Ingo Molnar
Quoted 10 lines · Vegard Nossum
Quoted 4 lines

asm-x86/kmemcheck.h does seem to be completely missing. Looks like 8db0acefb3025795abe3f37669354677a03de680 "x86: add hooks for kmemcheck" should have added the file.

Hm. This is x86#testing, no? I don't think there's any kmemcheck code whatsoever in other branches.

The file should be added with this commit:

kmemcheck: add the kmemcheck core http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commit;h=c83d05d69382945c92a2e7a2b168c1cc2aa77c29

yes, x86.git looks fine here too:

Quoted 12 lines

~/linux.trees.git> git-checkout -b tmp x86/testing
Branch tmp set up to track remote branch refs/remotes/x86/testing. Switched to a new branch "tmp"
~/linux.trees.git> cd include/asm-x86/ ~/linux.trees.git/include/asm-x86> ls -l kmemcheck.h -rw-rw-r-- 1 mingo mingo 55 2008-02-25 21:41 kmemcheck.h ~/linux.trees.git/include/asm-x86> cd .. ~/linux.trees.git/include> cd ..
~/linux.trees.git> ls -ldt include/asm-x86/kmemcheck.h -rw-rw-r-- 1 mingo mingo 55 2008-02-25 21:41 include/asm-x86/kmemcheck.h ~/linux.trees.git> git-log | head -1
commit c9d2f5489cec70f814bf64033290e5f05b4d7f33

I'm using #mm. Should I be using #testing?

J