drm/amdgpu: fix unload driver fail
Subsystems (3)
PATCH 1/1 drm/amdgpu: fix unload driver fail
dc_destroy should be called amdgpu_cgs_destroy_device, as it will use cgs context to read or write registers.
Signed-off-by Emily Deng <[email protected]>
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +4 -3
@@ -616,6 +616,10 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)static void amdgpu_dm_fini (struct amdgpu_device *adev) {amdgpu_dm_destroy_drm_device (&adev->dm); + +/* DC Destroy TODO: Replace destroy DAL */ +if (adev->dm.dc) +dc_destroy (&adev->dm.dc);/* * TODO: pageflip, vlank interrupt *
@@ -630,9 +634,6 @@ static void amdgpu_dm_fini(struct amdgpu_device *adev)mod_freesync_destroy (adev->dm.freesync_module); adev->dm.freesync_module =NULL ; } -/* DC Destroy TODO: Replace destroy DAL */ -if (adev->dm.dc) -dc_destroy (&adev->dm.dc);mutex_destroy (&adev->dm.dc_lock);
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1558691520-5819-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org
Christian König
Acked-byAm 24.05.19 um 11:52 schrieb Emily Deng:
Quoted 4 lines
dc_destroyshould be calledamdgpu_cgs_destroy_device, as it will use cgs context to read or write registers.Signed-off-by Emily Deng <[email protected]>
Acked-by Christian König <[email protected]>
Quoted 20 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +4
-0@@ -616,6 +616,10 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)static void amdgpu_dm_fini (struct amdgpu_device *adev) {amdgpu_dm_destroy_drm_device (&adev->dm); + +/* DC Destroy TODO: Replace destroy DAL */ +if (adev->dm.dc) +dc_destroy (&adev->dm.dc);/* * TODO: pageflip, vlank interrupt *
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static void amdgpu_dm_fini(struct amdgpu_device *adev) · line 639
Quoted 9 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0
-3@@ -630,9 +634,6 @@ static void amdgpu_dm_fini(struct amdgpu_device *adev)mod_freesync_destroy (adev->dm.freesync_module); adev->dm.freesync_module =NULL ; } -/* DC Destroy TODO: Replace destroy DAL */ -if (adev->dm.dc) -dc_destroy (&adev->dm.dc);mutex_destroy (&adev->dm.dc_lock);
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx